From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 112E9C433F5 for ; Mon, 29 Nov 2021 13:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0GaoAbFUFTyTQVwvspHl6wXk3wR6KSbVkuyOeYuHs7g=; b=Dexy66Oxg8P6Va oZU8lxtrlzoy/qMd1J036RYpHX7Q1VuaLZKmoO1z+5NJPTQrZQP1dGkgEinKB5WCRxBdS2EaCgT6B pyIrJeXW0Li5pSjBb2vB5veLXMQTr7oTPJpSxhdbp3x7U8b3NCcynA6fqtUc3E9XRwUmctlmGgw26 YAeuop/cSSn2aSqPXkDwrWX/PX/CMVOqWIxdSuYqH9SO87uBqMQ5tzOoDvlVXkvJbj+GvETSmFdva UPGyqzS2R1s3mttiNvOZsUwv5t7SQ3GF7679edaMje9tv3QT3NOl1NN6ZZi0zhSf4MkNhPbJAa8R5 h6kX3WWfN8VY5x7Ab6Nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrgRu-000oCe-Uk; Mon, 29 Nov 2021 13:12:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrgRq-000oBz-S9; Mon, 29 Nov 2021 13:12:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 724A0150C; Mon, 29 Nov 2021 05:11:55 -0800 (PST) Received: from e123427-lin.arm.com (unknown [10.57.34.225]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 738B53F766; Mon, 29 Nov 2021 05:11:52 -0800 (PST) From: Lorenzo Pieralisi To: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com, robh@kernel.org, jim2101024@gmail.com, kw@linux.com, Christophe JAILLET , bhelgaas@google.com Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' Date: Mon, 29 Nov 2021 13:11:45 +0000 Message-Id: <163819142462.10670.2516167038486090067.b4-ty@arm.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_051158_975966_40F636B9 X-CRM114-Status: UNSURE ( 6.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 7 Nov 2021 09:32:58 +0100, Christophe JAILLET wrote: > The 'used' field of 'struct brcm_msi' is used as a bitmap. So it should > be declared as so (i.e. unsigned long *). > > This fixes an harmless Coverity warning about array vs singleton usage. > > This bitmap can be BRCM_INT_PCI_MSI_LEGACY_NR or BRCM_INT_PCI_MSI_NR long. > So, while at it, document it, should it help someone in the future. Applied to pci/brcmstb, thanks! [1/1] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' https://git.kernel.org/lpieralisi/pci/c/3e46790d16 Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9C7BC433EF for ; Mon, 29 Nov 2021 13:13:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239217AbhK2NRO (ORCPT ); Mon, 29 Nov 2021 08:17:14 -0500 Received: from foss.arm.com ([217.140.110.172]:39010 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232071AbhK2NPN (ORCPT ); Mon, 29 Nov 2021 08:15:13 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 724A0150C; Mon, 29 Nov 2021 05:11:55 -0800 (PST) Received: from e123427-lin.arm.com (unknown [10.57.34.225]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 738B53F766; Mon, 29 Nov 2021 05:11:52 -0800 (PST) From: Lorenzo Pieralisi To: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com, robh@kernel.org, jim2101024@gmail.com, kw@linux.com, Christophe JAILLET , bhelgaas@google.com Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' Date: Mon, 29 Nov 2021 13:11:45 +0000 Message-Id: <163819142462.10670.2516167038486090067.b4-ty@arm.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 7 Nov 2021 09:32:58 +0100, Christophe JAILLET wrote: > The 'used' field of 'struct brcm_msi' is used as a bitmap. So it should > be declared as so (i.e. unsigned long *). > > This fixes an harmless Coverity warning about array vs singleton usage. > > This bitmap can be BRCM_INT_PCI_MSI_LEGACY_NR or BRCM_INT_PCI_MSI_NR long. > So, while at it, document it, should it help someone in the future. Applied to pci/brcmstb, thanks! [1/1] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' https://git.kernel.org/lpieralisi/pci/c/3e46790d16 Thanks, Lorenzo