From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E1BC433EF for ; Mon, 20 Dec 2021 14:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233451AbhLTO1q (ORCPT ); Mon, 20 Dec 2021 09:27:46 -0500 Received: from mail-oo1-f53.google.com ([209.85.161.53]:44681 "EHLO mail-oo1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbhLTO1q (ORCPT ); Mon, 20 Dec 2021 09:27:46 -0500 Received: by mail-oo1-f53.google.com with SMTP id t9-20020a4a8589000000b002c5c4d19723so3100723ooh.11 for ; Mon, 20 Dec 2021 06:27:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=Y1Fcs4t+UtdLO20EaOlKh13hRPU6qA8it6kK1OWCPEY=; b=ysjNvuxJ2eCE9Mg6caxEuP+IcT3+XlxoTnYoS2lBHqKOoIlj3zE11uWBuDCcl36K9n hTIYoym3B5hoTTr3EWC1YPpgkf/VbmGrX2QY3D/z3OdyjPwmtUwi2ko05UaGgXd5dM8x wvJ9ofZ8YZLicwyCu9Kzcf3JO4MVjhDDdPUTYWzwGAMqIwPdb6OgTzatErUsALEP1XgW //m7Ll5l99dQmYddS0IIXqoMjS9LBT9YUt9HUj/j/Vl2Fp+NpKZzonA0ZPmCFqoymp6U BO7PGO7ZAA29/4t9tYZ9DE8OGc1+eoPk/hs8f5xxN3bNIdfB+86jvYnqhmYysQaDzt20 VRyw== X-Gm-Message-State: AOAM530ztYCy5s74ogP8hzKmclKusXk897vmEHy+4A71oHEAr8ssKIqJ GroUvyAGbFCluykngwMukQ== X-Google-Smtp-Source: ABdhPJyOpmklZ25MWSq9fd1Qj1gymdAdTprfXup4FhgZ3KkOBjlSDYRAuJTWwm2JMIlitSZ80VgO3g== X-Received: by 2002:a4a:e288:: with SMTP id k8mr10224338oot.23.1640010465884; Mon, 20 Dec 2021 06:27:45 -0800 (PST) Received: from robh.at.kernel.org ([12.252.7.226]) by smtp.gmail.com with ESMTPSA id bq5sm3544930oib.55.2021.12.20.06.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 06:27:45 -0800 (PST) Received: (nullmailer pid 3388819 invoked by uid 1000); Mon, 20 Dec 2021 14:27:43 -0000 From: Rob Herring To: Sascha Hauer Cc: =?utf-8?q?Heiko_St=C3=BCbner?= , Peter Geis , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Andy Yan , kernel@pengutronix.de, Benjamin Gaignard , devicetree@vger.kernel.org, Michael Riesch , Sandy Huang In-Reply-To: <20211220110630.3521121-9-s.hauer@pengutronix.de> References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-9-s.hauer@pengutronix.de> Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Date: Mon, 20 Dec 2021 08:27:43 -0600 Message-Id: <1640010463.847707.3388818.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 20 Dec 2021 12:06:16 +0100, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml: properties:clock-names:items: 'oneOf' conditional failed, one must be fixed: [{}, {}, {'enum': ['cec', 'grf', 'ref']}, {'enum': ['grf', 'ref']}, {'const': ['ref']}] is not of type 'object' ['ref'] is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml: ignoring, error in schema: properties: clock-names: items warning: no schema found in file: ./Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.example.dt.yaml:0:0: /example-0/hdmi@ff980000: failed to match any schema with compatible: ['rockchip,rk3288-dw-hdmi'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1570972 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B77DC433F5 for ; Mon, 20 Dec 2021 14:27:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BFA710FFE5; Mon, 20 Dec 2021 14:27:47 +0000 (UTC) Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id A030610FFD5 for ; Mon, 20 Dec 2021 14:27:46 +0000 (UTC) Received: by mail-oo1-f49.google.com with SMTP id p2-20020a4adfc2000000b002c2676904fdso3091072ood.13 for ; Mon, 20 Dec 2021 06:27:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=Y1Fcs4t+UtdLO20EaOlKh13hRPU6qA8it6kK1OWCPEY=; b=Xio4Wg0AwxiG1lczqNtAVm5pEL+qF+z4YxSqGkty5jRiLOVk6gSPVrDN9w0WYMn7Tn c+CaFT+OnE52qtO039lSYqd03f0vwcItgg4VbeWlvM6nbSeJlTfhX9U1RWgL2xSNh855 w1DQeL42BTgkCplnp94+NzsVgnFiux8BBp4dvs5DW57t36immAD5ajPO6UwAU8DiyCw7 d4D7Qz3zuLMEmp2bR3RJxg/bEYH0Usr2rprCLYH/h2gS9YtVSa7gqkhS47RAxUVPtwws JJWIwbiCMsKXm4MeJZ+ODphtXmI6N/Y6Ao4xRXnWrqFT0uJbUVZ6H4sNOvGj4JEmvaAY ZRKg== X-Gm-Message-State: AOAM533nUDvXxaHMbtBCxC+hErDkZp/Z8Yx2YeSp8ZRThvJJuHhuLFHi 555+S1G+3UdoF9yj5s/N4g== X-Google-Smtp-Source: ABdhPJyOpmklZ25MWSq9fd1Qj1gymdAdTprfXup4FhgZ3KkOBjlSDYRAuJTWwm2JMIlitSZ80VgO3g== X-Received: by 2002:a4a:e288:: with SMTP id k8mr10224338oot.23.1640010465884; Mon, 20 Dec 2021 06:27:45 -0800 (PST) Received: from robh.at.kernel.org ([12.252.7.226]) by smtp.gmail.com with ESMTPSA id bq5sm3544930oib.55.2021.12.20.06.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 06:27:45 -0800 (PST) Received: (nullmailer pid 3388819 invoked by uid 1000); Mon, 20 Dec 2021 14:27:43 -0000 From: Rob Herring To: Sascha Hauer In-Reply-To: <20211220110630.3521121-9-s.hauer@pengutronix.de> References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-9-s.hauer@pengutronix.de> Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Date: Mon, 20 Dec 2021 08:27:43 -0600 Message-Id: <1640010463.847707.3388818.nullmailer@robh.at.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , Peter Geis , Andy Yan , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 20 Dec 2021 12:06:16 +0100, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml: properties:clock-names:items: 'oneOf' conditional failed, one must be fixed: [{}, {}, {'enum': ['cec', 'grf', 'ref']}, {'enum': ['grf', 'ref']}, {'const': ['ref']}] is not of type 'object' ['ref'] is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml: ignoring, error in schema: properties: clock-names: items warning: no schema found in file: ./Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.example.dt.yaml:0:0: /example-0/hdmi@ff980000: failed to match any schema with compatible: ['rockchip,rk3288-dw-hdmi'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1570972 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDED7C433F5 for ; Mon, 20 Dec 2021 14:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BvNG42Wtt8ekGO5rOyBN42rOGDPrz874PZOIze+iAPg=; b=r/ej/YGh0ztMl3 gfVdGJlmaj4n0dp0siRELwulrCwpovJq/hKmNzUj7vjVapj5wrR2ZKOLCdKEjTLzECQlmRQ85h5sc bNQ7CWrgPGA9QUsCLn2EVSVmj+9J+6UiMPmzA2jVM8JNBHrpbNomtuThbV5Vb5mWZNZWylbOrmLko Nye42PvG75qCC3oHDF8Dd3Kl4Re0bRSteNZ8h8ZWzL7/07VpRIHN0T6QXp8xt0AH4pTqsyhT7qK4m ZciFNbqFrDdcLwE5Vsdi56G6Dz0mTssGBFwoYlBI2J4Mkbczc9KVlBsSnSgNPhzSITEO+EiMl2mDK F3LeFpcnrTdhvHQUCx8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzJfh-002nT4-5M; Mon, 20 Dec 2021 14:29:49 +0000 Received: from mail-oo1-f51.google.com ([209.85.161.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzJdk-002mui-5x; Mon, 20 Dec 2021 14:27:52 +0000 Received: by mail-oo1-f51.google.com with SMTP id x1-20020a4aea01000000b002c296d82604so3110537ood.9; Mon, 20 Dec 2021 06:27:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=Y1Fcs4t+UtdLO20EaOlKh13hRPU6qA8it6kK1OWCPEY=; b=WLc2QNKXmc0IN1UA0ejHCWoo50mIUefHxZFZZlfnHLHB6GYNKxtL2g4NJMyBZUCFOh /gKCVMsVWytIXA2SeF1gom9W18z3eQjCS+QurxljpdH/1GeB68UIb3LTTo57+uyM82Lu OnVC6dI3n+6JRpnhxXiJtu839aSiw4uqKn9G/NDjqMnBBa2M0uPaFzgDri/dbBY9057t bgINnbG0CLp8dm0eU4W97ct0yibJbFFChqrslXNLW1lJtQho/m8eg5PgzkyyTu77zkvE BJPKfdi3zwMaMAMMudg7kA6Fq16iudTujTkFYIM8QuPdAdF249hvpzZnkBGtldlgu0ed Urog== X-Gm-Message-State: AOAM531mschRh2XqCNxQug0zfqZBGEjAX8y4FvXL7hgoTc+P/Il+wTVM XRnAMleVCQY0tHkSlK4QzE8HOSKcuA== X-Google-Smtp-Source: ABdhPJyOpmklZ25MWSq9fd1Qj1gymdAdTprfXup4FhgZ3KkOBjlSDYRAuJTWwm2JMIlitSZ80VgO3g== X-Received: by 2002:a4a:e288:: with SMTP id k8mr10224338oot.23.1640010465884; Mon, 20 Dec 2021 06:27:45 -0800 (PST) Received: from robh.at.kernel.org ([12.252.7.226]) by smtp.gmail.com with ESMTPSA id bq5sm3544930oib.55.2021.12.20.06.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 06:27:45 -0800 (PST) Received: (nullmailer pid 3388819 invoked by uid 1000); Mon, 20 Dec 2021 14:27:43 -0000 From: Rob Herring To: Sascha Hauer Cc: =?utf-8?q?Heiko_St=C3=BCbner?= , Peter Geis , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Andy Yan , kernel@pengutronix.de, Benjamin Gaignard , devicetree@vger.kernel.org, Michael Riesch , Sandy Huang In-Reply-To: <20211220110630.3521121-9-s.hauer@pengutronix.de> References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-9-s.hauer@pengutronix.de> Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Date: Mon, 20 Dec 2021 08:27:43 -0600 Message-Id: <1640010463.847707.3388818.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211220_062748_337502_AFD2F845 X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mon, 20 Dec 2021 12:06:16 +0100, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml: properties:clock-names:items: 'oneOf' conditional failed, one must be fixed: [{}, {}, {'enum': ['cec', 'grf', 'ref']}, {'enum': ['grf', 'ref']}, {'const': ['ref']}] is not of type 'object' ['ref'] is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml: ignoring, error in schema: properties: clock-names: items warning: no schema found in file: ./Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.example.dt.yaml:0:0: /example-0/hdmi@ff980000: failed to match any schema with compatible: ['rockchip,rk3288-dw-hdmi'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1570972 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01F74C433EF for ; Mon, 20 Dec 2021 14:30:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kLcf5O3Kt72/yzS7M9iMuHmCcsLC7ZMk07uxMkdfrGs=; b=PvgIkBhy0DXYAu 9pYbagtNEonspM9nGeSvRRrtEEu4/nHlOzG5Q2OYGqLJjvpjvE1oO8WSbZ9+j6A+DRtaElzanYLYg 6g63Zcpl+X/6WX0czNPn229e09ecAROxuwxCm0Uk+WTM9XtJ535oWqc2FBCQ0dSePFNYLtaYuAPfa DlJEZjdGs9D3bSjpAeO2eXPLScOOcJRAM1JjyuKhj5Iz/xaefWxv+p3AO8AYM1avo9jZRqc9RH7bj uJ0sKP8lw2a9FsIA60UeQ2KlyEiOh69EULUYqnfaNIEcOgMUeXHfcsWos7FakRRtBA2Di86pOGqLd rbqfCL40nlwOgtKSbC+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzJdy-002mzI-0s; Mon, 20 Dec 2021 14:28:02 +0000 Received: from mail-oo1-f51.google.com ([209.85.161.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzJdk-002mui-5x; Mon, 20 Dec 2021 14:27:52 +0000 Received: by mail-oo1-f51.google.com with SMTP id x1-20020a4aea01000000b002c296d82604so3110537ood.9; Mon, 20 Dec 2021 06:27:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=Y1Fcs4t+UtdLO20EaOlKh13hRPU6qA8it6kK1OWCPEY=; b=WLc2QNKXmc0IN1UA0ejHCWoo50mIUefHxZFZZlfnHLHB6GYNKxtL2g4NJMyBZUCFOh /gKCVMsVWytIXA2SeF1gom9W18z3eQjCS+QurxljpdH/1GeB68UIb3LTTo57+uyM82Lu OnVC6dI3n+6JRpnhxXiJtu839aSiw4uqKn9G/NDjqMnBBa2M0uPaFzgDri/dbBY9057t bgINnbG0CLp8dm0eU4W97ct0yibJbFFChqrslXNLW1lJtQho/m8eg5PgzkyyTu77zkvE BJPKfdi3zwMaMAMMudg7kA6Fq16iudTujTkFYIM8QuPdAdF249hvpzZnkBGtldlgu0ed Urog== X-Gm-Message-State: AOAM531mschRh2XqCNxQug0zfqZBGEjAX8y4FvXL7hgoTc+P/Il+wTVM XRnAMleVCQY0tHkSlK4QzE8HOSKcuA== X-Google-Smtp-Source: ABdhPJyOpmklZ25MWSq9fd1Qj1gymdAdTprfXup4FhgZ3KkOBjlSDYRAuJTWwm2JMIlitSZ80VgO3g== X-Received: by 2002:a4a:e288:: with SMTP id k8mr10224338oot.23.1640010465884; Mon, 20 Dec 2021 06:27:45 -0800 (PST) Received: from robh.at.kernel.org ([12.252.7.226]) by smtp.gmail.com with ESMTPSA id bq5sm3544930oib.55.2021.12.20.06.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 06:27:45 -0800 (PST) Received: (nullmailer pid 3388819 invoked by uid 1000); Mon, 20 Dec 2021 14:27:43 -0000 From: Rob Herring To: Sascha Hauer Cc: =?utf-8?q?Heiko_St=C3=BCbner?= , Peter Geis , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Andy Yan , kernel@pengutronix.de, Benjamin Gaignard , devicetree@vger.kernel.org, Michael Riesch , Sandy Huang In-Reply-To: <20211220110630.3521121-9-s.hauer@pengutronix.de> References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <20211220110630.3521121-9-s.hauer@pengutronix.de> Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Date: Mon, 20 Dec 2021 08:27:43 -0600 Message-Id: <1640010463.847707.3388818.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211220_062748_337502_AFD2F845 X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 20 Dec 2021 12:06:16 +0100, Sascha Hauer wrote: > "vpll" is a misnomer. A clock input to a device should be named after > the usage in the device, not after the clock that drives it. On the > rk3568 the same clock is driven by the HPLL. > To fix that, this patch renames the vpll clock to ref clock. > > Signed-off-by: Sascha Hauer > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml: properties:clock-names:items: 'oneOf' conditional failed, one must be fixed: [{}, {}, {'enum': ['cec', 'grf', 'ref']}, {'enum': ['grf', 'ref']}, {'const': ['ref']}] is not of type 'object' ['ref'] is not of type 'string' from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml: ignoring, error in schema: properties: clock-names: items warning: no schema found in file: ./Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.example.dt.yaml:0:0: /example-0/hdmi@ff980000: failed to match any schema with compatible: ['rockchip,rk3288-dw-hdmi'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1570972 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel