All of lore.kernel.org
 help / color / mirror / Atom feed
From: albin_yang <albin_yang@163.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	yang.wei9@zte.com.cn
Subject: Re:Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
Date: Wed, 6 Feb 2019 23:13:01 +0800 (CST)	[thread overview]
Message-ID: <164ecb6c.24dc.168c35e9179.Coremail.albin_yang@163.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1902051816130.9991@eddie.linux-mips.org>

At 2019-02-06 03:57:34, "Maciej W. Rozycki" <macro@linux-mips.org> wrote:
>On Wed, 6 Feb 2019, Yang Wei wrote:
>
>Reviewed-by: Maciej W. Rozycki <macro@linux-mips.org>
>
> It looks to me the driver has to be reviewed WRT `dev_kfree_skb' vs 
>`kfree_skb' use too.  I'll have a look into it unless you are happy to do 
>that.
>
> Thanks for your contribution!
>
Hi, Maciej

I think kfree_skb() should be called when skb is dropped by network drivers. 
I found that many network drivers have such problems that not use 
kfree_skb/consume_skb properly. Maybe because 'drop profiles' appears later 
than many network drivers?

The problem 'dev_kfree_skb' vs 'kfree_skb' should be fixed. I think that is 
lower priority than the current patch. Network driver should not perturb 
drop profiles when skb successful xmit.

Thanks
Yang

  reply	other threads:[~2019-02-06 15:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-05 16:01 [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles Yang Wei
2019-02-05 19:57 ` Maciej W. Rozycki
2019-02-06 15:13   ` albin_yang [this message]
2019-02-07  1:42 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=164ecb6c.24dc.168c35e9179.Coremail.albin_yang@163.com \
    --to=albin_yang@163.com \
    --cc=davem@davemloft.net \
    --cc=macro@linux-mips.org \
    --cc=netdev@vger.kernel.org \
    --cc=yang.wei9@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.