From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D89BCCA486 for ; Tue, 7 Jun 2022 06:39:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237114AbiFGGjX (ORCPT ); Tue, 7 Jun 2022 02:39:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237123AbiFGGjV (ORCPT ); Tue, 7 Jun 2022 02:39:21 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35E08B0A7C for ; Mon, 6 Jun 2022 23:39:20 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id n10so33165720ejk.5 for ; Mon, 06 Jun 2022 23:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+6eJuTNYhenhOtSy0mpWdMyC3zMMcmWC680KdPh5O/c=; b=HYozM8kFiTcwqKrVxYDLCrX0493cz93zCKZJ+f8P4vW52obPXnTq6NV3kh1FoHfz/G X7fCON7a3YXvLmCYLMb+5TKI6U8CRoyGk1XVbE+v2dqJZU4GmCu7YVFqieiSRxDesBBv EnCAKtz9K9i+BZiMcySVBRAt5VYZiUFrgSciSMlfiDD+pJsVjpI5akEzEcegUZ5wFBvw JyxMduaLcnkgClGEdFK7A82CrDWTQvLxJKe4jDuWXaS1lO4J+IpQitElubvTUunFLq4/ X4UXNzx72E7wcm3vvgo+19Mc1hGGRqsjDGQxY7tiZXGAxaojashVw2hVrZ7AWz77Q663 FxXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+6eJuTNYhenhOtSy0mpWdMyC3zMMcmWC680KdPh5O/c=; b=sadS0qHD0wOe7vyn65nhmtUQLs/SLJA9ZgVXl9P2EBtiKXRhpYtmayobLBmcokh4rk uE3zr30zJlCHTjdydBBTGEMGvpYKPfxmPAg5Vkr7Ny4boZk83JO1N8/aAFCnIJUOz/TZ oBm9croPVzUe+MtrEXhrKVnQSDcxI1ZrKXL0RaFSndrKG1stAo3Mz5yzEYGuMv1YNn8f Vb/4nwp27etBDiUBaCBhr88/kNyiEniOHqKyvX5ohmbBDHFXvjv0Zs0EHA472GilQp/l 5d39jwuh94nJrbiBsETcYWozh8Z7vxc9TNMHf/gCoDyqdt5FqkemaF3YX4SmccFr5rIP 59mw== X-Gm-Message-State: AOAM532+O/w37QzHc8t7ZBHo8ykvAi+7+xYsADOguf+xpFi3nbqLArd4 nZo/vKnFtBU3lzMQR0k+UtEHew== X-Google-Smtp-Source: ABdhPJxJC6R9vm7E7RbQ7imv1QtZeFxdBWu2Z8oRZQhCapGo8C6J6E4SBIOg2hjT2XFEC6lAoeIJAw== X-Received: by 2002:a17:907:2d29:b0:70e:8b1c:c3f0 with SMTP id gs41-20020a1709072d2900b0070e8b1cc3f0mr18729905ejc.37.1654583958428; Mon, 06 Jun 2022 23:39:18 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id jo13-20020a170906f6cd00b006febc86b8besm7016888ejb.117.2022.06.06.23.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 23:39:18 -0700 (PDT) From: Krzysztof Kozlowski To: linux-arm-kernel@lists.infradead.org, Sylwester Nawrocki , Rob Herring , Tomasz Figa , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Linus Walleij , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Alim Akhtar Cc: Chanho Park Subject: Re: (subset) [PATCH v3 3/8] ARM: dts: s5pv210: use local header for pinctrl register values Date: Tue, 7 Jun 2022 08:39:11 +0200 Message-Id: <165458395109.7886.10195566966608207927.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220605160508.134075-4-krzysztof.kozlowski@linaro.org> References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> <20220605160508.134075-4-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sun, 5 Jun 2022 18:05:03 +0200, Krzysztof Kozlowski wrote: > The DTS uses hardware register values directly in pin controller pin > configuration. These are not some IDs or other abstraction layer but > raw numbers used in the registers. > > These numbers were previously put in the bindings header to avoid code > duplication and to provide some context meaning (name), but they do not > fit the purpose of bindings. It is also quite confusing to use > constants prefixed with Exynos for other SoC, because there is actually > nothing here in common, except the actual value. > > [...] Applied, thanks! [3/8] ARM: dts: s5pv210: use local header for pinctrl register values https://git.kernel.org/krzk/linux/c/7fd554de160eed060e7819aa42ca0478c9e0f4cb Best regards, -- Krzysztof Kozlowski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3323C43334 for ; Tue, 7 Jun 2022 06:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=68OadWEofUC03KeYyyLv8ms1CRrcDpKIQMu3IrVmnfs=; b=DsCWYmIhd6YQvu Nr43Pef/kD0kjeauu/ZCfzNO9HROD/qEVU16tBwDJFxkbiyTCz7HbCFvb3PHK9nc24jdX5tRPDHkW iifQyFD8jWlpzuOYAn2rriXiyZQ6z+ayzwiMMxMrXhFCTuCK6Sz9IiXzM1bxjO3zLFIR7Ids0m/tE cJNhtUC65w+79PlYI4ANT/KaakTEVO7SxsfJDvGmPogFvfcLkDJEH8oOVcTlUqsBDd+tMWN1Ck/le P02R39wer0M4f6O4mNipEAkKhlpR23Vx4xURTrH6m4nPFS212aJaJmRm5am5saL67W5om2aix/v+m Bg8NnxmNpsjpDjb4rx1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nySsg-0055ds-Ni; Tue, 07 Jun 2022 06:39:58 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nySs5-0055KR-P4 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 06:39:23 +0000 Received: by mail-ej1-x636.google.com with SMTP id me5so32606928ejb.2 for ; Mon, 06 Jun 2022 23:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+6eJuTNYhenhOtSy0mpWdMyC3zMMcmWC680KdPh5O/c=; b=HYozM8kFiTcwqKrVxYDLCrX0493cz93zCKZJ+f8P4vW52obPXnTq6NV3kh1FoHfz/G X7fCON7a3YXvLmCYLMb+5TKI6U8CRoyGk1XVbE+v2dqJZU4GmCu7YVFqieiSRxDesBBv EnCAKtz9K9i+BZiMcySVBRAt5VYZiUFrgSciSMlfiDD+pJsVjpI5akEzEcegUZ5wFBvw JyxMduaLcnkgClGEdFK7A82CrDWTQvLxJKe4jDuWXaS1lO4J+IpQitElubvTUunFLq4/ X4UXNzx72E7wcm3vvgo+19Mc1hGGRqsjDGQxY7tiZXGAxaojashVw2hVrZ7AWz77Q663 FxXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+6eJuTNYhenhOtSy0mpWdMyC3zMMcmWC680KdPh5O/c=; b=4qg8Rg9fLlA6OA+u14pmI6HqFpp2rE9KwqLFBkkh3qq0DSBVfKpZOy0pY4M7b5w6oJ aWT3ed2NyT9BER+S2tNyBk3pEatBk9dzgEUBni9EKhakftaych9ILOEd+l35hIhJGEh4 LoQ0PDnQsyH9cVBOY3uYIt7J5qrUa7tYmr/oECNH9vVkECktuXGNxu8GqtXSlIZyP/FH 9JTxSoS+mXcdpgJjvYH9NZJyhg+JbfBtwe07B6NpRlM5l2HkgVD5va9zmuaejOvpWBbn PmaQYAzBa08l63citEst6LZL+KBfHEarSH0dLQrp/j+C4us0XFCL4pjRQ3RYqkt3wBmA 8mfw== X-Gm-Message-State: AOAM532W35uD14cqkA/EyJaJnmSui7j0kdgE5YtjrOSkXymGWdQSKP07 0EEijiJPb6bo7nG77DEUumStfKxS1I5n1A== X-Google-Smtp-Source: ABdhPJxJC6R9vm7E7RbQ7imv1QtZeFxdBWu2Z8oRZQhCapGo8C6J6E4SBIOg2hjT2XFEC6lAoeIJAw== X-Received: by 2002:a17:907:2d29:b0:70e:8b1c:c3f0 with SMTP id gs41-20020a1709072d2900b0070e8b1cc3f0mr18729905ejc.37.1654583958428; Mon, 06 Jun 2022 23:39:18 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id jo13-20020a170906f6cd00b006febc86b8besm7016888ejb.117.2022.06.06.23.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 23:39:18 -0700 (PDT) From: Krzysztof Kozlowski To: linux-arm-kernel@lists.infradead.org, Sylwester Nawrocki , Rob Herring , Tomasz Figa , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Linus Walleij , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Alim Akhtar Cc: Chanho Park Subject: Re: (subset) [PATCH v3 3/8] ARM: dts: s5pv210: use local header for pinctrl register values Date: Tue, 7 Jun 2022 08:39:11 +0200 Message-Id: <165458395109.7886.10195566966608207927.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220605160508.134075-4-krzysztof.kozlowski@linaro.org> References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> <20220605160508.134075-4-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_233921_835241_2C54C0D7 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 5 Jun 2022 18:05:03 +0200, Krzysztof Kozlowski wrote: > The DTS uses hardware register values directly in pin controller pin > configuration. These are not some IDs or other abstraction layer but > raw numbers used in the registers. > > These numbers were previously put in the bindings header to avoid code > duplication and to provide some context meaning (name), but they do not > fit the purpose of bindings. It is also quite confusing to use > constants prefixed with Exynos for other SoC, because there is actually > nothing here in common, except the actual value. > > [...] Applied, thanks! [3/8] ARM: dts: s5pv210: use local header for pinctrl register values https://git.kernel.org/krzk/linux/c/7fd554de160eed060e7819aa42ca0478c9e0f4cb Best regards, -- Krzysztof Kozlowski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel