From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32F89C433EF for ; Tue, 7 Jun 2022 06:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237131AbiFGGjW (ORCPT ); Tue, 7 Jun 2022 02:39:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237100AbiFGGjT (ORCPT ); Tue, 7 Jun 2022 02:39:19 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2A17B041D for ; Mon, 6 Jun 2022 23:39:17 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id m20so33081775ejj.10 for ; Mon, 06 Jun 2022 23:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=loges8s8zoV1C9PFiO71uU1qlpSiYfV9MSsL7MBBWRw=; b=LjQdF1tKP1kQSL+husirj9ps8XjdG4g5cybME/kjkMYjlDiT1Cr034Q4FkeoHhhCQd 2ZhUcIiSQvW1S+GqPeYk4whHbq3utWCf6jbt1PH6+T5TS8QQajLKNPNvpIMLgbmr0Vj8 BDsCEOyhF+kuWbcZ4U8yLsUd6iO1oA2Ai+id7lHLfZGmP238HeZEplNoGU6ZIEk374iV ba3Gqcp/j3YLV2cq/ZlwCO/i/R4AvaSapwf6ny+/cuNGb+HLE9Xq3P5qFMLkfoGifyQX t4b8OsGm3Q61enqMs0j3EIblK83BLEi1hwJDiLWmjfFeLOfUq182eejFL38sX+sATHv9 YOcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=loges8s8zoV1C9PFiO71uU1qlpSiYfV9MSsL7MBBWRw=; b=3Vv3ZDiMPNAxq1hRc0xox7QclSRA66K/SXlwG2XgCD4GpinPmYwdfnvvTZ89SG5h5i ihRSajVvt5BCj/oaKGDOHe2anR9Mz48yjuJB7xUh4B/hGOXDiG4bagNu6urAPnP8sS0k 170sCNHJV6qLubjuzovIe1/aGrhAtGz5LyODcgFuNYjLM+wxQG5DxuoSS9L1fzvyjn8/ gft2NCBcr69hLmoTSjicx2AC26t7HpqmQ8cp0hGVEZPagpyXTKkv1OSQEY3Nd9Nod9Uf 2tyJVBKbActxQGkp44LvPuRMX4ew1H+PRA/dcxgdQQQD/nS6YAmjcprz7ih/Tv7w7YlE 25VQ== X-Gm-Message-State: AOAM530KAJwa3hnPUSUxbW+07hy6K8cz+Otyh0SFgXnRGdslOYwkFwzQ xuT96QyGVJ1siSPGvPpMR5+cgA== X-Google-Smtp-Source: ABdhPJwd5sMXWXnHhxyv65OQ/SEnHwE8kGMI0uMl3SQbTKiwqhP+IINZDFnRlE8FgFVg7MdFxzEJmg== X-Received: by 2002:a17:906:c838:b0:711:d49f:687c with SMTP id dd24-20020a170906c83800b00711d49f687cmr6629267ejb.668.1654583956240; Mon, 06 Jun 2022 23:39:16 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id jo13-20020a170906f6cd00b006febc86b8besm7016888ejb.117.2022.06.06.23.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 23:39:15 -0700 (PDT) From: Krzysztof Kozlowski To: Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, Rob Herring , Tomasz Figa , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Linus Walleij , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Alim Akhtar Cc: Chanho Park Subject: Re: (subset) [PATCH v3 1/8] ARM: dts: s3c2410: use local header for pinctrl register values Date: Tue, 7 Jun 2022 08:39:09 +0200 Message-Id: <165458395109.7886.17085666406343091963.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220605160508.134075-2-krzysztof.kozlowski@linaro.org> References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> <20220605160508.134075-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sun, 5 Jun 2022 18:05:01 +0200, Krzysztof Kozlowski wrote: > The DTS uses hardware register values directly in pin controller pin > configuration. These are not some IDs or other abstraction layer but > raw numbers used in the registers. > > These numbers were previously put in the bindings header to avoid code > duplication and to provide some context meaning (name), but they do not > fit the purpose of bindings. It is also quite confusing to use > constants prefixed with Exynos for other SoC, because there is actually > nothing here in common, except the actual value. > > [...] Applied, thanks! [1/8] ARM: dts: s3c2410: use local header for pinctrl register values https://git.kernel.org/krzk/linux/c/5dba27958273ffc0056795a479550957a134e981 Best regards, -- Krzysztof Kozlowski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5823AC433EF for ; Tue, 7 Jun 2022 06:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lCzDZXtrfBYgyFlEJbp5JK9Mobl+V1T0+1Rgbxd2keU=; b=QoGyHhOsDp0Itg p7RE0xm5zVoAQ3eocyn9hF7tmX8p1grzWfpOpzDkG/+6Qvxt7YE97pgHLlRXg98VpZcSyIg4vI3l2 Fa3snn8/HzbxKjZoXkZtsHKklRb67JEegUuy8tFiPGlVHcbhDQEzqzijpNXS6xg0HwdEGcyG+R+P6 hsR8KWdr2vBhGt+Bi/P0rRZofERzXgHngs6TLYwMyt/xAlC42qg3u9crAkksrJfAID45DmzB7kObJ ptqFefS1O3vHL2wHVEMlSSk5jD7RJ58LiYOXJjSKE1r/VyKajGGVI6Qxk3159UIozQ5GSTafAcv98 oQB0pUQ/VnCVDH8GWSEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nySs9-0055Nm-4W; Tue, 07 Jun 2022 06:39:25 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nySs4-0055JV-Nl for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 06:39:22 +0000 Received: by mail-ej1-x62f.google.com with SMTP id fu3so31649406ejc.7 for ; Mon, 06 Jun 2022 23:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=loges8s8zoV1C9PFiO71uU1qlpSiYfV9MSsL7MBBWRw=; b=LjQdF1tKP1kQSL+husirj9ps8XjdG4g5cybME/kjkMYjlDiT1Cr034Q4FkeoHhhCQd 2ZhUcIiSQvW1S+GqPeYk4whHbq3utWCf6jbt1PH6+T5TS8QQajLKNPNvpIMLgbmr0Vj8 BDsCEOyhF+kuWbcZ4U8yLsUd6iO1oA2Ai+id7lHLfZGmP238HeZEplNoGU6ZIEk374iV ba3Gqcp/j3YLV2cq/ZlwCO/i/R4AvaSapwf6ny+/cuNGb+HLE9Xq3P5qFMLkfoGifyQX t4b8OsGm3Q61enqMs0j3EIblK83BLEi1hwJDiLWmjfFeLOfUq182eejFL38sX+sATHv9 YOcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=loges8s8zoV1C9PFiO71uU1qlpSiYfV9MSsL7MBBWRw=; b=Nf9K6WSzaa2cBIq9PgKzlnW4MAwAKlhyVqzWN6JdUFPVAndX3jGyx3UQY0z+iD9pv3 xgHguS8SrrSWXXETIaP008kTSfDYljT4QDF7ZJe2rIC55Q6BqyMVRWhHObteaQ4yxezx 8Qq55ZN/ltJMPznF2DfLNGCZXZL/HzpRqnRWpl8Ain7ZFB5YuG3BUcp83HwgQGiZREPB D87x94/1VyAMfHliAg0KrbRTtttSv08Xk1DvGFkjKQ5rrdwgVMx+y+nNj++/x0mZOeCo D6V1Sl0xoUNt8HySGtshXsadt3CFGUwpeDlUVT0PMcNwJ/Q5cqkbDdrhGTBn7PDasnA8 pEzA== X-Gm-Message-State: AOAM530hpPLQBmaFlhUX4vNuUhsKAvo7xPV72kI1L0sk1uj8tDfJZ0eF P/kA8mug5fDHZbbYeK1pXcWE2Q== X-Google-Smtp-Source: ABdhPJwd5sMXWXnHhxyv65OQ/SEnHwE8kGMI0uMl3SQbTKiwqhP+IINZDFnRlE8FgFVg7MdFxzEJmg== X-Received: by 2002:a17:906:c838:b0:711:d49f:687c with SMTP id dd24-20020a170906c83800b00711d49f687cmr6629267ejb.668.1654583956240; Mon, 06 Jun 2022 23:39:16 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id jo13-20020a170906f6cd00b006febc86b8besm7016888ejb.117.2022.06.06.23.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 23:39:15 -0700 (PDT) From: Krzysztof Kozlowski To: Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, Rob Herring , Tomasz Figa , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Linus Walleij , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Alim Akhtar Cc: Chanho Park Subject: Re: (subset) [PATCH v3 1/8] ARM: dts: s3c2410: use local header for pinctrl register values Date: Tue, 7 Jun 2022 08:39:09 +0200 Message-Id: <165458395109.7886.17085666406343091963.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220605160508.134075-2-krzysztof.kozlowski@linaro.org> References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> <20220605160508.134075-2-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_233920_825543_24D955DF X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 5 Jun 2022 18:05:01 +0200, Krzysztof Kozlowski wrote: > The DTS uses hardware register values directly in pin controller pin > configuration. These are not some IDs or other abstraction layer but > raw numbers used in the registers. > > These numbers were previously put in the bindings header to avoid code > duplication and to provide some context meaning (name), but they do not > fit the purpose of bindings. It is also quite confusing to use > constants prefixed with Exynos for other SoC, because there is actually > nothing here in common, except the actual value. > > [...] Applied, thanks! [1/8] ARM: dts: s3c2410: use local header for pinctrl register values https://git.kernel.org/krzk/linux/c/5dba27958273ffc0056795a479550957a134e981 Best regards, -- Krzysztof Kozlowski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel