From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A38ECCA483 for ; Tue, 7 Jun 2022 06:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237138AbiFGGjX (ORCPT ); Tue, 7 Jun 2022 02:39:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237114AbiFGGjU (ORCPT ); Tue, 7 Jun 2022 02:39:20 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBD1BB0A42 for ; Mon, 6 Jun 2022 23:39:18 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id gl15so19272631ejb.4 for ; Mon, 06 Jun 2022 23:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=30/swRoGI7lxOeK/JCZOMenofIQ2Qnwy381c+smb4TA=; b=hRvd0fRQ06nsWwDyDjPYxTGsvqvXXrNQMbjT1Em4UrrOfqMzAG5qNorVycW89lVPlM /4d395QujBeRwU1UilsC99/3sC3wup/EJDNh4LKuI0DvkhJoZ9tAvIa6Uve607PoFRme 2i09ToSIIxI+Tdx4TAk40sq2HIPtM52oEOsZwHI3qQtcUe0eBRno4BS+DdEYJGOExBx7 LqplQKH0pLizRr1ziLYe5MBWbS4swqfviGOjwvMfj5PCWdxXRHy9XXu09/LjaUcphHwV 9LaZSxuXkKdBAW5a3zSBLlkw/IJjmQEsdUMQxuH6RqPvrDbcc46SxLtUnE6GIRLLH0gq 6eoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=30/swRoGI7lxOeK/JCZOMenofIQ2Qnwy381c+smb4TA=; b=bJFLr5iij1GkHkfrq8KQhwfVs9/PXDImnqbtRc9KGjlsvKZMQD8k1uztZ5Cv47Dl4b J2+mh8AGAcy1vVQRzXTzKT1m2pR/6ZhmdOair1AgQaRLOTbeJ/m0/sN7FB9Ra5aTQ9jJ kKeLcLRIsu3rVSB+6DRdcJdDM+DrTFZBGTEzwHIqvECurnNpHMXInAozr2k4JVxkna1e rX4Gitx2kZv4Ew41SrnP97AfAIXCSBEkWx0u9DuylO5YxVEBYdic7iA0lDrABBRfRhqi byq5NWlevuNPzHMI6uM67PgEXd83glvVrXD+4fXQNjTagg2MPZhchslGzNgA++4o9WoW t5fw== X-Gm-Message-State: AOAM531egw9RdqEBOeIpMZNFfLUgjQq1SFNcOmlfYkgMmGrILFYQv7Y9 b+8Cc9K9X/P1DNEA3Ac3XuibqA== X-Google-Smtp-Source: ABdhPJxPb4B1+kYdlB7X2PcS4f0mWtob9442OqwnUgNprAost6mEYGoTJP2LBYDLNSUfIEVPMRgI3Q== X-Received: by 2002:a17:906:b816:b0:708:2e56:97d7 with SMTP id dv22-20020a170906b81600b007082e5697d7mr24712545ejb.502.1654583957338; Mon, 06 Jun 2022 23:39:17 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id jo13-20020a170906f6cd00b006febc86b8besm7016888ejb.117.2022.06.06.23.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 23:39:16 -0700 (PDT) From: Krzysztof Kozlowski To: Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, Rob Herring , Tomasz Figa , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Linus Walleij , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Alim Akhtar Cc: Chanho Park Subject: Re: (subset) [PATCH v3 2/8] ARM: dts: s3c64xx: use local header for pinctrl register values Date: Tue, 7 Jun 2022 08:39:10 +0200 Message-Id: <165458395109.7886.7299681625638246723.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220605160508.134075-3-krzysztof.kozlowski@linaro.org> References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> <20220605160508.134075-3-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sun, 5 Jun 2022 18:05:02 +0200, Krzysztof Kozlowski wrote: > The DTS uses hardware register values directly in pin controller pin > configuration. These are not some IDs or other abstraction layer but > raw numbers used in the registers. > > These numbers were previously put in the bindings header to avoid code > duplication and to provide some context meaning (name), but they do not > fit the purpose of bindings. It is also quite confusing to use > constants prefixed with Exynos for other SoC, because there is actually > nothing here in common, except the actual value. > > [...] Applied, thanks! [2/8] ARM: dts: s3c64xx: use local header for pinctrl register values https://git.kernel.org/krzk/linux/c/468fff18c3776ced9bb466ae4fb2e30fdf671bef Best regards, -- Krzysztof Kozlowski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3588C433EF for ; Tue, 7 Jun 2022 06:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EKpxmBY8yI6Aeh4QTxu3NVQ+Bj3c5cBd/Mx2dhcCTOM=; b=gGmnyWMB5Q/4D9 nFntdQ/i+4uMU5QpoQRfkO/IeltTF5PJEeM2dH1+IQ/+JiXjEPknu9Tp84Xrz5iK2XqIN5PI+RZUo sYsk5/vZ/XMg/hySSLr0KSC4oLjJ15dyna3DO9B7mWBcOLBpF84TKqghZoRWUBsKetdk773wPn3gZ +4sXSgec6dMLtNxtJ4ehmnIsmjEvilhmEGb8PlxGZG9nxRZmlU4I6M2pnrlTJ5RO+Q1YREaB7395K FNhNaMisF7luBICFosCXNSFgmoegCf8M7GSdhmPMEvI2UeWbCwwNjp2iATOXdI99IKjq5+njOFpy6 XtA4+mEVR0RqMpjXHSXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nySsR-0055WD-8s; Tue, 07 Jun 2022 06:39:43 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nySs5-0055Jr-P1 for linux-arm-kernel@lists.infradead.org; Tue, 07 Jun 2022 06:39:23 +0000 Received: by mail-ej1-x636.google.com with SMTP id s12so25928133ejx.3 for ; Mon, 06 Jun 2022 23:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=30/swRoGI7lxOeK/JCZOMenofIQ2Qnwy381c+smb4TA=; b=hRvd0fRQ06nsWwDyDjPYxTGsvqvXXrNQMbjT1Em4UrrOfqMzAG5qNorVycW89lVPlM /4d395QujBeRwU1UilsC99/3sC3wup/EJDNh4LKuI0DvkhJoZ9tAvIa6Uve607PoFRme 2i09ToSIIxI+Tdx4TAk40sq2HIPtM52oEOsZwHI3qQtcUe0eBRno4BS+DdEYJGOExBx7 LqplQKH0pLizRr1ziLYe5MBWbS4swqfviGOjwvMfj5PCWdxXRHy9XXu09/LjaUcphHwV 9LaZSxuXkKdBAW5a3zSBLlkw/IJjmQEsdUMQxuH6RqPvrDbcc46SxLtUnE6GIRLLH0gq 6eoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=30/swRoGI7lxOeK/JCZOMenofIQ2Qnwy381c+smb4TA=; b=Q24BCB6qYZM3UuY+JC1GRcLe/wm+M6phBeznRb3fsPBSbGOQuE2laiXvVUBcVWRAJn RTS8L33ffdtrk/1zcypVz43YzaFp74WbQQKgI/PDa/B+bQ/BxXyaZ4n8l4b52hJQkeYr Us106CouBmn0j4tGKmRuPjvga8t6CgeXefebJH6Hgu3cqta+9HL8y86jLUIF+R8VU06g XQ9qvwVMfQ/sIBp86pq5x35kc469cGY+OetmMU/qICgG7mXgKqWJsL1mQ3QFd4Q7WSlm 2ME66Lvu51cyCDE5zIgpVTYU5UfD6HAgPHm7d4zuIhr0cwz1nwEmhx1fPqrOIepj04zC LWBA== X-Gm-Message-State: AOAM53017yyWN5HsostpFbefb/bfVFwsnEFB1z+OiEToR8QLMbo9AGwb lm+CofcT3jCNmXzQ3TuJF5uwbg== X-Google-Smtp-Source: ABdhPJxPb4B1+kYdlB7X2PcS4f0mWtob9442OqwnUgNprAost6mEYGoTJP2LBYDLNSUfIEVPMRgI3Q== X-Received: by 2002:a17:906:b816:b0:708:2e56:97d7 with SMTP id dv22-20020a170906b81600b007082e5697d7mr24712545ejb.502.1654583957338; Mon, 06 Jun 2022 23:39:17 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id jo13-20020a170906f6cd00b006febc86b8besm7016888ejb.117.2022.06.06.23.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 23:39:16 -0700 (PDT) From: Krzysztof Kozlowski To: Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, Rob Herring , Tomasz Figa , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Krzysztof Kozlowski , Linus Walleij , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Alim Akhtar Cc: Chanho Park Subject: Re: (subset) [PATCH v3 2/8] ARM: dts: s3c64xx: use local header for pinctrl register values Date: Tue, 7 Jun 2022 08:39:10 +0200 Message-Id: <165458395109.7886.7299681625638246723.b4-ty@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220605160508.134075-3-krzysztof.kozlowski@linaro.org> References: <20220605160508.134075-1-krzysztof.kozlowski@linaro.org> <20220605160508.134075-3-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_233921_833560_C0FFED64 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 5 Jun 2022 18:05:02 +0200, Krzysztof Kozlowski wrote: > The DTS uses hardware register values directly in pin controller pin > configuration. These are not some IDs or other abstraction layer but > raw numbers used in the registers. > > These numbers were previously put in the bindings header to avoid code > duplication and to provide some context meaning (name), but they do not > fit the purpose of bindings. It is also quite confusing to use > constants prefixed with Exynos for other SoC, because there is actually > nothing here in common, except the actual value. > > [...] Applied, thanks! [2/8] ARM: dts: s3c64xx: use local header for pinctrl register values https://git.kernel.org/krzk/linux/c/468fff18c3776ced9bb466ae4fb2e30fdf671bef Best regards, -- Krzysztof Kozlowski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel