All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: bvanassche@acm.org
Cc: Christoph Hellwig <hch@lst.de>,
	ming.lei@redhat.com, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: Fix handling of offline queues in blk_mq_alloc_request_hctx()
Date: Thu, 16 Jun 2022 14:46:25 -0600	[thread overview]
Message-ID: <165541238531.250853.2935714049059909581.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220615210004.1031820-1-bvanassche@acm.org>

On Wed, 15 Jun 2022 14:00:04 -0700, Bart Van Assche wrote:
> This patch prevents that test nvme/004 triggers the following:
> 
> UBSAN: array-index-out-of-bounds in block/blk-mq.h:135:9
> index 512 is out of range for type 'long unsigned int [512]'
> Call Trace:
>  show_stack+0x52/0x58
>  dump_stack_lvl+0x49/0x5e
>  dump_stack+0x10/0x12
>  ubsan_epilogue+0x9/0x3b
>  __ubsan_handle_out_of_bounds.cold+0x44/0x49
>  blk_mq_alloc_request_hctx+0x304/0x310
>  __nvme_submit_sync_cmd+0x70/0x200 [nvme_core]
>  nvmf_connect_io_queue+0x23e/0x2a0 [nvme_fabrics]
>  nvme_loop_connect_io_queues+0x8d/0xb0 [nvme_loop]
>  nvme_loop_create_ctrl+0x58e/0x7d0 [nvme_loop]
>  nvmf_create_ctrl+0x1d7/0x4d0 [nvme_fabrics]
>  nvmf_dev_write+0xae/0x111 [nvme_fabrics]
>  vfs_write+0x144/0x560
>  ksys_write+0xb7/0x140
>  __x64_sys_write+0x42/0x50
>  do_syscall_64+0x35/0x80
>  entry_SYSCALL_64_after_hwframe+0x44/0xae
> 
> [...]

Applied, thanks!

[1/1] block: Fix handling of offline queues in blk_mq_alloc_request_hctx()
      commit: 14dc7a18abbe4176f5626c13c333670da8e06aa1

Best regards,
-- 
Jens Axboe



      parent reply	other threads:[~2022-06-16 20:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 21:00 [PATCH] block: Fix handling of offline queues in blk_mq_alloc_request_hctx() Bart Van Assche
2022-06-16  1:39 ` Ming Lei
2022-06-16  6:18 ` Christoph Hellwig
2022-06-16  8:03 ` John Garry
2022-06-16  8:23   ` Ming Lei
2022-06-16 20:46 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165541238531.250853.2935714049059909581.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.