All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Hans de Goede" <hdegoede@redhat.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/kms: Stop registering multiple /sys/class/backlight devs for a single display
Date: Wed, 24 Aug 2022 22:39:06 -0000	[thread overview]
Message-ID: <166138074644.9871.190472164685870349@emeril.freedesktop.org> (raw)
In-Reply-To: <20220824121523.1291269-1-hdegoede@redhat.com>

== Series Details ==

Series: drm/kms: Stop registering multiple /sys/class/backlight devs for a single display
URL   : https://patchwork.freedesktop.org/series/107674/
State : warning

== Summary ==

Error: dim checkpatch failed
ce615e6eacec ACPI: video: Add acpi_video_backlight_use_native() helper
-:112: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#112: FILE: include/acpi/video.h:59:
+extern bool acpi_video_backlight_use_native(void);

-:120: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#120: FILE: include/acpi/video.h:81:
 }
+static inline bool acpi_video_backlight_use_native(void)

total: 0 errors, 0 warnings, 2 checks, 73 lines checked
ffed9d27f636 drm/i915: Don't register backlight when another backlight should be used
3aa84d18ba99 drm/amdgpu: Don't register backlight when another backlight should be used (v3)
2278ca8ec027 drm/radeon: Don't register backlight when another backlight should be used (v3)
e25ad3cdb207 drm/nouveau: Don't register backlight when another backlight should be used (v2)
8d7ad66ebdbb ACPI: video: Drop backlight_device_get_by_type() call from acpi_video_get_backlight_type()
c2bbe7ee63a5 ACPI: video: Remove acpi_video_bus from list before tearing it down
775eaeb06986 ACPI: video: Simplify acpi_video_unregister_backlight()
e89c85db9273 ACPI: video: Make backlight class device registration a separate step (v2)
-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#52: FILE: drivers/acpi/acpi_video.c:83:
+MODULE_PARM_DESC(register_backlight_delay,
+	"Delay in seconds before doing fallback (non GPU driver triggered) "

-:155: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#155: FILE: include/acpi/video.h:56:
+extern void acpi_video_register_backlight(void);

total: 0 errors, 0 warnings, 2 checks, 112 lines checked
c960810e498a ACPI: video: Remove code to unregister acpi_video backlight when a native backlight registers
e2884327df97 drm/i915: Call acpi_video_register_backlight() (v2)
a81b436830ad drm/nouveau: Register ACPI video backlight when nv_backlight registration fails (v2)
2d7a10857c1f drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration
f2029e5472ab drm/radeon: Register ACPI video backlight when skipping radeon backlight registration
a9f7e6508f32 platform/x86: nvidia-wmi-ec-backlight: Move fw interface definitions to a header (v2)
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:119: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#119: 
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 166 lines checked
aad1fbd9183c ACPI: video: Refactor acpi_video_get_backlight_type() a bit
8706b5420145 ACPI: video: Add Nvidia WMI EC brightness control detection (v3)
3bf23698fd25 ACPI: video: Add Apple GMUX brightness control detection
4f6d0cee0c7d platform/x86: nvidia-wmi-ec-backlight: Use acpi_video_get_backlight_type()
5658b0c7c1ad platform/x86: apple-gmux: Stop calling acpi/video.h functions
cb40d8a60c01 platform/x86: toshiba_acpi: Stop using acpi_video_set_dmi_backlight_type()
c6991a72234d platform/x86: acer-wmi: Move backlight DMI quirks to acpi/video_detect.c
2b7d1508eead platform/x86: asus-wmi: Drop DMI chassis-type check from backlight handling
2dbea215edc9 platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI video_detect.c
b416bb9cec80 platform/x86: asus-wmi: Move acpi_backlight=native quirks to ACPI video_detect.c
a3cbb9b255dd platform/x86: samsung-laptop: Move acpi_backlight=[vendor|native] quirks to ACPI video_detect.c
ecddbc9604aa ACPI: video: Remove acpi_video_set_dmi_backlight_type()
0b352f79ed22 ACPI: video: Drop "Samsung X360" acpi_backlight=native quirk
a0618094884b ACPI: video: Drop NL5x?U, PF4NU1F and PF5?U?? acpi_backlight=native quirks
8f6f62285273 ACPI: video: Fix indentation of video_detect_dmi_table[] entries
c38929892adb drm/todo: Add entry about dealing with brightness control on devices with > 1 panel
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
https://lore.kernel.org/dri-devel/20220517152331.16217-1-hdegoede@redhat.com/

total: 0 errors, 1 warnings, 0 checks, 74 lines checked



  parent reply	other threads:[~2022-08-24 22:39 UTC|newest]

Thread overview: 210+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 12:14 [PATCH v4 00/31] drm/kms: Stop registering multiple /sys/class/backlight devs for a single display Hans de Goede
2022-08-24 12:14 ` Hans de Goede
2022-08-24 12:14 ` [Intel-gfx] " Hans de Goede
2022-08-24 12:14 ` Hans de Goede
2022-08-24 12:14 ` [Nouveau] " Hans de Goede
2022-08-24 12:14 ` [PATCH v4 01/31] ACPI: video: Add acpi_video_backlight_use_native() helper Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Nouveau] " Hans de Goede
2022-08-24 12:14 ` [PATCH v4 02/31] drm/i915: Don't register backlight when another backlight should be used Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Nouveau] " Hans de Goede
2022-08-24 12:50   ` Jani Nikula
2022-08-24 12:50     ` Jani Nikula
2022-08-24 12:50     ` Jani Nikula
2022-08-24 12:50     ` [Intel-gfx] " Jani Nikula
2022-08-24 12:50     ` [Nouveau] " Jani Nikula
2022-08-25  8:54     ` Hans de Goede
2022-08-25  8:54       ` Hans de Goede
2022-08-25  8:54       ` [Intel-gfx] " Hans de Goede
2022-08-25  8:54       ` Hans de Goede
2022-08-25  8:54       ` [Nouveau] " Hans de Goede
2022-08-24 12:14 ` [PATCH v4 03/31] drm/amdgpu: Don't register backlight when another backlight should be used (v3) Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Nouveau] " Hans de Goede
2022-08-24 12:14 ` [PATCH v4 04/31] drm/radeon: " Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:14   ` [Nouveau] " Hans de Goede
2022-08-24 12:14 ` [PATCH v4 05/31] drm/nouveau: Don't register backlight when another backlight should be used (v2) Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:14   ` [Nouveau] " Hans de Goede
2022-08-24 17:41   ` Lyude Paul
2022-08-24 17:41     ` Lyude Paul
2022-08-24 17:41     ` [Intel-gfx] " Lyude Paul
2022-08-24 17:41     ` Lyude Paul
2022-08-24 17:41     ` [Nouveau] " Lyude Paul
2022-08-25  8:49     ` Hans de Goede
2022-08-25  8:49       ` Hans de Goede
2022-08-25  8:49       ` [Intel-gfx] " Hans de Goede
2022-08-25  8:49       ` Hans de Goede
2022-08-25  8:49       ` [Nouveau] " Hans de Goede
2022-08-24 12:14 ` [PATCH v4 06/31] ACPI: video: Drop backlight_device_get_by_type() call from acpi_video_get_backlight_type() Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:14   ` [Nouveau] " Hans de Goede
2022-08-24 12:14 ` [PATCH v4 07/31] ACPI: video: Remove acpi_video_bus from list before tearing it down Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` Hans de Goede
2022-08-24 12:14   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:14   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 08/31] ACPI: video: Simplify acpi_video_unregister_backlight() Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 09/31] ACPI: video: Make backlight class device registration a separate step (v2) Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 10/31] ACPI: video: Remove code to unregister acpi_video backlight when a native backlight registers Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 11/31] drm/i915: Call acpi_video_register_backlight() (v2) Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:47   ` Jani Nikula
2022-08-24 12:47     ` Jani Nikula
2022-08-24 12:47     ` Jani Nikula
2022-08-24 12:47     ` [Intel-gfx] " Jani Nikula
2022-08-24 12:47     ` [Nouveau] " Jani Nikula
2022-08-24 12:49     ` Hans de Goede
2022-08-24 12:49       ` Hans de Goede
2022-08-24 12:49       ` [Intel-gfx] " Hans de Goede
2022-08-24 12:49       ` Hans de Goede
2022-08-24 12:49       ` [Nouveau] " Hans de Goede
2022-08-24 13:26       ` Jani Nikula
2022-08-24 13:26         ` Jani Nikula
2022-08-24 13:26         ` [Intel-gfx] " Jani Nikula
2022-08-24 13:26         ` Jani Nikula
2022-08-24 13:26         ` [Nouveau] " Jani Nikula
2022-08-24 12:15 ` [PATCH v4 12/31] drm/nouveau: Register ACPI video backlight when nv_backlight registration fails (v2) Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 18:11   ` Lyude Paul
2022-08-24 18:11     ` Lyude Paul
2022-08-24 18:11     ` [Intel-gfx] " Lyude Paul
2022-08-24 18:11     ` Lyude Paul
2022-08-24 18:11     ` [Nouveau] " Lyude Paul
2022-08-24 12:15 ` [PATCH v4 13/31] drm/amdgpu: Register ACPI video backlight when skipping amdgpu backlight registration Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 14/31] drm/radeon: Register ACPI video backlight when skipping radeon " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 15/31] platform/x86: nvidia-wmi-ec-backlight: Move fw interface definitions to a header (v2) Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 16/31] ACPI: video: Refactor acpi_video_get_backlight_type() a bit Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 17/31] ACPI: video: Add Nvidia WMI EC brightness control detection (v3) Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15 ` [PATCH v4 18/31] ACPI: video: Add Apple GMUX brightness control detection Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15 ` [PATCH v4 19/31] platform/x86: nvidia-wmi-ec-backlight: Use acpi_video_get_backlight_type() Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 20/31] platform/x86: apple-gmux: Stop calling acpi/video.h functions Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 21/31] platform/x86: toshiba_acpi: Stop using acpi_video_set_dmi_backlight_type() Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 22/31] platform/x86: acer-wmi: Move backlight DMI quirks to acpi/video_detect.c Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 23/31] platform/x86: asus-wmi: Drop DMI chassis-type check from backlight handling Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 24/31] platform/x86: asus-wmi: Move acpi_backlight=vendor quirks to ACPI video_detect.c Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 25/31] platform/x86: asus-wmi: Move acpi_backlight=native " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15 ` [PATCH v4 26/31] platform/x86: samsung-laptop: Move acpi_backlight=[vendor|native] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15 ` [PATCH v4 27/31] ACPI: video: Remove acpi_video_set_dmi_backlight_type() Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 28/31] ACPI: video: Drop "Samsung X360" acpi_backlight=native quirk Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 29/31] ACPI: video: Drop NL5x?U, PF4NU1F and PF5?U?? acpi_backlight=native quirks Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 30/31] ACPI: video: Fix indentation of video_detect_dmi_table[] entries Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 12:15 ` [PATCH v4 31/31] drm/todo: Add entry about dealing with brightness control on devices with > 1 panel Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Intel-gfx] " Hans de Goede
2022-08-24 12:15   ` Hans de Goede
2022-08-24 12:15   ` [Nouveau] " Hans de Goede
2022-08-24 18:12   ` Lyude Paul
2022-08-24 18:12     ` Lyude Paul
2022-08-24 18:12     ` [Intel-gfx] " Lyude Paul
2022-08-24 18:12     ` Lyude Paul
2022-08-24 18:12     ` [Nouveau] " Lyude Paul
2022-08-24 22:39 ` Patchwork [this message]
2022-08-24 23:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/kms: Stop registering multiple /sys/class/backlight devs for a single display Patchwork
2022-08-26 18:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-08-25 14:36 [Nouveau] [PATCH v5 00/31] " Hans de Goede
2022-08-25 16:09 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-08-18 18:42 [PATCH v3 00/31] " Hans de Goede
2022-08-24 19:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166138074644.9871.190472164685870349@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.