From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org, "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [PATCH v5 1/4] x86: return modified setup_data only if read as memory, not as file
Date: Thu, 22 Sep 2022 09:26:28 +0200 [thread overview]
Message-ID: <166383158063.107920.1563965268305325639.b4-ty@redhat.com> (raw)
In-Reply-To: <20220921093134.2936487-1-Jason@zx2c4.com>
On Wed, 21 Sep 2022 11:31:31 +0200, Jason A. Donenfeld wrote:
> If setup_data is being read into a specific memory location, then
> generally the setup_data address parameter is read first, so that the
> caller knows where to read it into. In that case, we should return
> setup_data containing the absolute addresses that are hard coded and
> determined a priori. This is the case when kernels are loaded by BIOS,
> for example. In contrast, when setup_data is read as a file, then we
> shouldn't modify setup_data, since the absolute address will be wrong by
> definition. This is the case when OVMF loads the image.
>
> [...]
Applied, thanks!
[1/4] x86: return modified setup_data only if read as memory, not as file
commit: 7e660efb4d2af17582588bcdc4af7d28040feda6
[2/4] x86: use typedef for SetupData struct
commit: 1127a29a33f975943d89fc36ab934ad37810e4b7
[3/4] x86: reinitialize RNG seed on system reboot
commit: e997fc36def502dc3e9da915816083f086dff8f2
[4/4] x86: re-enable rng seeding via SetupData
commit: a731bae726f2b3168dea9d5137cb7e47444448eb
Best regards,
--
Paolo Bonzini <pbonzini@redhat.com>
prev parent reply other threads:[~2022-09-22 7:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 9:31 [PATCH v5 1/4] x86: return modified setup_data only if read as memory, not as file Jason A. Donenfeld
2022-09-21 9:31 ` [PATCH v5 2/4] x86: use typedef for SetupData struct Jason A. Donenfeld
2022-09-21 9:31 ` [PATCH v5 3/4] x86: reinitialize RNG seed on system reboot Jason A. Donenfeld
2022-09-21 9:31 ` [PATCH v5 4/4] x86: re-enable rng seeding via SetupData Jason A. Donenfeld
2022-12-24 0:14 ` Eric Biggers
2022-12-24 3:09 ` Jason A. Donenfeld
2022-12-24 4:21 ` Jason A. Donenfeld
2022-12-26 14:24 ` Jason A. Donenfeld
2022-12-26 14:43 ` Jason A. Donenfeld
2022-12-26 16:57 ` Jason A. Donenfeld
2022-12-27 13:36 ` Jason A. Donenfeld
2022-12-28 3:07 ` Jason A. Donenfeld
2022-12-28 14:39 ` Jason A. Donenfeld
2022-09-22 7:26 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166383158063.107920.1563965268305325639.b4-ty@redhat.com \
--to=pbonzini@redhat.com \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.