From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C9DC433DB for ; Mon, 15 Feb 2021 14:42:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4A4661606 for ; Mon, 15 Feb 2021 14:42:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4A4661606 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBf5J-0007U7-Sg for qemu-devel@archiver.kernel.org; Mon, 15 Feb 2021 09:42:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBf2R-0005u6-WC for qemu-devel@nongnu.org; Mon, 15 Feb 2021 09:39:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:43766) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBf2Q-0007ZT-F6 for qemu-devel@nongnu.org; Mon, 15 Feb 2021 09:39:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C8891AC32; Mon, 15 Feb 2021 14:39:44 +0000 (UTC) Subject: Re: [RFC v18 08/15] i386: split smm helper (softmmu) To: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210212123622.15834-1-cfontana@suse.de> <20210212123622.15834-9-cfontana@suse.de> <87y2fptss2.fsf@linaro.org> <2a001d15-9b17-d356-aa2b-578f58fe63c4@suse.de> <0cc5d1ab-088f-1b49-23cd-ecb3703329f0@redhat.com> <5ad012e6-4b28-fdbc-c17c-9ec2dedb377f@suse.de> From: Claudio Fontana Message-ID: <166b46f8-3346-1acb-f5d0-e59a0d120b84@suse.de> Date: Mon, 15 Feb 2021 15:39:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Eduardo Habkost , Richard Henderson , qemu-devel@nongnu.org, Roman Bolshakov , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/15/21 3:13 PM, Paolo Bonzini wrote: > On 15/02/21 15:05, Claudio Fontana wrote: >> On 2/15/21 2:30 PM, Paolo Bonzini wrote: >>> On 15/02/21 13:59, Claudio Fontana wrote: >>>> Yes. The difference between before the patch and after the patch >>>> is that before we were still going through all the code in >>>> tcg_gen_callN, via the call to gen_helper_rsm macro, only to call >>>> finally an empty function for CONFIG_USER_ONLY (helper_rsm() >>>> {}), >>>> >>>> while now we do not generate anything, we do not call the >>>> gen_helper_rsm macro at all, so we don't go through >>>> tcg_gen_callN. >>>> >>> >>> Can we even have an abort() for such cases? >>> >>> Paolo >>> >> >> Hi Paolo, >> >> where are you suggesting to have an abort()? >> >> You mean that we should abort() QEMU as soon as we detect in >> translate.c an RSM instruction in user-mode? > > Translating it is okay (it's just a guaranteed SIGILL), but I'm thinking > of aborting if s->flags & HF_SMM_MASK is true. Likewise if we see > CPU_INTERRUPT_SMI. > > Paolo > Ok, will rework as you suggest, thanks! >> >> case 0x1aa: /* rsm */ >> gen_svm_check_intercept(s, pc_start, SVM_EXIT_RSM); >> if (!(s->flags & HF_SMM_MASK)) >> goto illegal_op; >> gen_update_cc_op(s); >> gen_jmp_im(s, s->pc - s->cs_base); >> #ifndef CONFIG_USER_ONLY >> gen_helper_rsm(cpu_env); >> #endif /* CONFIG_USER_ONLY */ >> gen_eob(s); >> break; > >