From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Yintian Tao <yttao-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu: no need fbcon under sriov
Date: Tue, 4 Jun 2019 15:57:37 +0200 [thread overview]
Message-ID: <1686be7b-ca1c-e43c-3906-e6131e8d25e1@gmail.com> (raw)
In-Reply-To: <1559655785-30379-1-git-send-email-yttao-5C7GfCeVMHo@public.gmane.org>
Am 04.06.19 um 15:43 schrieb Yintian Tao:
> Under Sriov, there is no need of the support for fbcon.
NAK, that error message is not related to fbcon but means that PCIe
device removal is not supported.
Christian.
>
> Signed-off-by: Yintian Tao <yttao@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 1f38d6f..28d095b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev)
> {
> struct drm_device *dev = pci_get_drvdata(pdev);
>
> - DRM_ERROR("Device removal is currently not supported outside of fbcon\n");
> + if (!amdgpu_sriov_vf(adev))
> + DRM_ERROR("Device removal is currently not supported outside of fbcon\n");
> drm_dev_unplug(dev);
> drm_dev_put(dev);
> pci_disable_device(pdev);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-06-04 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 13:43 [PATCH] drm/amdgpu: no need fbcon under sriov Yintian Tao
[not found] ` <1559655785-30379-1-git-send-email-yttao-5C7GfCeVMHo@public.gmane.org>
2019-06-04 13:57 ` Christian König [this message]
[not found] ` <1686be7b-ca1c-e43c-3906-e6131e8d25e1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-06-04 15:16 ` 答复: " Tao, Yintian
[not found] ` <MN2PR12MB3039F0DD22910F40A6674546E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-06-04 15:22 ` Koenig, Christian
[not found] ` <a0c24c05-6bca-ee5c-75bf-672f27abdb33-5C7GfCeVMHo@public.gmane.org>
2019-06-04 15:29 ` 答复: " Tao, Yintian
[not found] ` <MN2PR12MB3039F3AF3CA365AA420DBC79E5150-rweVpJHSKTr/fpeVZQY9RQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-06-05 18:23 ` Koenig, Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1686be7b-ca1c-e43c-3906-e6131e8d25e1@gmail.com \
--to=ckoenig.leichtzumerken-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
--cc=yttao-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.