Re: [PATCH] MSVC: Windows-native implementation for subset of Pthreads API

From: "Andrzej K. Haczewski" <ahaczewski@gmail.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: git@vger.kernel.org, kusmabite@gmail.com,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Johannes Sixt <j.sixt@viscovery.net>,
	Paolo Bonzini <bonzini@gnu.org>
Subject: Re: [PATCH] MSVC: Windows-native implementation for subset of  Pthreads API
Date: Thu, 5 Nov 2009 21:09:47 +0100	[thread overview]
Message-ID: <16cee31f0911051209jcc490e2pabeab9a1b6e3b11d@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0911051434090.10340@xanadu.home>

2009/11/5 Nicolas Pitre <nico@fluxnic.net>:
> On Thu, 5 Nov 2009, Andrzej K. Haczewski wrote:
>
>> +static unsigned __stdcall win32_start_routine(void *arg)
>> +{
>> +     pthread_t *thread = arg;
>> +     thread->value = thread->start_routine(thread->arg);
>> +     return 0;
>> +}
>
> I suppose you could reuse thread->arg for both the argument and the
> returned value to save a word.

You're right! J6t committed already, what can I do now?

> Why are you casting thread->handle here?  Why not simply declaring it as
> a HANDLE?

Just to silence MSVC warnings. WaitForSingleObject requires HANDLE,
_beginthreadex() returns uintptr_t. It's just a matter of where would
I put cast ;).

--
Andrzej