From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup Date: Mon, 03 Sep 2018 13:31:34 +0200 Message-ID: <1705932.lAR3QV8q47@amdc3058> References: <20180903074315.GB21634@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <20180903074315.GB21634-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Daniel Vetter Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Airlie , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Alex Deucher , Thierry Reding , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dave Airlie , Maxime Ripard , Jonathan Hunter , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Gerd Hoffmann List-Id: linux-tegra@vger.kernel.org T24gTW9uZGF5LCBTZXB0ZW1iZXIgMDMsIDIwMTggMDk6NDM6MTUgQU0gRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBTYXQsIFNlcCAwMSwgMjAxOCBhdCAwNDowODo0MVBNICswMjAwLCBNaWNoYcWC IE1pcm9zxYJhdyB3cm90ZToKPiA+IFRoaXMgc2VyaWVzIGNsZWFucyB1cCBkdXBsaWNhdGVkIGNv ZGUgZm9yIHJlcGxhY2luZyBmaXJtd2FyZSBGQgo+ID4gZHJpdmVyIHdpdGggcHJvcGVyIERSSSBk cml2ZXIgYW5kIGFkZHMgaGFuZG92ZXIgc3VwcG9ydCB0bwo+ID4gVGVncmEgZHJpdmVyLgo+ID4g Cj4gPiBUaGlzIGlzIGEgc2xpZ3RseSB1cGRhdGVkIHZlcnNpb24gb2YgYSBzZXJpZXMgc2VudCBv biAyNCBOb3YgMjAxNy4KPiA+IAo+ID4gLS0tCj4gPiB2MjoKPiA+ICAtIHJlYmFzZWQgb24gY3Vy cmVudCBkcm0tbmV4dAo+ID4gIC0gZHJvcHBlZCBzdGFnaW5nL3NtNzUwZmIgY2hhbmdlcwo+ID4g IC0gYWRkZWQga2VybmVsIGRvY3MgZm9yIERSTSBoZWxwZXJzCj4gPiB2MzoKPiA+ICAtIG1vdmUg a2VybmVsZG9jIHRvIGZiZGV2LCB3aGVyZSBmdW5jdGlvbnMgYXJlIGltcGxlbWVudGVkCj4gPiAg LSBzcGxpdCBrZXJuZWxkb2MgZm9yIHJlbW92ZV9jb25mbGljdGluZ19mcmFtZWJ1ZmZlcnMoKQo+ IAo+IEFoLCB0aGF0J3Mgbm90IHF1aXRlIHdoYXQgSSBoYWQgaW4gbWluZC4gSSB0aGluayBoYXZp bmcgdGhlIGRvY3MgKGFsc28pIGluCj4gdGhlIGRybSBoZWxwZXJzIHdvdWxkIGJlIGdvb2QsIHNp bmNlIHRoYXQncyB3aGVyZSBkcm0gcGVvcGxlIHdpbGwgbG9vaywKPiBhbmQgdGhhdCdzIHRoZSBm dW5jdGlvbiB0aGV5J2xsIGNhbGwuIEkganVzdCB3YW50ZWQgeW91IHRvIHNwbGl0IHRoZSBmYmRl dgo+IGFuZCBkcm0gcGFydHMgaW50byAyIHBhdGNoZXMgKHNpbmNlIHRob3NlIGFyZSB0d28gZGlm ZmVyZW50IG1haW50YWluZXJzKS4KPiAKPiBBbnl3YXksIHRoaXMgaXMgb2sgdG9vLCBzbyBpbW8g cmVhZHkgZm9yIG1lcmdpbmcuIElmIHlvdSBjYW4gcmVzdXJyZWN0IHRoZQo+IGRybSBkb2NzICh3 aXRoIGEgcGF0Y2ggdGl0bGUgb2YgImRybS9mYi1oZWxwZXI6IGRvY3VtZW50IGZiZGV2IHJlbW92 ZQo+IGZ1bmN0aW9ucyIgb3Igc2ltaWxhcikgdGhhdCB3b3VsZCBiZSBncmVhdC4KPiAKPiBPbmx5 IHRoaW5nIHdlIG5lZWQgZm9yIG1lcmdpbmcgbm93IGlzIHRoZSBhY2sgZnJvbSBCYXJ0bG9taWVq LgoKRm9yIHRoZSB3aG9sZSBwYXRjaHNldDoKCkFja2VkLWJ5OiBCYXJ0bG9taWVqIFpvbG5pZXJr aWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+Cgo+IC1EYW5pZWwKPiAKPiA+ICAtIHBy b3BhZ2F0ZSByZXR1cm4gdmFsdWUgaW4gcmVtb3ZlX2NvbmZsaWN0aW5nX3BjaV9mcmFtZWJ1ZmZl cnMoKQo+ID4gCj4gPiAtLS0KPiA+IE1pY2hhxYIgTWlyb3PFgmF3ICgxMyk6Cj4gPiAgIGZiZGV2 OiBzaG93IGZiZGV2IG51bWJlciBmb3IgZGVidWdnaW5nCj4gPiAgIGZiZGV2OiBhbGxvdyBhcGVy dHVyZXMgPT0gTlVMTCBpbiByZW1vdmVfY29uZmxpY3RpbmdfZnJhbWVidWZmZXJzKCkKPiA+ICAg ZmJkZXY6IGFkZCBrZXJuZWxkb2MgZG8gcmVtb3ZlX2NvbmZsaWN0aW5nX2ZyYW1lYnVmZmVycygp Cj4gPiAgIGZiZGV2OiBhZGQgcmVtb3ZlX2NvbmZsaWN0aW5nX3BjaV9mcmFtZWJ1ZmZlcnMoKQo+ ID4gICBkcm0vYW1kZ3B1OiB1c2Ugc2ltcGxlciByZW1vdmVfY29uZmxpY3RpbmdfcGNpX2ZyYW1l YnVmZmVycygpCj4gPiAgIGRybS9ib2NoczogdXNlIHNpbXBsZXIgcmVtb3ZlX2NvbmZsaWN0aW5n X3BjaV9mcmFtZWJ1ZmZlcnMoKQo+ID4gICBkcm0vY2lycnVzOiB1c2Ugc2ltcGxlciByZW1vdmVf Y29uZmxpY3RpbmdfcGNpX2ZyYW1lYnVmZmVycygpCj4gPiAgIGRybS9tZ2FnMjAwOiB1c2Ugc2lt cGxlciByZW1vdmVfY29uZmxpY3RpbmdfcGNpX2ZyYW1lYnVmZmVycygpCj4gPiAgIGRybS9yYWRl b246IHVzZSBzaW1wbGVyIHJlbW92ZV9jb25mbGljdGluZ19wY2lfZnJhbWVidWZmZXJzKCkKPiA+ ICAgZHJtL3ZpcnRpbzogdXNlIHNpbXBsZXIgcmVtb3ZlX2NvbmZsaWN0aW5nX3BjaV9mcmFtZWJ1 ZmZlcnMoKQo+ID4gICBkcm0vdmM0OiB1c2Ugc2ltcGxlciByZW1vdmVfY29uZmxpY3RpbmdfZnJh bWVidWZmZXJzKE5VTEwpCj4gPiAgIGRybS9zdW40aTogdXNlIHNpbXBsZXIgcmVtb3ZlX2NvbmZs aWN0aW5nX2ZyYW1lYnVmZmVycyhOVUxMKQo+ID4gICBkcm0vdGVncmE6IGtpY2sgb3V0IHNpbXBs ZWZiCj4gPiAKPiA+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZHJ2LmMgIHwg MjQgKy0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2JvY2hzL2JvY2hzX2Rydi5jICAgICAg ICB8IDE4ICstLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vY2lycnVzL2NpcnJ1c19kcnYuYyAg ICAgIHwgMjMgKy0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9k cnYuYyAgICB8IDIxICstLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIw MF9tYWluLmMgICB8ICA5IC0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9k cnYuYyAgICAgIHwgMjMgKy0tLS0tLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRp X2Rydi5jICAgICAgICB8IDE4ICstLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vdGVncmEvZHJt LmMgICAgICAgICAgICAgIHwgIDQgKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9kcnYu YyAgICAgICAgICAgIHwgMjAgKy0tLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vdmlydGlvL3Zp cnRncHVfZHJtX2J1cy5jIHwgMjQgKystLS0tLS0tCj4gPiAgZHJpdmVycy92aWRlby9mYmRldi9j b3JlL2ZibWVtLmMgICAgICAgICB8IDYzICsrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gIGlu Y2x1ZGUvZHJtL2RybV9mYl9oZWxwZXIuaCAgICAgICAgICAgICAgfCAxMiArKysrKwo+ID4gIGlu Y2x1ZGUvbGludXgvZmIuaCAgICAgICAgICAgICAgICAgICAgICAgfCAgMiArCj4gPiAgMTMgZmls ZXMgY2hhbmdlZCwgODkgaW5zZXJ0aW9ucygrKSwgMTcyIGRlbGV0aW9ucygtKQoKQmVzdCByZWdh cmRzLAotLQpCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6ClNhbXN1bmcgUiZEIEluc3RpdHV0ZSBQ b2xhbmQKU2Ftc3VuZyBFbGVjdHJvbmljcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9hbWQtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Mon, 03 Sep 2018 11:31:34 +0000 Subject: Re: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup Message-Id: <1705932.lAR3QV8q47@amdc3058> List-Id: References: <20180903074315.GB21634@phenom.ffwll.local> In-Reply-To: <20180903074315.GB21634-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Daniel Vetter Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Airlie , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Alex Deucher , Thierry Reding , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dave Airlie , Maxime Ripard , Jonathan Hunter , virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Gerd Hoffmann On Monday, September 03, 2018 09:43:15 AM Daniel Vetter wrote: > On Sat, Sep 01, 2018 at 04:08:41PM +0200, Michał Mirosław wrote: > > This series cleans up duplicated code for replacing firmware FB > > driver with proper DRI driver and adds handover support to > > Tegra driver. > > > > This is a sligtly updated version of a series sent on 24 Nov 2017. > > > > --- > > v2: > > - rebased on current drm-next > > - dropped staging/sm750fb changes > > - added kernel docs for DRM helpers > > v3: > > - move kerneldoc to fbdev, where functions are implemented > > - split kerneldoc for remove_conflicting_framebuffers() > > Ah, that's not quite what I had in mind. I think having the docs (also) in > the drm helpers would be good, since that's where drm people will look, > and that's the function they'll call. I just wanted you to split the fbdev > and drm parts into 2 patches (since those are two different maintainers). > > Anyway, this is ok too, so imo ready for merging. If you can resurrect the > drm docs (with a patch title of "drm/fb-helper: document fbdev remove > functions" or similar) that would be great. > > Only thing we need for merging now is the ack from Bartlomiej. For the whole patchset: Acked-by: Bartlomiej Zolnierkiewicz > -Daniel > > > - propagate return value in remove_conflicting_pci_framebuffers() > > > > --- > > Michał Mirosław (13): > > fbdev: show fbdev number for debugging > > fbdev: allow apertures == NULL in remove_conflicting_framebuffers() > > fbdev: add kerneldoc do remove_conflicting_framebuffers() > > fbdev: add remove_conflicting_pci_framebuffers() > > drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() > > drm/bochs: use simpler remove_conflicting_pci_framebuffers() > > drm/cirrus: use simpler remove_conflicting_pci_framebuffers() > > drm/mgag200: use simpler remove_conflicting_pci_framebuffers() > > drm/radeon: use simpler remove_conflicting_pci_framebuffers() > > drm/virtio: use simpler remove_conflicting_pci_framebuffers() > > drm/vc4: use simpler remove_conflicting_framebuffers(NULL) > > drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) > > drm/tegra: kick out simplefb > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +-------- > > drivers/gpu/drm/bochs/bochs_drv.c | 18 +------ > > drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +-------- > > drivers/gpu/drm/mgag200/mgag200_drv.c | 21 +------- > > drivers/gpu/drm/mgag200/mgag200_main.c | 9 ---- > > drivers/gpu/drm/radeon/radeon_drv.c | 23 +-------- > > drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +------ > > drivers/gpu/drm/tegra/drm.c | 4 ++ > > drivers/gpu/drm/vc4/vc4_drv.c | 20 +------- > > drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 ++------- > > drivers/video/fbdev/core/fbmem.c | 63 +++++++++++++++++++++++- > > include/drm/drm_fb_helper.h | 12 +++++ > > include/linux/fb.h | 2 + > > 13 files changed, 89 insertions(+), 172 deletions(-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.zolnierkie@samsung.com (Bartlomiej Zolnierkiewicz) Date: Mon, 03 Sep 2018 13:31:34 +0200 Subject: [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup In-Reply-To: <20180903074315.GB21634@phenom.ffwll.local> References: <20180903074315.GB21634@phenom.ffwll.local> Message-ID: <1705932.lAR3QV8q47@amdc3058> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday, September 03, 2018 09:43:15 AM Daniel Vetter wrote: > On Sat, Sep 01, 2018 at 04:08:41PM +0200, Micha? Miros?aw wrote: > > This series cleans up duplicated code for replacing firmware FB > > driver with proper DRI driver and adds handover support to > > Tegra driver. > > > > This is a sligtly updated version of a series sent on 24 Nov 2017. > > > > --- > > v2: > > - rebased on current drm-next > > - dropped staging/sm750fb changes > > - added kernel docs for DRM helpers > > v3: > > - move kerneldoc to fbdev, where functions are implemented > > - split kerneldoc for remove_conflicting_framebuffers() > > Ah, that's not quite what I had in mind. I think having the docs (also) in > the drm helpers would be good, since that's where drm people will look, > and that's the function they'll call. I just wanted you to split the fbdev > and drm parts into 2 patches (since those are two different maintainers). > > Anyway, this is ok too, so imo ready for merging. If you can resurrect the > drm docs (with a patch title of "drm/fb-helper: document fbdev remove > functions" or similar) that would be great. > > Only thing we need for merging now is the ack from Bartlomiej. For the whole patchset: Acked-by: Bartlomiej Zolnierkiewicz > -Daniel > > > - propagate return value in remove_conflicting_pci_framebuffers() > > > > --- > > Micha? Miros?aw (13): > > fbdev: show fbdev number for debugging > > fbdev: allow apertures == NULL in remove_conflicting_framebuffers() > > fbdev: add kerneldoc do remove_conflicting_framebuffers() > > fbdev: add remove_conflicting_pci_framebuffers() > > drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() > > drm/bochs: use simpler remove_conflicting_pci_framebuffers() > > drm/cirrus: use simpler remove_conflicting_pci_framebuffers() > > drm/mgag200: use simpler remove_conflicting_pci_framebuffers() > > drm/radeon: use simpler remove_conflicting_pci_framebuffers() > > drm/virtio: use simpler remove_conflicting_pci_framebuffers() > > drm/vc4: use simpler remove_conflicting_framebuffers(NULL) > > drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) > > drm/tegra: kick out simplefb > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +-------- > > drivers/gpu/drm/bochs/bochs_drv.c | 18 +------ > > drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +-------- > > drivers/gpu/drm/mgag200/mgag200_drv.c | 21 +------- > > drivers/gpu/drm/mgag200/mgag200_main.c | 9 ---- > > drivers/gpu/drm/radeon/radeon_drv.c | 23 +-------- > > drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +------ > > drivers/gpu/drm/tegra/drm.c | 4 ++ > > drivers/gpu/drm/vc4/vc4_drv.c | 20 +------- > > drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 ++------- > > drivers/video/fbdev/core/fbmem.c | 63 +++++++++++++++++++++++- > > include/drm/drm_fb_helper.h | 12 +++++ > > include/linux/fb.h | 2 + > > 13 files changed, 89 insertions(+), 172 deletions(-) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics