From: Thomas Monjalon <thomas@monjalon.net>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: Anand Rawat <anand.rawat@intel.com>,
dev@dpdk.org, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com,
bruce.richardson@intel.com
Subject: Re: [PATCH v8 08/10] eal: add minimum viable code for eal on windows
Date: Tue, 02 Apr 2019 23:38:56 +0200 [thread overview]
Message-ID: <1828556.vUbNugSFqY@xps> (raw)
In-Reply-To: <3ac129fb-709d-833a-234a-286793e2a322@intel.com>
02/04/2019 23:21, Pallavi Kadam:
>
> On 4/2/2019 1:06 PM, Thomas Monjalon wrote:
> > 02/04/2019 05:54, Anand Rawat:
> >> Add windows specific logic for eal.c, eal_lcore.c,
> >> eal_debug.c and eal_thread.c. Updated header files to
> >> contain suitable function declaractions.
> >>
> >> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> >> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> >> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> >> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> >> ---
> > [...]
> >> + /*
> >> + * create communication pipes between master thread
> >> + * and children
> >> + */
> >> + if (_pipe(lcore_config[i].pipe_master2slave,
> >> + sizeof(char), _O_BINARY) < 0)
> >> + rte_panic("Cannot create pipe\n");
> > rte_panic should be used only in applications, not in libraries.
> > The application can do something in case of DPDK failure.
> > Please remove all calls to rte_panic() during next weeks, thanks.
>
> Ok, will try to incorporate in v9. Just curious, is this the major issue?
>
> Calls to rte_panic() can be seen in linux/eal and freebsd/eal.
No, there is a misunderstanding.
I am merging v8 and I am asking for a new patch to remove these calls.
By the way, I am fixing patch 3, please check my comment on this patch.
next prev parent reply other threads:[~2019-04-02 21:39 UTC|newest]
Thread overview: 178+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 4:16 [PATCH v2 0/6] HelloWorld example for windows Anand Rawat
2019-03-06 4:16 ` [PATCH v2 1/6] eal: eal stub to add windows support Anand Rawat
2019-03-06 10:03 ` Thomas Monjalon
2019-03-06 11:20 ` Bruce Richardson
2019-03-06 11:36 ` Thomas Monjalon
2019-03-06 11:52 ` Richardson, Bruce
2019-03-07 1:04 ` Anand Rawat
2019-03-07 8:59 ` Thomas Monjalon
2019-03-07 1:19 ` Anand Rawat
2019-03-06 4:16 ` [PATCH v2 2/6] eal: add header files to support windows Anand Rawat
2019-03-06 11:31 ` Thomas Monjalon
2019-03-07 3:27 ` Anand Rawat
2019-03-07 8:45 ` Thomas Monjalon
2019-03-07 10:24 ` Bruce Richardson
2019-03-07 11:33 ` Thomas Monjalon
2019-03-07 11:53 ` Richardson, Bruce
2019-03-06 4:16 ` [PATCH v2 3/6] eal: add headers for compatibility with windows environment Anand Rawat
2019-03-06 4:16 ` [PATCH v2 4/6] eal: add minimum viable code for eal on windows Anand Rawat
2019-03-06 4:16 ` [PATCH v2 5/6] examples: add meson changes for windows Anand Rawat
2019-03-06 4:16 ` [PATCH v2 6/6] doc: add documention " Anand Rawat
2019-03-07 17:03 ` Kovacevic, Marko
2019-03-07 18:46 ` Anand Rawat
2019-03-11 12:45 ` Jerin Jacob Kollanukkaran
2019-03-11 13:51 ` Richardson, Bruce
2019-03-11 15:30 ` Raslan Darawsheh
2019-03-11 15:46 ` Jerin Jacob Kollanukkaran
2019-03-14 0:04 ` Anand Rawat
2019-03-06 8:29 ` [PATCH v2 0/6] HelloWorld example " Thomas Monjalon
2019-03-06 22:45 ` Anand Rawat
2019-03-06 23:03 ` Thomas Monjalon
2019-03-20 0:40 ` [PATCH v3 0/8] " Anand Rawat
2019-03-20 0:40 ` [PATCH v3 1/8] eal: eal stub to add windows support Anand Rawat
2019-03-20 0:40 ` [PATCH v3 2/8] eal: add header files to support windows Anand Rawat
2019-03-20 0:40 ` [PATCH v3 3/8] kvargs: adding a module definition file Anand Rawat
2019-03-20 0:40 ` [PATCH v3 4/8] eal: sys/queue.h implementation for windows Anand Rawat
2019-03-20 0:40 ` [PATCH v3 5/8] eal: add headers for compatibility with windows environment Anand Rawat
2019-03-20 0:40 ` [PATCH v3 6/8] eal: add minimum viable code for eal on windows Anand Rawat
2019-03-20 0:40 ` [PATCH v3 7/8] doc: add documention for windows Anand Rawat
2019-03-20 0:40 ` [PATCH v3 8/8] build: meson changes to build on windows Anand Rawat
2019-03-22 22:54 ` [PATCH v4 0/8] HelloWorld example for windows Anand Rawat
2019-03-22 22:54 ` [PATCH v4 1/8] eal: eal stub to add windows support Anand Rawat
2019-03-22 22:54 ` [PATCH v4 2/8] eal: add header files to support windows Anand Rawat
2019-03-22 22:55 ` [PATCH v4 3/8] kvargs: adding a module definition file Anand Rawat
2019-03-22 22:55 ` [PATCH v4 4/8] eal: sys/queue.h implementation for windows Anand Rawat
2019-03-22 22:55 ` [PATCH v4 5/8] eal: add headers for compatibility with windows environment Anand Rawat
2019-03-22 22:55 ` [PATCH v4 6/8] eal: add minimum viable code for eal on windows Anand Rawat
2019-03-22 22:55 ` [PATCH v4 7/8] doc: add documention for windows Anand Rawat
2019-03-23 16:51 ` Jerin Jacob Kollanukkaran
2019-03-25 10:24 ` Bruce Richardson
2019-03-25 17:43 ` Pallavi Kadam
2019-03-22 22:55 ` [PATCH v4 8/8] build: meson changes to build on windows Anand Rawat
2019-03-25 10:32 ` Bruce Richardson
2019-03-25 18:47 ` [PATCH v4 0/8] HelloWorld example for windows Harini Ramakrishnan
2019-03-26 6:02 ` [PATCH v5 " Anand Rawat
2019-03-26 6:02 ` [PATCH v5 1/8] eal: eal stub to add windows support Anand Rawat
2019-03-26 16:29 ` Harini Ramakrishnan
[not found] ` <MWHPR21MB0638113CDE9F61F8EC3E63D0EF5F0@MWHPR21MB0638.namprd21.prod.outlook.com>
2019-03-26 22:50 ` Omar Cardona
2019-03-26 6:02 ` [PATCH v5 2/8] eal: add header files to support windows Anand Rawat
2019-03-26 10:20 ` Jerin Jacob Kollanukkaran
2019-03-27 21:23 ` Ranjit Menon
2019-03-27 22:29 ` Thomas Monjalon
2019-03-27 23:10 ` Anand Rawat
2019-03-27 23:27 ` Thomas Monjalon
2019-03-26 16:30 ` Harini Ramakrishnan
2019-03-26 6:02 ` [PATCH v5 3/8] kvargs: adding a module definition file Anand Rawat
2019-03-26 10:32 ` Jerin Jacob Kollanukkaran
2019-03-26 10:58 ` Bruce Richardson
2019-03-26 13:37 ` [EXT] " Jerin Jacob Kollanukkaran
2019-03-26 13:55 ` Thomas Monjalon
2019-03-26 14:41 ` Bruce Richardson
2019-03-26 15:07 ` Thomas Monjalon
2019-03-26 15:17 ` Bruce Richardson
2019-03-26 15:22 ` Thomas Monjalon
2019-03-26 14:40 ` Bruce Richardson
2019-03-26 15:35 ` Jerin Jacob Kollanukkaran
2019-03-26 16:46 ` Bruce Richardson
2019-03-26 23:13 ` Anand Rawat
2019-03-26 16:31 ` Harini Ramakrishnan
2019-03-26 19:02 ` Stephen Hemminger
2019-03-26 6:02 ` [PATCH v5 4/8] eal: sys/queue.h implementation for windows Anand Rawat
2019-03-26 16:31 ` Harini Ramakrishnan
2019-03-26 19:06 ` Stephen Hemminger
2019-03-26 20:52 ` Thomas Monjalon
2019-03-26 21:14 ` Jeff Shaw
2019-03-26 21:47 ` Thomas Monjalon
2019-03-26 21:54 ` Jeff Shaw
2019-03-26 22:23 ` Thomas Monjalon
2019-03-26 22:34 ` Jeff Shaw
2019-03-26 23:00 ` Thomas Monjalon
2019-03-26 23:43 ` Jeff Shaw
2019-03-26 23:54 ` Thomas Monjalon
2019-03-27 21:16 ` Anand Rawat
2019-03-26 6:02 ` [PATCH v5 5/8] eal: add headers for compatibility with windows environment Anand Rawat
2019-03-26 16:33 ` Harini Ramakrishnan
2019-03-26 6:02 ` [PATCH v5 6/8] eal: add minimum viable code for eal on windows Anand Rawat
2019-03-26 16:32 ` Harini Ramakrishnan
2019-03-26 6:02 ` [PATCH v5 7/8] doc: add documention for windows Anand Rawat
2019-03-26 10:27 ` Jerin Jacob Kollanukkaran
2019-03-26 10:37 ` David Marchand
2019-03-26 18:29 ` Anand Rawat
2019-03-26 16:33 ` Harini Ramakrishnan
2019-03-26 6:02 ` [PATCH v5 8/8] build: meson changes to build on windows Anand Rawat
2019-03-26 16:34 ` Harini Ramakrishnan
2019-03-26 16:28 ` [PATCH v5 0/8] HelloWorld example for windows Harini Ramakrishnan
[not found] ` <MWHPR21MB06380D6FA7CF5513DDC3820AEF5F0@MWHPR21MB0638.namprd21.prod.outlook.com>
2019-03-26 22:43 ` Omar Cardona
2019-03-28 2:21 ` [PATCH v6 " Anand Rawat
2019-03-28 2:21 ` [PATCH v6 1/8] eal: eal stub to add windows support Anand Rawat
2019-03-28 19:27 ` Harini Ramakrishnan
2019-03-28 2:21 ` [PATCH v6 2/8] eal: add header files to support os specifics Anand Rawat
2019-03-28 19:27 ` Harini Ramakrishnan
2019-03-28 2:21 ` [PATCH v6 3/8] build: add module definition file for windows Anand Rawat
2019-03-28 19:29 ` Harini Ramakrishnan
2019-03-28 2:21 ` [PATCH v6 4/8] eal: sys/queue.h implementation " Anand Rawat
2019-03-28 2:30 ` Varghese, Vipin
2019-03-28 2:39 ` Anand Rawat
2019-03-28 3:29 ` Varghese, Vipin
2019-03-28 19:30 ` Harini Ramakrishnan
2019-03-28 2:21 ` [PATCH v6 5/8] eal: add headers for compatibility with windows Anand Rawat
2019-03-28 19:29 ` Harini Ramakrishnan
2019-03-28 2:21 ` [PATCH v6 6/8] eal: add minimum viable code for eal on windows Anand Rawat
2019-03-28 19:32 ` Harini Ramakrishnan
2019-03-28 2:21 ` [PATCH v6 7/8] doc: add documentation for windows Anand Rawat
2019-03-28 19:31 ` Harini Ramakrishnan
2019-03-28 2:21 ` [PATCH v6 8/8] build: meson changes to build on windows Anand Rawat
2019-03-28 15:10 ` Thomas Monjalon
2019-03-28 19:30 ` Harini Ramakrishnan
2019-03-28 19:28 ` [PATCH v6 0/8] HelloWorld example for windows Harini Ramakrishnan
2019-03-28 23:24 ` [PATCH v7 " Anand Rawat
2019-03-28 23:24 ` [PATCH v7 1/8] eal: eal stub to add windows support Anand Rawat
2019-04-01 16:17 ` Bruce Richardson
2019-04-01 16:34 ` Bruce Richardson
2019-04-01 17:06 ` Anand Rawat
2019-04-01 20:10 ` Bruce Richardson
2019-03-28 23:24 ` [PATCH v7 2/8] eal: add header files to support os specifics Anand Rawat
2019-04-01 23:09 ` Thomas Monjalon
2019-04-02 3:52 ` Anand Rawat
2019-03-28 23:24 ` [PATCH v7 3/8] build: add module definition file for windows Anand Rawat
2019-03-28 23:24 ` [PATCH v7 4/8] eal: sys/queue.h implementation " Anand Rawat
2019-03-28 23:24 ` [PATCH v7 5/8] eal: add headers for compatibility with windows Anand Rawat
2019-03-28 23:24 ` [PATCH v7 6/8] eal: add minimum viable code for eal on windows Anand Rawat
2019-03-28 23:24 ` [PATCH v7 7/8] doc: add documentation for windows Anand Rawat
2019-03-29 0:06 ` Harini Ramakrishnan
2019-04-01 23:22 ` Thomas Monjalon
2019-04-02 1:01 ` Pallavi Kadam
2019-04-02 7:15 ` Thomas Monjalon
2019-03-28 23:24 ` [PATCH v7 8/8] build: meson changes to build on windows Anand Rawat
2019-04-01 23:25 ` Thomas Monjalon
2019-04-02 3:47 ` Anand Rawat
2019-03-29 0:12 ` [PATCH v7 0/8] HelloWorld example for windows Harini Ramakrishnan
2019-04-02 3:54 ` [PATCH v8 00/10] HelloWorld example for Windows Anand Rawat
2019-04-02 3:54 ` [PATCH v8 01/10] eal: eal stub to add windows support Anand Rawat
2019-04-02 3:54 ` [PATCH v8 02/10] meson: required changes for windows Anand Rawat
2019-04-02 23:04 ` Thomas Monjalon
2019-04-02 23:23 ` Pallavi Kadam
2019-04-02 3:54 ` [PATCH v8 03/10] eal: add new rte_os.h header to build system Anand Rawat
2019-04-02 19:56 ` Thomas Monjalon
2019-04-02 20:47 ` Thomas Monjalon
2019-04-02 22:11 ` Anand Rawat
2019-04-02 22:32 ` Thomas Monjalon
2019-04-02 22:34 ` Anand Rawat
2019-04-02 3:54 ` [PATCH v8 04/10] eal: update common headers to use rte_os.h Anand Rawat
2019-04-02 3:54 ` [PATCH v8 05/10] build: add module definition file for windows Anand Rawat
2019-04-02 23:03 ` Thomas Monjalon
2019-04-02 3:54 ` [PATCH v8 06/10] eal: sys/queue.h implementation " Anand Rawat
2019-04-02 3:54 ` [PATCH v8 07/10] eal: add headers for compatibility with windows Anand Rawat
2019-04-02 3:54 ` [PATCH v8 08/10] eal: add minimum viable code for eal on windows Anand Rawat
2019-04-02 20:06 ` Thomas Monjalon
2019-04-02 21:21 ` Pallavi Kadam
2019-04-02 21:38 ` Thomas Monjalon [this message]
2019-04-02 21:46 ` Pallavi Kadam
2019-04-02 22:39 ` Thomas Monjalon
2019-04-02 22:57 ` Anand Rawat
2019-04-02 3:54 ` [PATCH v8 09/10] doc: add documentation for windows Anand Rawat
2019-04-02 3:54 ` [PATCH v8 10/10] build: meson changes to build on windows Anand Rawat
2019-04-02 22:51 ` Thomas Monjalon
2019-04-02 23:01 ` Anand Rawat
2019-04-02 23:25 ` [PATCH v8 00/10] HelloWorld example for Windows Thomas Monjalon
2019-04-02 23:49 ` Anand Rawat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1828556.vUbNugSFqY@xps \
--to=thomas@monjalon.net \
--cc=anand.rawat@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jeffrey.b.shaw@intel.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.