Re: [Buildroot] [PATCH] package/bluez5_utils: expose more disable options

[Michael Nosthoff via buildroot <buildroot@busybox.net>]

Hi,

On 27.07.21 21:53, Arnout Vandecappelle wrote:
> On 26/07/2021 23:07, Thomas Petazzoni wrote:
>> Arnout, Peter, Yann: in order to preserve backward compatibility,
>> Michael has created those new options with a "default y". However,
>> while it keeps backward compatibility, it also means that all new users
>> will get a more bloated bluez_utils installation than is probably
>> necessary. Should we break our backward compatibility rule here and
>> drop the "default y" on those new options ?

If we go for a compatibility break here I would then also submit a patch 
to make
"--disable-tools" configurable and default to no. Those tools are 
usually not
required when using d-bus and/or bluetoothctl and add up to 1-2MB.

I was hesitant on this one because the relation with 
--disable-deprecated, which
buildroot already exposes, is a bit weird but I think i figured it out.

>   I know from experience that that's the kind of tricky changes that can make it
> annoying to update Buildroot.
>
>   Assuming you select bluez5_utils from menuconfig, having a default y is not
> much of a problem in practice. However, bluez5_utils is also selected
> automatically by a couple of packages [*] - in that case, the user doesn't see
> the suboptions so isn't aware that they can disable them.
>
>   So yes, there are good reasons to prefer default n. But then I think we should
> think of a way to smoothen things for people who want to update buildroot. Here
> are a few ideas:
>
> - Just mention it in CHANGES.
 From a user perspective I think this should mention this, even if we go 
with the migrating.txt
or another approach. Because this is where I look on upgrading before 
trying to build.

> [*] BTW, did someone check if those packages that select bluez5_utils now should
> be updated to select the appropriate plugin? Probably not - I imagine cwiid (for
> the wiimote) for example needs the HID plugin, and the gstreamer plugin needs
> A2DP and/or AVDP. Runtime dependencies, of course, so we'll never know until
> someone actually complains about it.

I have some spare time in the next days. I'll check the dependencies 
where possible.

Regards,
Michael

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot