From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:46144 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752940Ab2DQA5A (ORCPT ); Mon, 16 Apr 2012 20:57:00 -0400 From: Laurent Pinchart To: Tomasz Stanislawski Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@redhat.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, sumit.semwal@ti.com, daeinki@gmail.com, daniel.vetter@ffwll.ch, robdclark@gmail.com, pawel@osciak.com, linaro-mm-sig@lists.linaro.org, hverkuil@xs4all.nl, remi@remlab.net, subashrp@gmail.com, mchehab@redhat.com, Sumit Semwal Subject: Re: [PATCH v4 11/14] v4l: vb2-dma-contig: add support for dma_buf importing Date: Tue, 17 Apr 2012 02:57:10 +0200 Message-ID: <1933889.sK9pAxfEdI@avalon> In-Reply-To: <1334332076-28489-12-git-send-email-t.stanislaws@samsung.com> References: <1334332076-28489-1-git-send-email-t.stanislaws@samsung.com> <1334332076-28489-12-git-send-email-t.stanislaws@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Tomasz, Thanks for the patch. On Friday 13 April 2012 17:47:53 Tomasz Stanislawski wrote: > From: Sumit Semwal > > This patch makes changes for adding dma-contig as a dma_buf user. It > provides function implementations for the {attach, detach, map, > unmap}_dmabuf() mem_ops of DMABUF memory type. > > Signed-off-by: Sumit Semwal > Signed-off-by: Sumit Semwal > [author of the original patch] > Signed-off-by: Tomasz Stanislawski > [integration with refactored dma-contig allocator] Pending the comment below, Acked-by: Laurent Pinchart > +static void vb2_dc_detach_dmabuf(void *mem_priv) > +{ > + struct vb2_dc_buf *buf = mem_priv; > + > + if (WARN_ON(buf->dma_addr)) > + vb2_dc_unmap_dmabuf(buf); This should never happen, and would be a videobuf2 bug otherwise, right ? > + > + /* detach this attachment */ > + dma_buf_detach(buf->db_attach->dmabuf, buf->db_attach); > + kfree(buf); > +} -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 11/14] v4l: vb2-dma-contig: add support for dma_buf importing Date: Tue, 17 Apr 2012 02:57:10 +0200 Message-ID: <1933889.sK9pAxfEdI@avalon> References: <1334332076-28489-1-git-send-email-t.stanislaws@samsung.com> <1334332076-28489-12-git-send-email-t.stanislaws@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id E0D479FD73 for ; Mon, 16 Apr 2012 17:56:59 -0700 (PDT) In-Reply-To: <1334332076-28489-12-git-send-email-t.stanislaws@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Tomasz Stanislawski Cc: pawel@osciak.com, mchehab@redhat.com, daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, subashrp@gmail.com, linaro-mm-sig@lists.linaro.org, kyungmin.park@samsung.com, airlied@redhat.com, remi@remlab.net, linux-media@vger.kernel.org, Sumit Semwal , m.szyprowski@samsung.com List-Id: dri-devel@lists.freedesktop.org Hi Tomasz, Thanks for the patch. On Friday 13 April 2012 17:47:53 Tomasz Stanislawski wrote: > From: Sumit Semwal > > This patch makes changes for adding dma-contig as a dma_buf user. It > provides function implementations for the {attach, detach, map, > unmap}_dmabuf() mem_ops of DMABUF memory type. > > Signed-off-by: Sumit Semwal > Signed-off-by: Sumit Semwal > [author of the original patch] > Signed-off-by: Tomasz Stanislawski > [integration with refactored dma-contig allocator] Pending the comment below, Acked-by: Laurent Pinchart > +static void vb2_dc_detach_dmabuf(void *mem_priv) > +{ > + struct vb2_dc_buf *buf = mem_priv; > + > + if (WARN_ON(buf->dma_addr)) > + vb2_dc_unmap_dmabuf(buf); This should never happen, and would be a videobuf2 bug otherwise, right ? > + > + /* detach this attachment */ > + dma_buf_detach(buf->db_attach->dmabuf, buf->db_attach); > + kfree(buf); > +} -- Regards, Laurent Pinchart