From: Lars Kurth <lars.kurth@citrix.com>
To: Ian Jackson <Ian.Jackson@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
George Dunlap <George.Dunlap@citrix.com>
Subject: Re: [PATCH 4/5] SUPPORT.md: Move descriptions up before Status info
Date: Tue, 17 Apr 2018 15:49:57 +0000 [thread overview]
Message-ID: <1ED1EB0E-D091-46E3-88F8-7F0152BBE2DE@citrix.com> (raw)
In-Reply-To: <23253.62724.916985.578367@mariner.uk.xensource.com>
On 17/04/2018, 14:22, "Ian Jackson" <ian.jackson@citrix.com> wrote:
Lars Kurth writes ("Re: [PATCH 4/5] SUPPORT.md: Move descriptions up before Status info"):
> There were a couple of minor text changes for grammar reasons, which I noticed and highlighted.
Thanks.
> I also checked the code motions. There are some things which need to be pointed out, but they should not prevent this series from being checked in.
>
> However, a couple were missed
> * ### PV Console (frontend) => missed moving the note (which is a definition)
That's one, not a couple. I have fixed it.
> I also spotted a few other inconsistencies, which we probably should fix, but these need backporting
> * ARM: 16K and 64K page granularity in guests
> * ARM: Guest Device Tree support
> * ARM: Guest ACPI support
> In all the other section headers we use x86/ or ARM/
I think "x86:" and "ARM:" are more natural so I would prefer that
bikeshed purple rather than blue. I think the "/" came from the
example of the guest types, which are indeed in some sense "x86/HVM"
rather than "x86: HVM".
I think we should treat that as a separate issue from this series.
Agreed
> -### x86/PVH
> -
> Status, domU: Supported
> - Status, dom0: Experimental
> +
> +### x86/PVH
>
> PVH is a next-generation paravirtualized mode
> designed to take advantage of hardware virtualization support when possible.
>
> Looks correct from a mere refactoring perspective, but generates some odd behaviour in https://xenbits.xen.org/people/iwj/2018/support-matrix-example-B-v1/t.html
>
> The underlying reason is that we had some headline re-names between 4.10 and 4.11. e.g.
> ARM guest => ARM
>
> And some support statement changes, e.g. in x86/HVM guest
> Status: Supported => Status, domU: Supported
The rendering is indeed not ideal. Our options are:
(a) Live with it and document it.
(b) Make it our practice to go always back and backport a name
change for a feature to all versions. I'm not sure this is worth
the effort.
(c) Invent some new equivalency metadata to put into SUPPORT.md or
even into some other file in-tree. Urgh, I don't want to do
that.
I chose (a). You will see a paragraph about this at the top of the
html page:
Sometimes the same feature, or a similar feature, is named
differently in the documentation for different releases. In such
cases the table will show it as two separate features, with a
discontinuity in support, even though support may have been
continuous.
I can live with this approach
> We probably need to go through some of these in 4.10 and fix them
> But for 4.11 this is correct
I think the 4.10 documentation is not wrong, just differently
expressed.
> The implication is that we need to minimize unnecessary changes to
> a) headings
> b) clarifications to status before the colon
> or backport them to older versions of SUPPORT.md. Otherwise the generated table will become confusing
See above. If you want to backport the heading changes, I'll ack your
patches :-).
Happy to pick this up
> ### Direct-boot kernel image format
>
> +Format which the toolstack accepts for direct-boot kernels
> +
> Supported, x86: bzImage, ELF
> Supported, ARM32: zImage
> Supported, ARM64: Image
>
> -Format which the toolstack accepts for direct-boot kernels
> -
>
> Note: the format here is wrong in both 4.10 and 4.11, this should be something like
>
> Status, zImage (ARM32): Supported
>
> Lars will submit a separate patch
This is not a blocker because I added parsing code for this format.
If you fix it, we can drop that, too, once the change is backported.
> ## Scalability
>
> ### Super page support
>
> - Status, x86 HVM/PVH, HAP: Supported
> - Status, x86 HVM/PVH, Shadow, 2MiB: Supported
> - Status, ARM: Supported
> -
> NB that this refers to the ability of guests
>
> The beginning of this sentence should probably be changed to
> "This feature refers to the ability of guests ..."
Or even just "The ability of guests ..." since we don't normally lead
each thing with "this is". I think this is not very important. If
you want to improve it I will ack your patch.
Sure, I can roll this up with the other changes on my list
> ## Virtual Hardware, QEMU
>
> -These are devices available in HVM mode using a qemu devicemodel (the default).
> +This section describes supported devices available in HVM mode using a
> +qemu devicemodel (the default).
> +
> + Status: Support scope restricted
> +
> Note that other devices are available but not security supported.
>
> This is causing a rendering issue: the footnote is not generated in the right place. It is added to " stgvga". Presumably a corner case in the table generation tool
Yes. It is generating semantically invalid html which renders very
oddly, too. I will fix it.
Thanks
Lars
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-04-17 15:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 18:26 [PATCH 0/5] SUPPORT.md: Distinguish descriptions from caveats Ian Jackson
2018-04-12 18:26 ` [PATCH 1/5] docs/parse-support-md: internals: Introduce docref_a Ian Jackson
2018-04-12 18:26 ` [PATCH 2/5] docs/parse-support-md: internals: Rename HasText to HasCaveat Ian Jackson
2018-04-12 18:26 ` [PATCH 3/5] SUPPORT.md, support matrix: Treat commentary before status as description Ian Jackson
2018-04-12 18:26 ` [PATCH 4/5] SUPPORT.md: Move descriptions up before Status info Ian Jackson
2018-04-13 11:31 ` Lars Kurth
2018-04-17 13:22 ` Ian Jackson
2018-04-17 15:49 ` Lars Kurth [this message]
2018-04-12 18:26 ` [PATCH 5/5] SUPPORT.md: Document the new text ordering rule Ian Jackson
2018-04-13 10:14 ` Lars Kurth
2018-04-13 10:31 ` Ian Jackson
2018-04-13 11:58 ` Lars Kurth
2018-04-12 18:29 ` [PATCH 0/5] SUPPORT.md: Distinguish descriptions from caveats Ian Jackson
2018-04-13 7:56 ` Lars Kurth
2018-04-13 4:37 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ED1EB0E-D091-46E3-88F8-7F0152BBE2DE@citrix.com \
--to=lars.kurth@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.