All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Luca Fancellu <luca.fancellu@arm.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/3] EFI: move efi-boot.h inclusion point
Date: Mon, 6 Dec 2021 08:27:18 +0100	[thread overview]
Message-ID: <1a6dd0a2-5a09-d39f-b0b9-c7c33f313403@suse.com> (raw)
In-Reply-To: <F1FE39BE-191B-4245-84EE-1109B9762B54@arm.com>

On 03.12.2021 17:10, Luca Fancellu wrote:
>> On 3 Dec 2021, at 10:56, Jan Beulich <jbeulich@suse.com> wrote:
>>
>> When it was introduced, it was imo placed way too high up, making it
>> necessary to forward-declare way too many static functions. Move it down
>> together with
>> - the efi_check_dt_boot() stub, which afaict was deliberately placed
>>  immediately ahead of the #include,
>> - blexit(), because of its use of the efi_arch_blexit() hook.
>> Move up get_value() and set_color() to before the inclusion so their
>> forward declarations can also be zapped.
>>
> 
> With the “const” attribute now some function in this serie are above the char line
> limit, however everything looks fine.

I wonder which part of this patch you're referring to. I don't recall any
addition of const here - I think I'm strictly only moving code around some
code and delete some declarations. I've further checked the code being
moved, and I couldn't spot any line going beyond 80 chars.

> Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Thanks.

Jan



  reply	other threads:[~2021-12-06  7:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 10:54 [PATCH 0/3]: EFI: some tidying Jan Beulich
2021-12-03 10:56 ` [PATCH 1/3] EFI: move efi-boot.h inclusion point Jan Beulich
2021-12-03 11:21   ` Andrew Cooper
2021-12-03 11:25     ` Jan Beulich
2021-12-03 11:26       ` Andrew Cooper
2021-12-03 12:50     ` Jan Beulich
2021-12-03 15:51       ` Andrew Cooper
2021-12-03 16:10   ` Luca Fancellu
2021-12-06  7:27     ` Jan Beulich [this message]
2021-12-06  8:39       ` Luca Fancellu
2021-12-03 10:57 ` [PATCH 2/3] EFI: constify EFI_LOADED_IMAGE * function parameters Jan Beulich
2021-12-03 16:11   ` Luca Fancellu
2021-12-10  9:44   ` Ping: " Jan Beulich
2021-12-10 10:07     ` Julien Grall
2021-12-03 10:58 ` [PATCH 3/3] EFI: drop copy-in from QueryVariableInfo()'s OUT-only variable bouncing Jan Beulich
2021-12-03 16:11   ` Luca Fancellu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a6dd0a2-5a09-d39f-b0b9-c7c33f313403@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=iwj@xenproject.org \
    --cc=julien@xen.org \
    --cc=luca.fancellu@arm.com \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.