From: Thomas Huth <thuth@redhat.com>
To: Halil Pasic <pasic@linux.vnet.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>
Cc: Pierre Morel <pmorel@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/7] s390x/css: be more consistent if broken beyond repair
Date: Wed, 18 Oct 2017 10:13:16 +0200 [thread overview]
Message-ID: <1a8c195e-2ffe-20bf-555d-20ea50358f1b@redhat.com> (raw)
In-Reply-To: <20171017140453.51099-2-pasic@linux.vnet.ibm.com>
On 17.10.2017 16:04, Halil Pasic wrote:
> Calling do_subchannel_work with no function control flags set in SCSW is
> a programming error. Currently the handle this differently in
> do_subchannel_work_virtual and do_subchannel_work_passthrough. Let's be
> consistent and guard with a common assert against this programming error.
>
> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> ---
> Already applied to Connies s390-next. Included for the sake of completenes
> (with) the old typo in the commit message.
Looks like Cornelia fixed it up in s390-next :-)
> ---
> hw/s390x/css.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
FWIW:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-10-18 8:13 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 14:04 [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr Halil Pasic
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 1/7] s390x/css: be more consistent if broken beyond repair Halil Pasic
2017-10-18 8:13 ` Thomas Huth [this message]
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 2/7] s390x/css: IO instr handler ending control Halil Pasic
2017-10-17 14:58 ` Cornelia Huck
2017-10-17 16:13 ` Halil Pasic
2017-10-18 8:45 ` Thomas Huth
2017-10-18 9:34 ` Cornelia Huck
2017-10-18 9:13 ` Dong Jia Shi
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 3/7] s390x: improve error handling for SSCH and RSCH Halil Pasic
2017-10-17 15:06 ` Cornelia Huck
2017-10-18 9:30 ` Thomas Huth
2017-10-18 9:52 ` Thomas Huth
2017-10-18 9:58 ` Cornelia Huck
2017-10-18 10:02 ` Thomas Huth
2017-10-18 9:52 ` Cornelia Huck
2017-10-18 10:07 ` Thomas Huth
2017-10-18 11:07 ` Halil Pasic
2017-10-18 11:12 ` Thomas Huth
2017-10-18 11:17 ` Halil Pasic
2017-10-19 6:06 ` Dong Jia Shi
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 4/7] s390x: refactor error handling for XSCH handler Halil Pasic
2017-10-17 15:07 ` Cornelia Huck
2017-10-18 9:33 ` Thomas Huth
2017-10-19 6:11 ` Dong Jia Shi
2017-10-19 9:10 ` Halil Pasic
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 5/7] s390x: refactor error handling for CSCH handler Halil Pasic
2017-10-17 15:09 ` Cornelia Huck
2017-10-18 9:36 ` Thomas Huth
2017-10-19 6:14 ` Dong Jia Shi
2017-10-19 9:11 ` Cornelia Huck
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 6/7] s390x: refactor error handling for HSCH handler Halil Pasic
2017-10-17 15:10 ` Cornelia Huck
2017-10-18 9:55 ` Thomas Huth
2017-10-19 6:17 ` Dong Jia Shi
2017-10-17 14:04 ` [Qemu-devel] [PATCH v3 7/7] s390x: refactor error handling for MSCH handler Halil Pasic
2017-10-17 15:11 ` Cornelia Huck
2017-10-18 10:00 ` Thomas Huth
2017-10-18 10:02 ` Cornelia Huck
2017-10-18 11:01 ` Halil Pasic
2017-10-19 6:23 ` Dong Jia Shi
2017-10-17 15:13 ` [Qemu-devel] [PATCH v3 0/7] improve error handling for IO instr Cornelia Huck
2017-10-17 16:19 ` Halil Pasic
2017-10-18 7:38 ` Cornelia Huck
2017-10-18 8:23 ` Dong Jia Shi
2017-10-18 9:53 ` Cornelia Huck
2017-10-19 6:01 ` Dong Jia Shi
2017-10-18 12:50 ` Cornelia Huck
2017-10-19 10:46 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a8c195e-2ffe-20bf-555d-20ea50358f1b@redhat.com \
--to=thuth@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=cohuck@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.