Re: [BUG REPORT 2.6.0] cisco airo_cs scheduling while atomic

From: Georg Nikodym <georgn@somanetworks.com>
To: svenud@ozemail.com.au
Cc: Andrew Morton <akpm@osdl.org>,
	breed@users.sourceforge.net, linux-kernel@vger.kernel.org,
	Tom Sightler <ttsig@tuxyturvy.com>
Subject: Re: [BUG REPORT 2.6.0] cisco airo_cs scheduling while atomic
Date: Mon, 21 Jul 2003 13:15:47 -0400	[thread overview]
Message-ID: <20030721131547.45241e2e.georgn@somanetworks.com> (raw)
In-Reply-To: <1058619536.752.19.camel@localhost>

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On 19 Jul 2003 22:58:57 +1000
Sven Dowideit <svenud@ozemail.com.au> wrote:

> @@ -4838,7 +4850,7 @@
>         readCapabilityRid(local, &cap_rid);
>  
>         dwrq->length = sizeof(struct iw_range);
> -       memset(range, 0, sizeof(*range));
> +       memset(range, 0, sizeof(range));
>         range->min_nwid = 0x0000;
>         range->max_nwid = 0x0000;
>         range->num_channels = 14;

I suspect that this part of the patch to airo.c is incorrect.  The
intent seems to be to clear a section of memory pointed to by range that
contains (or will soon contain) a struct iw_range.  The sizeof(*range)
is equivalent of the sizeof(struct iw_range) above.  The patch reduces
the size of the memset to the size of the pointer (which I'm assuming is
smaller than the structure [/me goes and looks]).

Of course, the range pointer is derived from the char *extra
parameter...  this could mean that we're actually getting a pre-filled
iw_range and the memset is only supposed to clear the first member.  If
that's the case, I would hope that the author could come up with a
cleaner way of expressing that.

-g

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]