All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@colin2.muc.de>
To: Muli Ben-Yehuda <mulix@mulix.org>
Cc: Andi Kleen <ak@muc.de>,
	torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
	bos@serpentine.com
Subject: Re: [PATCH] Fix mlockall for PROT_NONE mappings
Date: 9 Oct 2003 13:31:11 +0200
Date: Thu, 9 Oct 2003 13:31:11 +0200	[thread overview]
Message-ID: <20031009113111.GA48461@colin2.muc.de> (raw)
In-Reply-To: <20031009112458.GE4699@actcom.co.il>

> I agree that improved readability is not "essential". Do you agree
> that it's preferable?  

I don't think this version is particularly unreadable or that your
change would improve it very much.
(to make any sense of a function with 6+ arguments you have to look
at the function definition, no way around that, and there is a comment
that explains it there), so I don't think the change is particularly
important.

-Andi

  reply	other threads:[~2003-10-09 11:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-09 10:42 [PATCH] Fix mlockall for PROT_NONE mappings Andi Kleen
2003-10-09 10:49 ` Muli Ben-Yehuda
2003-10-09 11:22   ` Andi Kleen
2003-10-09 11:24     ` Muli Ben-Yehuda
2003-10-09 11:31       ` Andi Kleen [this message]
2003-10-09 14:44 ` Linus Torvalds
2003-10-09 14:52   ` Andi Kleen
2003-10-09 14:56     ` Linus Torvalds
2003-10-09 15:12       ` Andi Kleen
2003-10-09 15:17         ` Linus Torvalds
2003-10-09 15:33           ` Andi Kleen
2003-10-09 15:40             ` Linus Torvalds
2003-10-09 16:34               ` Andi Kleen
2003-10-09 17:28                 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031009113111.GA48461@colin2.muc.de \
    --to=ak@colin2.muc.de \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=bos@serpentine.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mulix@mulix.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.