Re: [PATCH] qgit: Default the log window to wider than the file list and set monospaced font

[Andy Parkins <andyparkins@gmail.com>]

On Thursday 2007, February 08 19:29, Marco Costalba wrote:

> qgit4 seems to have more layout weirdeness also in patch and file
> tabs. I didn't fixed it until because I'm still wondering if it is
> enough fixing the layout using stretch factors or bite the bullet and
> implement a geometry persistent saving with QSettings (Qt4 is quite
> powerful in this regard), of course saved geometry should work both
> with maximized and not-maximized window, so perhaps saving
> panes/splitters factors is better then save absolute value at least
> for 'internal' widget, and use absolute window geometry only for qgit
> main window.

Saving factors is definitely the way to go; and then you may as well use 
the stretch factors as that's all they are in essence.  Setting a 3:1 
stretch ratio would be the same as setting 75% and 25% factors.  The 
ideal solution is really to set one of them based on the contents, 
probably the file list; but that's difficult to do as you don't want 
excessively deep trees to make the thing stupidly wide.  In the end, I 
think making layouts that work in all situations in near impossible, so 
I usually just go for stretch factors that make it look reasonable in 
most situations.

> Please add dbg(text) line in git.cpp, just below
> Qt::convertFromPlainText(text) call
>
> 		text.append("\n\n    " + colorMatch(c->shortLog(), shortLogRE) +
> 		            '\n' + colorMatch(c->longLog(), longLogRE));
> 	}
> 	text = Qt::convertFromPlainText(text);
> dbg(text);

Good idea.  I tried it and the problem would seem to be that 
convertFromPlainText() doesn't do the conversion as completely as it 
should.  The spaces are being left as spaces, but of course when those 
get passed to the HTML-ish parser of QTextBrowser, the spaces are being 
swallowed - as with all HTML parsers.  I believe it should actually be 
replacing all the spaces with " " to /really/ do the plain->HTML 
conversion.  However, the point is moot now anyway because I've dropped 
it in favour of a div with "white-space: pre" set, which does the job.


Andy
-- 
Dr Andrew Parkins, M Eng (Hons), AMIEE
andyparkins@gmail.com