From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jikos@jikos.cz>
Cc: "Ananiev, Leonid I" <leonid.i.ananiev@intel.com>,
linux-kernel@vger.kernel.org, linux-aio <linux-aio@kvack.org>,
Zach Brown <zach.brown@oracle.com>,
suparna@in.ibm.com, Chris Mason <chris.mason@oracle.com>,
Badari Pulavarty <pbadari@us.ibm.com>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] aio: fix kernel bug when page is temporally busy
Date: Fri, 9 Feb 2007 02:14:44 -0800 [thread overview]
Message-ID: <20070209021444.2213deb6.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702091042330.25686@twin.jikos.cz>
On Fri, 9 Feb 2007 10:54:36 +0100 (CET) Jiri Kosina <jikos@jikos.cz> wrote:
> @@ -1204,7 +1204,7 @@ generic_file_aio_read(struct kiocb *iocb, const struct iovec *iov,
> do_generic_file_read(filp,ppos,&desc,file_read_actor);
> retval += desc.written;
> if (desc.error) {
> - retval = retval ?: desc.error;
> + retval = desc.error;
> break;
> }
Nope. On error the read() syscall must return the number of bytes which
were successfully read.
next prev parent reply other threads:[~2007-02-09 10:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 4:29 [PATCH] aio: fix kernel bug when page is temporally busy Ananiev, Leonid I
2007-02-09 4:35 ` Andrew Morton
2007-02-09 5:41 ` Ananiev, Leonid I
2007-02-09 5:52 ` Andrew Morton
2007-02-12 22:52 ` Ananiev, Leonid I
2007-02-12 23:21 ` Ananiev, Leonid I
2007-02-09 7:16 ` Suparna Bhattacharya
2007-02-09 9:52 ` Ananiev, Leonid I
2007-02-09 10:11 ` Jiri Kosina
2007-02-10 18:05 ` Ken Chen
2007-02-10 18:17 ` Ananiev, Leonid I
2007-02-10 18:27 ` Ananiev, Leonid I
2007-02-10 21:57 ` Ananiev, Leonid I
2007-02-15 9:16 ` Ananiev, Leonid I
2007-02-15 18:25 ` Zach Brown
2007-02-15 19:11 ` Ananiev, Leonid I
2007-02-15 19:22 ` Zach Brown
2007-02-15 21:06 ` Ananiev, Leonid I
2007-02-15 23:32 ` Ananiev, Leonid I
2007-02-16 0:01 ` Zach Brown
2007-02-16 12:18 ` Ananiev, Leonid I
2007-02-09 9:54 ` Jiri Kosina
2007-02-09 10:14 ` Andrew Morton [this message]
2007-02-09 10:40 ` Jiri Kosina
2007-02-09 11:05 ` Suparna Bhattacharya
2007-02-09 11:18 ` Ananiev, Leonid I
2007-02-09 17:02 ` Zach Brown
2007-02-10 19:36 Ananiev, Leonid I
2007-02-14 17:51 Ananiev, Leonid I
2007-02-15 3:30 ` Andrew Morton
2007-02-15 5:26 ` Ananiev, Leonid I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070209021444.2213deb6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=jack@suse.cz \
--cc=jikos@jikos.cz \
--cc=leonid.i.ananiev@intel.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=suparna@in.ibm.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.