From: Alan <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH][pata] ide: cable detection fixes
Date: Sun, 11 Feb 2007 23:08:40 +0000 [thread overview]
Message-ID: <20070211230840.06c1f38b@localhost.localdomain> (raw)
In-Reply-To: <200702112324.21704.bzolnier@gmail.com>
> * use eighty_ninty_three() in ide_ata66_check(), this actually fixes 3 bugs:
> - bit 13 (word 93 validity check) == 1 and bit 12 (80-wire cable test) == 0
> configuration was incorrectly treated as a 80-wire cable present
I think you mean bit 14 and bit 13. And for validity you must check bits
14/15 together as 0x01. Code seems to have the bits right not the
comment, but doesn't check bit 15.
You also change the IVB behaviour from assuming drives would set either
the correct bit and/or the valid bit, to drives must always set the
correct bit but not neccessarily valid. It would be nice to know if that
is intentional as the original IVB hack is murky early ATA standard
history and I am not sure what the drive id error in question actually
was ?
Alan
next prev parent reply other threads:[~2007-02-11 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-11 22:24 [PATCH][pata] ide: cable detection fixes Bartlomiej Zolnierkiewicz
2007-02-11 23:08 ` Alan [this message]
2007-02-12 0:37 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070211230840.06c1f38b@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.