All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: akpm@linux-foundation.org, Jeff Garzik <jeff@garzik.org>,
	Al Viro <viro@ftp.linux.org.uk>,
	torvalds@linux-foundation.org, Tejun Heo <htejun@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH] ia64: Fix noncoherent DMA API so devres builds
Date: Mon, 12 Feb 2007 13:06:04 -0800	[thread overview]
Message-ID: <20070212210604.GA12991@intel.com> (raw)
In-Reply-To: <adalkj49c42.fsf_-_@cisco.com>

On Sun, Feb 11, 2007 at 09:30:21PM -0800, Roland Dreier wrote:
> This patch fixes this by converting dma_{alloc,free}_noncoherent()
> into inline functions that call the corresponding coherent functions,
> instead of trying to do this with macros.
> 
> Signed-off-by: Roland Dreier <rolandd@cisco.com>

Only the "generic" configs were bust, but this patch does the trick
and everything builds and boots again.

Thanks

Acked-by: Tony Luck <tony.luck@intel.com>

> ---
>  include/asm-ia64/dma-mapping.h |   15 +++++++++++++--
>  1 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/include/asm-ia64/dma-mapping.h b/include/asm-ia64/dma-mapping.h
> index ebd5887..6299b51 100644
> --- a/include/asm-ia64/dma-mapping.h
> +++ b/include/asm-ia64/dma-mapping.h
> @@ -8,9 +8,20 @@
>  #include <asm/machvec.h>
>  
>  #define dma_alloc_coherent	platform_dma_alloc_coherent
> -#define dma_alloc_noncoherent	platform_dma_alloc_coherent	/* coherent mem. is cheap */
> +/* coherent mem. is cheap */
> +static inline void *
> +dma_alloc_noncoherent(struct device *dev, size_t size, dma_addr_t *dma_handle,
> +		      gfp_t flag)
> +{
> +	return dma_alloc_coherent(dev, size, dma_handle, flag);
> +}
>  #define dma_free_coherent	platform_dma_free_coherent
> -#define dma_free_noncoherent	platform_dma_free_coherent
> +static inline void
> +dma_free_noncoherent(struct device *dev, size_t size, void *cpu_addr,
> +		     dma_addr_t dma_handle)
> +{
> +	dma_free_coherent(dev, size, cpu_addr, dma_handle);
> +}
>  #define dma_map_single		platform_dma_map_single
>  #define dma_map_sg		platform_dma_map_sg
>  #define dma_unmap_single	platform_dma_unmap_single

      reply	other threads:[~2007-02-12 21:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-10 11:45 [patch] linux/io.h: forward declare struct pci_dev Heiko Carstens
2007-02-11  3:49 ` Christoph Hellwig
2007-02-11  6:26   ` Tejun Heo
2007-02-11  6:34     ` Al Viro
2007-02-11  6:46       ` Tejun Heo
2007-02-11  6:55       ` Randy Dunlap
2007-02-11  7:10       ` Christoph Hellwig
2007-02-11  8:21         ` Al Viro
2007-02-11 15:09       ` Jeff Garzik
2007-02-11 15:31       ` Heiko Carstens
2007-02-11 15:41         ` [PATCH] sort the devres mess out Al Viro
2007-02-11 15:49           ` Jeff Garzik
2007-02-11 22:16             ` Roland Dreier
2007-02-12  5:30               ` [PATCH] ia64: Fix noncoherent DMA API so devres builds Roland Dreier
2007-02-12 21:06                 ` Luck, Tony [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070212210604.GA12991@intel.com \
    --to=tony.luck@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.