From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756069AbZJAJsW (ORCPT ); Thu, 1 Oct 2009 05:48:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756052AbZJAJsW (ORCPT ); Thu, 1 Oct 2009 05:48:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62783 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756049AbZJAJsV (ORCPT ); Thu, 1 Oct 2009 05:48:21 -0400 Date: Thu, 1 Oct 2009 11:45:18 +0200 From: "Michael S. Tsirkin" To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Christian Borntraeger , linux-kernel@vger.kernel.org, Sam Ravnborg , Andrew Morton , Rusty Russell Subject: Re: [PATCH 31/34] move virtrng_remove to .devexit.text Message-ID: <20091001094518.GI5718@redhat.com> References: <20091001082607.GA2181@pengutronix.de> <1254385718-14254-31-git-send-email-u.kleine-koenig@pengutronix.de> <200910011044.48293.borntraeger@de.ibm.com> <20091001091218.GE5718@redhat.com> <20091001093106.GA6386@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20091001093106.GA6386@pengutronix.de> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 01, 2009 at 11:31:06AM +0200, Uwe Kleine-König wrote: > Hello, > > On Thu, Oct 01, 2009 at 11:12:18AM +0200, Michael S. Tsirkin wrote: > > On Thu, Oct 01, 2009 at 10:44:48AM +0200, Christian Borntraeger wrote: > > > Am Donnerstag 01 Oktober 2009 10:28:35 schrieb Uwe Kleine-König: > > > > The function virtrng_remove is used only wrapped by __devexit_p so define > > > > it using __devexit. > > > > > > > > Signed-off-by: Uwe Kleine-König > > > > Acked-by: Sam Ravnborg > > > > Cc: Rusty Russell > > > > Cc: Michael S. Tsirkin > > > > Cc: Christian Borntraeger > > > > > > Acked-by: Christian Borntraeger > > > > FWIW > > Acked-by: Michael S. Tsirkin > ok > > > > It seems that there are similar changes possible in other virtio drivers (e.g. > > > virtio_net). > http://thread.gmane.org/gmane.linux.kernel/896297/focus=896309 > > > Yes, and more importantly drivers/virtio/virtio.c as well. > Hm, I don't see it: > > $ git grep -E '__(dev)?exit_p' linus/master:drivers/virtio/virtio.c > > $ > > Well, you could add something, but adding __devexit is a noop for most > kernels. It matters only if you don't have CONFIG_HOTPLUG. And MODULE. > In this series I only addressed drivers that use __{,dev}exit and > __{,dev}exit_p inconsistenly. I.e. my script greps for __{,dev}exit_p > and checks the prototype of the wrapped function. I have another > script that does a similar check for platform_devices in general. This > one also notices if you have a __devexit function that isn't wrapped by > __devexit_p. Can we teach sparse about this? > So if you want to see drivers/virtio/virtio.c improving, send patches > yourself :-) Here's my reasoning: include/linux/virtio.h defines virtio_driver, and remove pointer there is only used on hot-unplug or module removal. This is the only reason I see that we can make device removal as devexit. So we can make all of them devexit then? > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ |