All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Sukadev Bhattiprolu <sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: arnd-r2nGTMty4D4@public.gmane.org,
	Containers
	<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org,
	Alexey Dobriyan
	<adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	Pavel Emelyanov <xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Subject: Re: [v11][PATCH 8/9] Define clone_with_pids() syscall
Date: Fri, 6 Nov 2009 12:02:10 -0600	[thread overview]
Message-ID: <20091106180210.GA31652__6847.20687936551$1257530614$gmane$org@us.ibm.com> (raw)
In-Reply-To: <20091105054124.GH16142-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Quoting Sukadev Bhattiprolu (sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org):
> +	stack_size = (unsigned long)kca.child_stack_size;
> +	child_stack = (unsigned long)kca.child_stack_base + stack_size;
> +
> +	if (!child_stack)
> +		child_stack = regs->sp;

I'm hooking up the s390 version right now.  Do you think you should
make this

	if (!kca.child_stack_base)
		child_stack = regs->sp;

?

I suppose that in general if I pass in a NULL kca.child_stack_base
I'll also pass in a 0 stacksize, but as a user I'd expect that if
I pass in NULL, the size gets ignored.  Instead, if I pass in NULL
plus a size, then the kernel will take (void *)size as the stacktop.

-serge

  parent reply	other threads:[~2009-11-06 18:02 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05  5:30 [v11][PATCH 0/9] Implement clone_with_pids() system call Sukadev Bhattiprolu
2009-11-05  5:36 ` [v11][PATCH 1/9] Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-11-05  5:37 ` [v11][PATCH 2/9] Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-11-05  5:38 ` [v11][PATCH 3/9] Define set_pidmap() function Sukadev Bhattiprolu
2009-11-05  5:38 ` [v11][PATCH 4/9] Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-11-05  5:39 ` [v11][PATCH 5/9] Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-11-05  5:40 ` [v11][PATCH 6/9] Check invalid clone flags Sukadev Bhattiprolu
2009-11-05  5:40 ` [v11][PATCH 7/9] Define do_fork_with_pids() Sukadev Bhattiprolu
     [not found] ` <20091105053053.GA11289-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-05  5:36   ` [v11][PATCH 1/9] Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-11-05  5:37   ` [v11][PATCH 2/9] Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-11-05  5:38   ` [v11][PATCH 3/9] Define set_pidmap() function Sukadev Bhattiprolu
2009-11-05  5:38   ` [v11][PATCH 4/9] Add target_pids parameter to alloc_pid() Sukadev Bhattiprolu
2009-11-05  5:39   ` [v11][PATCH 5/9] Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-11-05  5:40   ` [v11][PATCH 6/9] Check invalid clone flags Sukadev Bhattiprolu
2009-11-05  5:40   ` [v11][PATCH 7/9] Define do_fork_with_pids() Sukadev Bhattiprolu
2009-11-05  5:41   ` [v11][PATCH 8/9] Define clone_with_pids() syscall Sukadev Bhattiprolu
2009-11-05  5:42   ` [v11][PATCH 9/9] Document " Sukadev Bhattiprolu
2009-11-05  5:41 ` [v11][PATCH 8/9] Define " Sukadev Bhattiprolu
2009-11-06 18:02   ` Serge E. Hallyn
     [not found]     ` <20091106180210.GA31652-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-07 20:18       ` Sukadev Bhattiprolu
2009-11-07 20:18     ` Sukadev Bhattiprolu
     [not found]   ` <20091105054124.GH16142-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-06 18:02     ` Serge E. Hallyn [this message]
2009-11-09 20:37     ` Serge E. Hallyn
2009-11-09 20:37   ` Serge E. Hallyn
2009-11-09 20:37     ` Serge E. Hallyn
2009-11-05  5:42 ` [v11][PATCH 9/9] Document " Sukadev Bhattiprolu
     [not found]   ` <20091105054204.GI16142-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-06 18:39     ` Serge E. Hallyn
2009-11-06 18:39   ` Serge E. Hallyn
2009-11-06 20:18     ` Matt Helsley
2009-11-06 21:45       ` Matt Helsley
2009-11-07  2:26         ` Sukadev Bhattiprolu
2009-11-07 21:56           ` Oren Laadan
     [not found]             ` <4AF5ECFD.3000509-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org>
2009-11-08 15:09               ` Serge E. Hallyn
2009-11-08 15:09             ` Serge E. Hallyn
2009-11-07 21:56           ` Oren Laadan
     [not found]         ` <20091106214529.GB26614-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-11-07  2:26           ` Sukadev Bhattiprolu
     [not found]       ` <20091106201814.GA26614-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2009-11-06 21:45         ` Matt Helsley
     [not found]     ` <20091106183936.GA32531-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-11-06 20:18       ` Matt Helsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20091106180210.GA31652__6847.20687936551$1257530614$gmane$org@us.ibm.com' \
    --to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=adobriyan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.