All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch] net/sctp/sysctl.c: Remove dead strategy handler
Date: Tue, 8 Dec 2009 20:52:09 +0100	[thread overview]
Message-ID: <20091208195209.GA30947@elte.hu> (raw)
In-Reply-To: <20091208194530.GA24530@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> hi Dave,
> 
> i just switched to today's -git tree and there's this new build failure 
> on x86:
> 
>  net/sctp/sysctl.c:251: error: unknown field 'strategy' specified in initializer
>  net/sctp/sysctl.c:251: error: 'sysctl_intvec' undeclared here (not in a function)
> 
> havent looked into it yet - config attached.

That's interaction with the strategy handler removal from Eric. I think 
the patch below will do the trick - the callsites have been updated 
already to use proc_handler, so ->handler was a dead field.

	Ingo

Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
index 419e1e9..832590b 100644
--- a/net/sctp/sysctl.c
+++ b/net/sctp/sysctl.c
@@ -248,7 +248,6 @@ static ctl_table sctp_table[] = {
 		.maxlen		= sizeof(int),
 		.mode		= 0644,
 		.proc_handler	= &proc_dointvec_minmax,
-		.strategy	= &sysctl_intvec,
 		.extra1		= &one,
 		.extra2		= &rwnd_scale_max,
 	},

  reply	other threads:[~2009-12-08 19:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-06  3:35 [GIT]: Networking David Miller
2009-12-08 19:45 ` Ingo Molnar
2009-12-08 19:52   ` Ingo Molnar [this message]
2009-12-08 20:50   ` David Miller
2009-12-09  1:54     ` Eric W. Biederman
2009-12-08 20:51   ` Linus Torvalds
2009-12-08 20:52     ` David Miller
2009-12-14  4:17 ` andrew hendry
2009-12-14  4:17   ` andrew hendry
2009-12-14  4:20   ` David Miller
2009-12-14  4:26     ` andrew hendry
2009-12-14  4:35       ` David Miller
2009-12-14 11:53       ` Arnd Bergmann
2009-12-14 22:07         ` andrew hendry
2009-12-15  5:51           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091208195209.GA30947@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.