From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:57615 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753199Ab0DGWTp (ORCPT ); Wed, 7 Apr 2010 18:19:45 -0400 Date: Wed, 7 Apr 2010 23:19:41 +0100 From: Al Viro To: Linus Torvalds Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Maciej Rutecki , Andrew Morton , Kernel Testers List , Network Development , Linux ACPI , Linux PM List , Linux SCSI List , Linux Wireless List , DRI Subject: Re: 2.6.34-rc3-git6: Reported regressions from 2.6.33 Message-ID: <20100407221941.GL30031@ZenIV.linux.org.uk> References: <6Pphclm24fK.A.lSF.qsPvLB@chimera> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Apr 07, 2010 at 03:04:46PM -0700, Linus Torvalds wrote: > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15674 > > Subject : [2.6.34-rc2 NFS4 oops] open error path failure... > > Submitter : Daniel J Blueman > > Date : 2010-03-29 18:36 (10 days old) > > Message-ID : <6278d2221003291136p6481fe8emfb039403343c082@mail.gmail.com> > > References : http://marc.info/?l=linux-kernel&m=126988782722711&w=2 > > This smells like the same LOOKUP_DIRECTORY thing as the first entry, but.. No, it's not the same thing; the fix is to have nfs ->d_revalidate() return an error on failing open attempt (in insane codepath that has ->d_revalidate() handling open()). Confirmed to work by reporter... diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index d79a7b3..fe0cd9e 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2068,8 +2068,7 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st case -EDQUOT: case -ENOSPC: case -EROFS: - lookup_instantiate_filp(nd, (struct dentry *)state, NULL); - return 1; + return PTR_ERR(state); default: goto out_drop; } From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: 2.6.34-rc3-git6: Reported regressions from 2.6.33 Date: Wed, 7 Apr 2010 23:19:41 +0100 Message-ID: <20100407221941.GL30031@ZenIV.linux.org.uk> References: <6Pphclm24fK.A.lSF.qsPvLB@chimera> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Torvalds Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Maciej Rutecki , Andrew Morton , Kernel Testers List , Network Development , Linux ACPI , Linux PM List , Linux SCSI List , Linux Wireless List , DRI List-Id: linux-acpi@vger.kernel.org On Wed, Apr 07, 2010 at 03:04:46PM -0700, Linus Torvalds wrote: > > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=15674 > > Subject : [2.6.34-rc2 NFS4 oops] open error path failure... > > Submitter : Daniel J Blueman > > Date : 2010-03-29 18:36 (10 days old) > > Message-ID : <6278d2221003291136p6481fe8emfb039403343c082-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> > > References : http://marc.info/?l=linux-kernel&m=126988782722711&w=2 > > This smells like the same LOOKUP_DIRECTORY thing as the first entry, but.. No, it's not the same thing; the fix is to have nfs ->d_revalidate() return an error on failing open attempt (in insane codepath that has ->d_revalidate() handling open()). Confirmed to work by reporter... diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index d79a7b3..fe0cd9e 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2068,8 +2068,7 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st case -EDQUOT: case -ENOSPC: case -EROFS: - lookup_instantiate_filp(nd, (struct dentry *)state, NULL); - return 1; + return PTR_ERR(state); default: goto out_drop; }