All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Yinghai Lu <yinghai.lu@oracle.com>
Cc: Graham Ramsey <ramsey.graham@ntlworld.com>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	bugzilla-daemon@bugzilla.kernel.org,
	Myron Stowe <myron.stowe@hp.com>,
	Robert Richter <robert.richter@amd.com>,
	Harald Welte <HaraldWelte@viatech.com>,
	Joseph Chan <JosephChan@via.com.tw>
Subject: Re: [Bug 16007] x86/pci Oops with CONFIG_SND_HDA_INTEL
Date: Mon, 21 Jun 2010 11:28:11 -0600	[thread overview]
Message-ID: <201006211128.12889.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <4C12C189.50201@oracle.com>

I think the best long-term fix is to always enable "pci=use_crs",
regardless of the BIOS date (currently we only do it for 2008 and
newer).  System designers and BIOS writers expect the OS to pay
attention to that information, and indications are that Windows
does use it, so I think we will ultimately be better off if we
use the expected, best-tested path.

However, we have at least one known Linux issue (bug #16228) when
_CRS is enabled, so I'm hesitant to enable it unconditionally at
least until that is resolved.

In the short term, I think we should apply Graham's quirk from
comment #8, which enables pci=use_crs just for his system.

Here's my response to Yinghai's patches.  ACPI gives us these resources:
  pci_root PNP0A03:00: host bridge window [mem 0x80000000-0xff37ffff] (bus 00)
  pci_root PNP0A08:00: host bridge window [mem 0xfebfc000-0xfebfffff] (bus 80)

Yinghai's patch (comment #17, with a v2 posted to the list but not in
the bugzilla), gives us these resources:
  pci_bus 0000:00: resource 5 [mem 0x80000000-0xfcffffffff]
  pci_bus 0000:80: resource 5 [mem 0x80000000-0xfcffffffff]

I think it's just a bad idea to assign the same range to both buses,
especially when the BIOS is telling us what we should be using.

I also think it's a mistake to mess with the resource code to deal
with this specific case.  A change like that makes resource.c hard
to understand and maintain in the future.

  parent reply	other threads:[~2010-06-21 17:27 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 15:13 x86/pci Oops with CONFIG_SND_HDA_INTEL Graham Ramsey
2010-05-19 16:44 ` Bjorn Helgaas
2010-05-19 17:16   ` Graham Ramsey
2010-05-19 18:01     ` Yinghai
2010-05-19 22:47       ` Graham Ramsey
2010-05-20  0:03         ` Yinghai
2010-05-20  0:22           ` Jesse Barnes
2010-05-20  0:36             ` Yinghai
2010-05-20 17:08               ` [Bug 16007] " Bjorn Helgaas
2010-06-02 16:58                 ` Bjorn Helgaas
2010-06-11 21:49                   ` Bjorn Helgaas
2010-06-11 22:08                     ` Yinghai Lu
2010-06-11 23:06                     ` Yinghai Lu
2010-06-14 14:18                       ` Bjorn Helgaas
2010-06-14 17:47                       ` [PATCH -v2] x86, pci: Handle fallout pci devices with peer root bus Yinghai Lu
2010-06-14 18:14                         ` Jesse Barnes
2010-06-14 18:22                           ` Yinghai Lu
2010-06-14 18:34                         ` Bjorn Helgaas
2010-06-14 18:39                           ` H. Peter Anvin
2010-06-14 18:55                             ` Yinghai Lu
2010-06-14 20:00                               ` Bjorn Helgaas
2010-06-14 20:08                                 ` H. Peter Anvin
2010-06-14 20:20                                   ` Bjorn Helgaas
2010-06-14 21:10                                     ` H. Peter Anvin
2010-06-15  1:49                                       ` Bjorn Helgaas
2010-06-15  1:56                                         ` H. Peter Anvin
2010-06-15 15:30                                           ` Bjorn Helgaas
2010-06-14 19:43                             ` Bjorn Helgaas
2010-06-21 17:28                       ` Bjorn Helgaas [this message]
2010-06-13 14:45 2.6.35-rc3: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-06-13 14:49 ` [Bug #16007] x86/pci Oops with CONFIG_SND_HDA_INTEL Rafael J. Wysocki
2010-06-13 14:49   ` Rafael J. Wysocki
2010-06-20 22:32 2.6.35-rc3: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-06-20 22:34 ` [Bug #16007] x86/pci Oops with CONFIG_SND_HDA_INTEL Rafael J. Wysocki
2010-07-10  0:24 2.6.35-rc4-git4: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-07-10  0:33 ` [Bug #16007] x86/pci Oops with CONFIG_SND_HDA_INTEL Rafael J. Wysocki
2010-07-23 12:11 2.6.35-rc6: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-07-23 12:15 ` [Bug #16007] x86/pci Oops with CONFIG_SND_HDA_INTEL Rafael J. Wysocki
2010-07-23 12:15   ` Rafael J. Wysocki
2010-07-23 14:20   ` Bjorn Helgaas
2010-07-23 19:51     ` Rafael J. Wysocki
2010-08-01 14:27 2.6.35-rc6-git6: Reported regressions 2.6.33 -> 2.6.34 Rafael J. Wysocki
2010-08-01 14:44 ` [Bug #16007] x86/pci Oops with CONFIG_SND_HDA_INTEL Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201006211128.12889.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=HaraldWelte@viatech.com \
    --cc=JosephChan@via.com.tw \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=myron.stowe@hp.com \
    --cc=ramsey.graham@ntlworld.com \
    --cc=robert.richter@amd.com \
    --cc=yinghai.lu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.