All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org, t.artem@mailcity.com
Subject: Re: [PATCH] drm/agp/i915: trim stolen space to 32M
Date: Thu, 8 Jul 2010 09:15:04 -0700	[thread overview]
Message-ID: <20100708091504.1e7a7e86@virtuousgeek.org> (raw)
In-Reply-To: <20100708090144.22b5cb28@virtuousgeek.org>

On Thu, 8 Jul 2010 09:01:44 -0700
Jesse Barnes <jbarnes@virtuousgeek.org> wrote:

> On Thu, 8 Jul 2010 10:58:21 +0100
> Simon Farnsworth <simon.farnsworth@onelan.com> wrote:
> 
> > On Wednesday 7 July 2010, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > > Some BIOSes will claim a large chunk of stolen space.  Unless we
> > > reclaim it, our aperture for remapping buffer objects will be
> > > constrained.  So clamp the stolen space to 32M and ignore the rest.
> > > 
> > I'm not sure that this changelog fits the patch - if I'm understanding the code 
> > correctly, you're clamping to 16M, not 32M.
> > 
> > Apart from that, the code looks sensible.
> 
> Oops updated to 32M for Ironlake but didn't update the changelog or
> comments.

Oh and I see you were trying to tell me that I failed to update the
code too.  Sigh.

I'll post an updated version with the code and comments fixed.

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2010-07-08 16:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07 21:40 [PATCH] drm/agp/i915: trim stolen space to 32M Jesse Barnes
2010-07-08  9:58 ` Simon Farnsworth
2010-07-08 16:01   ` Jesse Barnes
2010-07-08 16:15     ` Jesse Barnes [this message]
2010-07-08 16:22 Jesse Barnes
2010-07-08 16:37 ` Simon Farnsworth
2010-07-08 16:42   ` Chris Wilson
2010-07-08 16:52     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100708091504.1e7a7e86@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=t.artem@mailcity.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.