From: Ken CC <ken.ccao@gmail.com>
To: kvm@vger.kernel.org
Cc: yamahata@valinux.co.jp, qemu-devel@nongnu.org
Subject: [PATCH 2/3] pci init: fail qemu if devfn exceeding the max devices number supported on bus
Date: Tue, 24 Aug 2010 14:48:41 +0800 [thread overview]
Message-ID: <20100824064841.GA11495@kt> (raw)
In-Reply-To: <20100824063307.GA10815@kt>
assert(devfn < PCIBUS_MAX_DEVICES)
Signed-off-by: Ken CC <ken.ccao@gmail.com>
---
hw/pci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 02019a1..1e804da 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -747,6 +747,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
PCIConfigWriteFunc *config_write,
bool is_bridge)
{
+ assert(devfn < PCIBUS_MAX_DEVICES);
if (devfn < 0) {
for(devfn = bus->devfn_min ; devfn < ARRAY_SIZE(bus->devices);
devfn += PCI_FUNC_MAX) {
WARNING: multiple messages have this Message-ID (diff)
From: Ken CC <ken.ccao@gmail.com>
To: kvm@vger.kernel.org
Cc: yamahata@valinux.co.jp, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/3] pci init: fail qemu if devfn exceeding the max devices number supported on bus
Date: Tue, 24 Aug 2010 14:48:41 +0800 [thread overview]
Message-ID: <20100824064841.GA11495@kt> (raw)
In-Reply-To: <20100824063307.GA10815@kt>
assert(devfn < PCIBUS_MAX_DEVICES)
Signed-off-by: Ken CC <ken.ccao@gmail.com>
---
hw/pci.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 02019a1..1e804da 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -747,6 +747,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
PCIConfigWriteFunc *config_write,
bool is_bridge)
{
+ assert(devfn < PCIBUS_MAX_DEVICES);
if (devfn < 0) {
for(devfn = bus->devfn_min ; devfn < ARRAY_SIZE(bus->devices);
devfn += PCI_FUNC_MAX) {
next prev parent reply other threads:[~2010-08-24 6:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 6:33 [PATCH 1/3] PCI: define max devices number on PCIBus as PCIBUS_MAX_DEVICES in pci.h Ken CC
2010-08-24 6:33 ` [Qemu-devel] " Ken CC
2010-08-24 6:48 ` Ken CC [this message]
2010-08-24 6:48 ` [Qemu-devel] [PATCH 2/3] pci init: fail qemu if devfn exceeding the max devices number supported on bus Ken CC
2010-08-24 6:49 ` [PATCH 3/3] Check pci slot number in parse_pci_devfn Ken CC
2010-08-24 6:49 ` [Qemu-devel] " Ken CC
2010-08-24 11:35 ` Isaku Yamahata
2010-08-24 11:35 ` Isaku Yamahata
2010-08-24 11:42 ` Avi Kivity
2010-08-24 11:42 ` Avi Kivity
2010-08-24 12:07 ` Isaku Yamahata
2010-08-24 12:07 ` Isaku Yamahata
2010-08-24 12:04 ` Avi Kivity
2010-08-24 12:04 ` Avi Kivity
2010-08-24 12:16 ` Chen Cao
2010-08-24 12:16 ` Chen Cao
2010-08-24 12:19 ` Avi Kivity
2010-08-24 12:19 ` Avi Kivity
2010-08-24 12:24 ` Isaku Yamahata
2010-08-24 12:24 ` Isaku Yamahata
2010-08-24 12:16 ` Avi Kivity
2010-08-24 12:16 ` Avi Kivity
[not found] <20100824062517.12408.45246.stgit@k1>
2010-08-24 6:33 ` [PATCH 2/3] pci init: fail qemu if devfn exceeding the max devices number supported on bus Ken CC
2010-08-24 6:51 ` Ken CC
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824064841.GA11495@kt \
--to=ken.ccao@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.