All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dan Murphy <dmurphy@ti.com>
Cc: linux-omap@vger.kernel.org, b-cousson@ti.com, paul@pwsan.com,
	khilman@deeprootsystems.com
Subject: Re: [PATCH] OMAP MUX framework changes
Date: Thu, 18 Nov 2010 09:57:14 -0800	[thread overview]
Message-ID: <20101118175714.GF9264@atomide.com> (raw)
In-Reply-To: <1290017211-2217-1-git-send-email-dmurphy@ti.com>

Hi Dan,

* Dan Murphy <dmurphy@ti.com> [101117 09:58]:
> @@ -81,10 +81,14 @@ void omap_mux_write(struct omap_mux_partition *partition, u16 val,
>  void omap_mux_write_array(struct omap_mux_partition *partition,
>  				 struct omap_board_mux *board_mux)
>  {
> -	while (board_mux->reg_offset != OMAP_MUX_TERMINATOR) {
> -		omap_mux_write(partition, board_mux->value,
> -			       board_mux->reg_offset);
> -		board_mux++;
> +	if (partition) {
> +		while (board_mux->reg_offset != OMAP_MUX_TERMINATOR) {
> +			omap_mux_write(partition, board_mux->value,
> +				       board_mux->reg_offset);
> +			board_mux++;
> +		}
> +	} else {
> +		pr_err("%s: Partition was NULL\n", __func__);
>  	}
>  }
>  

Can you please make this into a separate patch. And instead of
indenting the code more, just do something like:

	if (!partition)
		return -EINVAL;

Regards,

Tony

  reply	other threads:[~2010-11-18 17:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17 18:06 [PATCH] OMAP MUX framework changes Dan Murphy
2010-11-18 17:57 ` Tony Lindgren [this message]
2010-11-18 21:01   ` Cousson, Benoit
2010-11-18 21:29     ` Tony Lindgren
2010-11-19 17:47 ` Tony Lindgren
2010-12-02 22:02   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118175714.GF9264@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=dmurphy@ti.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.