From: Han Pingtian <phan@redhat.com>
To: acme@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] perf test: check if cpu_map__new() return NULL
Date: Sat, 15 Jan 2011 07:00:50 +0800 [thread overview]
Message-ID: <20110114230050.GA7011@localhost> (raw)
It looks like we should check if cpus is NULL after
cpus = cpu_map__new(NULL);
in test__open_syscall_event_on_all_cpus().
Signed-off-by: Han Pingtian <phan@redhat.com>
---
tools/perf/builtin-test.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-test.c b/tools/perf/builtin-test.c
index 419ce20..e7f098b 100644
--- a/tools/perf/builtin-test.c
+++ b/tools/perf/builtin-test.c
@@ -348,8 +348,8 @@ static int test__open_syscall_event_on_all_cpus(void)
}
cpus = cpu_map__new(NULL);
- if (threads == NULL) {
- pr_debug("thread_map__new\n");
+ if (cpus == NULL) {
+ pr_debug("cpu_map__new\n");
return -1;
}
--
1.7.3.4
next reply other threads:[~2011-01-14 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 23:00 Han Pingtian [this message]
2011-01-15 13:03 ` [PATCH] perf test: check if cpu_map__new() return NULL Arnaldo Carvalho de Melo
2011-01-26 7:19 ` [tip:perf/core] " tip-bot for Han Pingtian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114230050.GA7011@localhost \
--to=phan@redhat.com \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.