All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Borislav Petkov <bp@amd64.org>
Cc: "peterz@infradead.org" <peterz@infradead.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"fweisbec@gmail.com" <fweisbec@gmail.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 08/12] perf: Carve out mmap helpers for general use
Date: Mon, 24 Jan 2011 10:39:36 -0200	[thread overview]
Message-ID: <20110124123936.GC5932@ghostprotocols.net> (raw)
In-Reply-To: <20110124090410.GA8924@aftab>

Em Mon, Jan 24, 2011 at 10:04:10AM +0100, Borislav Petkov escreveu:
> Ok, I see at least one problem with my patch - you've reworked the
> mmaping functionality in evlist.c/evsel.c and I should use it too, I
> guess. For that, I think you'd want me to apply my stuff ontop of your
> perf/core branch, right?

Right, I hope to have that branch merged by Ingo soon.
 
> Am I missing something else?

Nope, you're not. Doing that we erode your patchset a bit, reducing its
size.

One related experience I'm doing now is to have a perf.so python
binding, the setup.py file for it with the list of files needed for this
specific binding is at:

http://userweb.kernel.org/~acme/setup.py

A simple tool using the resulting binding is a thread
fork/comm/exit/sample watcher, available at:

http://userweb.kernel.org/~acme/twatch

In this process I'm moving functions around so as to reduce the number
of tools/perf/util.c files to link into this perf.so python binding,
untangling things as much as possible.

The binding proper is:

http://userweb.kernel.org/~acme/python.c

I'm digressing, but twatch is an example of a simple "daemon" consuming
perf events where performance is not much of a problem.

And provides a prototyping ground when starting to design perf events
consuming daemons :-)

- Arnaldo

  reply	other threads:[~2011-01-24 12:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-21 15:09 [RFC PATCHSET 0/12] RAS daemon v4 Borislav Petkov
2011-01-21 15:09 ` [PATCH 01/12] perf: Start the massive restructuring Borislav Petkov
2011-01-21 15:09 ` [PATCH 02/12] perf: Add persistent event facilities Borislav Petkov
2011-01-21 15:09 ` [PATCH 03/12] x86, mce: Add persistent MCE event Borislav Petkov
2011-01-21 15:09 ` [PATCH 04/12] perf: Add Makefile.lib Borislav Petkov
2011-01-21 15:09 ` [PATCH 05/12] perf: Export trace-event utils Borislav Petkov
2011-01-21 15:09 ` [PATCH 06/12] perf: Remove duplicate enum trace_flag_type Borislav Petkov
2011-01-21 15:09 ` [PATCH 07/12] perf: Export debugfs utilities Borislav Petkov
2011-01-21 15:09 ` [PATCH 08/12] perf: Carve out mmap helpers for general use Borislav Petkov
2011-01-21 17:29   ` Arnaldo Carvalho de Melo
2011-01-24  9:04     ` Borislav Petkov
2011-01-24 12:39       ` Arnaldo Carvalho de Melo [this message]
2011-01-26  1:00         ` Borislav Petkov
2011-01-26 13:13           ` Arnaldo Carvalho de Melo
2011-01-21 15:09 ` [PATCH 09/12] perf: Export util.ch into library Borislav Petkov
2011-01-21 15:09 ` [PATCH 10/12] perf: Export ctype.c Borislav Petkov
2011-01-21 15:09 ` [PATCH 11/12] perf: Export tracepoint_id_to_path Borislav Petkov
2011-01-21 15:09 ` [PATCH] ras: Add RAS daemon Borislav Petkov
2011-01-21 17:54   ` Tony Luck
2011-01-21 18:06     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110124123936.GC5932@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=bp@amd64.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.