All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	mingo@redhat.com, linux-fsdevel@vger.kernel.org,
	akpm@linux-foundation.org, linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 3/6] PM: use appropriate printk priority level
Date: Mon, 31 Jan 2011 11:12:29 +0100	[thread overview]
Message-ID: <201101311112.29528.rjw__34781.6571746536$1296468953$gmane$org@sisk.pl> (raw)
In-Reply-To: <1296084570-31453-4-git-send-email-msb@chromium.org>

On Thursday, January 27, 2011, Mandeep Singh Baines wrote:
> printk()s without a priority level default to KERN_WARNING. To reduce
> noise at KERN_WARNING, this patch set the priority level appriopriately
> for unleveled printks()s. This should be useful to folks that look at
> dmesg warnings closely.
> 
> Changed these messages to pr_info. But might be more appropriate as
> pr_debug.
> 
> Signed-off-by: Mandeep Singh Baines <msb@chromium.org>

Applied to suspend-2.6/linux-next.

Thanks,
Rafael


> ---
>  drivers/base/power/trace.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c
> index 9f4258d..c80e138 100644
> --- a/drivers/base/power/trace.c
> +++ b/drivers/base/power/trace.c
> @@ -112,7 +112,7 @@ static unsigned int read_magic_time(void)
>  	unsigned int val;
>  
>  	get_rtc_time(&time);
> -	printk("Time: %2d:%02d:%02d  Date: %02d/%02d/%02d\n",
> +	pr_info("Time: %2d:%02d:%02d  Date: %02d/%02d/%02d\n",
>  		time.tm_hour, time.tm_min, time.tm_sec,
>  		time.tm_mon + 1, time.tm_mday, time.tm_year % 100);
>  	val = time.tm_year;				/* 100 years */
> @@ -179,7 +179,7 @@ static int show_file_hash(unsigned int value)
>  		unsigned int hash = hash_string(lineno, file, FILEHASH);
>  		if (hash != value)
>  			continue;
> -		printk("  hash matches %s:%u\n", file, lineno);
> +		pr_info("  hash matches %s:%u\n", file, lineno);
>  		match++;
>  	}
>  	return match;
> @@ -255,7 +255,7 @@ static int late_resume_init(void)
>  	val = val / FILEHASH;
>  	dev = val /* % DEVHASH */;
>  
> -	printk("  Magic number: %d:%d:%d\n", user, file, dev);
> +	pr_info("  Magic number: %d:%d:%d\n", user, file, dev);
>  	show_file_hash(file);
>  	show_dev_hash(dev);
>  	return 0;
> 

  reply	other threads:[~2011-01-31 10:12 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 23:57 [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig Mandeep Singh Baines
2011-01-26  0:40 ` Joe Perches
2011-01-26  1:01   ` Mandeep Singh Baines
2011-01-26  1:15     ` Joe Perches
2011-01-26  4:18 ` WANG Cong
2011-01-26 23:05   ` Mandeep Baines
2011-01-27  5:49     ` WANG Cong
2011-01-26 22:49 ` Andrew Morton
2011-01-26 22:57   ` Randy Dunlap
2011-01-26 23:10     ` Andrew Morton
2011-01-27  7:26       ` WANG Cong
2011-01-27  8:27       ` Alexey Dobriyan
2011-01-27 15:57         ` Mandeep Singh Baines
2011-01-27 20:45           ` Ryan Mallon
2011-01-27 20:53             ` Alexey Dobriyan
2011-01-27 20:57               ` Ryan Mallon
2011-01-26 23:29 ` [PATCH v1 0/6] Set printk priority level Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-27  7:22   ` WANG Cong
2011-01-27  7:22     ` WANG Cong
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 1/6] mm/page_alloc: use appropriate " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-27  0:32   ` Ryan Mallon
2011-01-27  0:32   ` Ryan Mallon
2011-01-27  0:32     ` Ryan Mallon
2011-01-27  4:22     ` Mandeep Singh Baines
2011-01-27  4:22     ` Mandeep Singh Baines
2011-01-27  4:22       ` Mandeep Singh Baines
2011-01-27 20:32       ` Ryan Mallon
2011-01-27 20:32       ` Ryan Mallon
2011-01-27 20:32         ` Ryan Mallon
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 2/6] arch/x86: " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 3/6] PM: " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-31 10:12   ` Rafael J. Wysocki [this message]
2011-01-31 10:12   ` Rafael J. Wysocki
2011-01-31 10:12     ` Rafael J. Wysocki
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 4/6] TTY: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-02-03 22:13   ` Greg KH
2011-02-03 22:13     ` Greg KH
2011-02-06 17:31     ` [PATCH v2] " Mandeep Singh Baines
2011-02-06 17:31     ` Mandeep Singh Baines
2011-02-06 17:31       ` Mandeep Singh Baines
2011-02-03 22:13   ` [PATCH 4/6] " Greg KH
2011-01-26 23:29 ` [PATCH 5/6] fs: " Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29 ` [PATCH 6/6] taskstats: " Mandeep Singh Baines
2011-01-26 23:29 ` Mandeep Singh Baines
2011-01-26 23:29   ` Mandeep Singh Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='201101311112.29528.rjw__34781.6571746536$1296468953$gmane$org@sisk.pl' \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@redhat.com \
    --cc=msb@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.