All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Ingo Molnar <mingo@elte.hu>, Len Brown <lenb@kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Luming Yu <luming.yu@intel.com>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH upstream build breakage] acpi: several drivers depend on NET
Date: Mon, 28 Feb 2011 21:37:15 +0100	[thread overview]
Message-ID: <201102282137.15390.rjw@sisk.pl> (raw)
In-Reply-To: <20110228090332.9ffe2087.randy.dunlap@oracle.com>

On Monday, February 28, 2011, Randy Dunlap wrote:
> On Tue, 1 Feb 2011 13:03:23 +0100 Ingo Molnar wrote:
> 
> > * Ingo Molnar <mingo@elte.hu> wrote:
> > 
> > > * Randy Dunlap <randy.dunlap@oracle.com> wrote:
> > > 
> > > > On Mon, 20 Dec 2010 20:00:13 +1100 Stephen Rothwell wrote:
> > > > 
> > > > > Hi all,
> > > > > 
> > > > > [The mirroring on kernel.org is running slowly]
> > > > > 
> > > > > Changes since 20101217:
> > > > 
> > > > ERROR: "thermal_cooling_device_register" [drivers/acpi/video.ko] undefined!
> > > > ERROR: "thermal_cooling_device_unregister" [drivers/acpi/video.ko] undefined!
> > > 
> > > This bug has been reported two months ago, one month ago, it has been ignored twice 
> > > and now the bug has been pushed upstream and it's triggering there as well.
> > > 
> > > What's going on?
> > 
> > *Tap*, *tap*, is this thing on? :)
> > 
> > acpi-video is still build-broken upstream, as of .38-rc3:
> > 
> >    MODPOST 651 modules
> >  ERROR: "thermal_cooling_device_register" [drivers/acpi/video.ko] undefined!
> >  ERROR: "thermal_cooling_device_unregister" [drivers/acpi/video.ko] undefined!
> >  WARNING: modpost: Found 37 section mismatch(es).
> >  To see full details build your kernel with:
> >  'make CONFIG_DEBUG_SECTION_MISMATCH=y'
> >  make[1]: *** [__modpost] Error 1
> >  make: *** [modules] Error 2
> > 
> > Triggers in about 10% of all randconfig builds. Config attached.
> 
> 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Several ACPI drivers select THERMAL, but THERMAL depends on NET
> (for netlink).  Fix build breakage by making the ACPI drivers
> also depend on NET.

Well, making ACPI_FAN depend on NET seems to be a kind of an overstretch to me.
A proper fix would be to disable the netlink interface in THERMAL when
NET is unset, I guess.  I'll see what can be done to that end (although I had
hoped that the people who introduced the breakage would handle it).

Thanks,
Rafael


> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  drivers/acpi/Kconfig |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> This is what is needed to fix the breakage, but it seems
> that Len does not care.
> It would be better just to eliminate the netlink dependency.
> 
> 
> --- linux-next-20110228.orig/drivers/acpi/Kconfig
> +++ linux-next-20110228/drivers/acpi/Kconfig
> @@ -163,7 +163,7 @@ config ACPI_BUTTON
>  config ACPI_VIDEO
>  	tristate "Video"
>  	depends on X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL
> -	depends on INPUT
> +	depends on INPUT && NET
>  	select THERMAL
>  	help
>  	  This driver implements the ACPI Extensions For Display Adapters
> @@ -177,6 +177,7 @@ config ACPI_VIDEO
>  
>  config ACPI_FAN
>  	tristate "Fan"
> +	depends on NET
>  	select THERMAL
>  	default y
>  	help
> @@ -195,6 +196,7 @@ config ACPI_DOCK
>  
>  config ACPI_PROCESSOR
>  	tristate "Processor"
> +	depends on NET
>  	select THERMAL
>  	select CPU_IDLE
>  	default y
> @@ -238,7 +240,7 @@ config ACPI_PROCESSOR_AGGREGATOR
>  
>  config ACPI_THERMAL
>  	tristate "Thermal Zone"
> -	depends on ACPI_PROCESSOR
> +	depends on ACPI_PROCESSOR && NET
>  	select THERMAL
>  	default y
>  	help
> 
> 

  reply	other threads:[~2011-02-28 20:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20  9:00 linux-next: Tree for December 20 Stephen Rothwell
2010-12-20 16:14 ` Zimny Lech
2010-12-20 20:49   ` Stephen Rothwell
2010-12-20 16:53 ` linux-next: Tree for December 20 (acpi_video) Randy Dunlap
2011-01-26 11:42   ` Ingo Molnar
2011-02-01 12:03     ` [upstream build breakage] " Ingo Molnar
2011-02-01 19:17       ` [PATCH] gpu/stub: fix acpi_video build error, fix stub kconfig dependencies Randy Dunlap
2011-02-02  1:35         ` Ingo Molnar
2011-02-28 17:03       ` [PATCH upstream build breakage] acpi: several drivers depend on NET Randy Dunlap
2011-02-28 20:37         ` Rafael J. Wysocki [this message]
2011-02-28 22:42           ` Rafael J. Wysocki
2011-03-01  0:00             ` Randy Dunlap
2011-03-01  0:12               ` Rafael J. Wysocki
2011-03-01  6:17                 ` [build fix] ACPI: Fix build for CONFIG_NET unset Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102282137.15390.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=luming.yu@intel.com \
    --cc=mingo@elte.hu \
    --cc=randy.dunlap@oracle.com \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.