From: jocke@holstenhof.se (Joachim Holst)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Putting artificial delays in a char driver
Date: Thu, 19 May 2011 14:30:18 +0200 [thread overview]
Message-ID: <201105191430.19320.jocke@holstenhof.se> (raw)
In-Reply-To: <BANLkTinMixUbdoXE04TEiO78ssX4fHeBUw@mail.gmail.com>
On Thursday 19 May 2011 13:30:33 Mandeep Sandhu wrote:
> Hi All,
>
> Whats the recommended way of solving this issue? I'm working on
> drivers after a really long time (last time I worked on a driver was
> when LDD 2nd ed was published!) so I'm not sure if bottom-halves or
> work-queues should be used.
Regarding bottom/top halves, modern 2.6 kernels have so called threaded
interrupts. This basically means that when an IRQ is triggered, the ISR is
already executing in a thread. So, if you use threaded IRQ's you don't quite
have to worry about bottom/top halves of old. You can even use mutexes (not
spinlocks) in the ISR. I believe that the threaded interrupts will generate
some small delay before the ISR is executed, but if memory serves me right
it's basically too small to matter in the most cases.
May the list correct me if I'm wrong...
>
> I was thinking what if I introduce an artificial delay in my driver
> where I "sleep/wait" for a few millsecs after switching on the LED and
> then switch it off after the incoming data has been processed. Is that
> a good idea?
I think that the solution described by Felix Varghese, is a quite good
solution. By triggering the timer in the ISR function, it will be lit
constantly if there is very much IR communications going on.
BRs,
/Jocke!
next prev parent reply other threads:[~2011-05-19 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 11:30 Putting artificial delays in a char driver Mandeep Sandhu
2011-05-19 11:51 ` Felix Varghese
2011-05-20 6:40 ` Mandeep Sandhu
2011-05-19 12:30 ` Joachim Holst [this message]
2011-05-20 6:43 ` Mandeep Sandhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105191430.19320.jocke@holstenhof.se \
--to=jocke@holstenhof.se \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.