All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Damien Wyart <damien.wyart@free.fr>, Ingo Molnar <mingo@elte.hu>,
	Mike Galbraith <efault@gmx.de>,
	linux-kernel@vger.kernel.org
Subject: Re: Very high CPU load when idle with 3.0-rc1
Date: Wed, 1 Jun 2011 07:37:43 -0700	[thread overview]
Message-ID: <20110601143743.GA2274@linux.vnet.ibm.com> (raw)
In-Reply-To: <1306926339.2353.191.camel@twins>

On Wed, Jun 01, 2011 at 01:05:39PM +0200, Peter Zijlstra wrote:
> On Mon, 2011-05-30 at 18:45 -0700, Paul E. McKenney wrote:
> > > > Because priority boosting doesn't help unless the callbacks also run
> > > > RT priority.
> > > > 
> > > > I could make it so that they ran as normal tasks if !RCU_BOOST, but
> > > > they would still need to run as RT tasks for RCU_BOOST.  I figured
> > > > running them the same way in both cases would be simpler.
> > > 
> > > Ah, I thought you'd boost the threads along with the waiters, to the
> > > same prio so that they wouldn't disturb higher priority tasks for no
> > > reason.
> > 
> > I considered that, but working out when it is OK to deboost them is
> > decidedly non-trivial. 
> 
> Where exactly is the problem there? The boost lasts for as long as it
> takes to finish the grace period, right? There's a distinct set of
> callbacks associated with each grace-period, right? In which case you
> can de-boost your thread the moment you're done processing that set.
> 
> Or am I simply confused about how all this is supposed to work?

The main complications are: (1) the fact that it is hard to tell exactly
which grace period to wait for, this one or the next one, and (2) the
fact that callbacks get shuffled when CPUs go offline.

That said, it might be possible if we are willing to live with some
approximate behavior.  For example, always waiting for the next grace
period (rather than the current one) to finish, and boosting through the
extra callbacks in case where a given CPU "adopts" callbacks that must
be boosted when that CPU also has some callbacks whose priority must be
boosted and some that need not be.

The reason I am not all that excited about taking this approach is that
it doesn't help worst-case latency.

Plus the current implementation is just a less-precise approximation.
(Sorry, couldn't resist!)

							Thanx, Paul

  reply	other threads:[~2011-06-01 14:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30  5:59 Very high CPU load when idle with 3.0-rc1 Damien Wyart
2011-05-30 11:34 ` Peter Zijlstra
2011-05-30 12:17   ` Ingo Molnar
2011-05-30 13:10   ` Mike Galbraith
2011-05-30 16:23   ` Paul E. McKenney
2011-05-30 16:41     ` Paul E. McKenney
2011-05-30 16:47       ` Peter Zijlstra
2011-05-30 16:46     ` Peter Zijlstra
2011-05-30 21:29       ` Paul E. McKenney
2011-05-30 21:35         ` Peter Zijlstra
2011-05-31  1:45           ` Paul E. McKenney
2011-05-30 17:19     ` Peter Zijlstra
2011-05-30 21:28       ` Paul E. McKenney
2011-05-30 21:33         ` Peter Zijlstra
2011-05-31  1:45           ` Paul E. McKenney
2011-06-01 11:05             ` Peter Zijlstra
2011-06-01 14:37               ` Paul E. McKenney [this message]
2011-06-01 16:58                 ` Peter Zijlstra
2011-06-01 18:19                   ` Paul E. McKenney
2011-05-31 12:30   ` [tip:core/urgent] rcu: Cure load woes tip-bot for Peter Zijlstra
2011-05-30 11:50 ` Very high CPU load when idle with 3.0-rc1 Damien Wyart
2011-05-30 12:22 ` Morten P.D. Stevens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110601143743.GA2274@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=damien.wyart@free.fr \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.