Re: [PATCH 08/19] OpenRISC: Timekeeping

From: Arnd Bergmann <arnd@arndb.de>
To: Jonas Bonn <jonas@southpole.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/19] OpenRISC: Timekeeping
Date: Sun, 19 Jun 2011 21:06:19 +0200	[thread overview]
Message-ID: <201106192106.19667.arnd@arndb.de> (raw)
In-Reply-To: <1308483825-6023-9-git-send-email-jonas@southpole.se>

> + arch/openrisc/kernel/time.c       |  182 +++++++++++++++++++++++++++++++++++++

Would this fit into drivers/clocksource, at least partly?

> +static struct clocksource openrisc_timer = {
> +	.name		= "openrisc_timer",
> +        .rating         = 200,
> +	.read		= openrisc_timer_read,
> +        .mask           = CLOCKSOURCE_MASK(32),
> +        .flags          = CLOCK_SOURCE_IS_CONTINUOUS,
> +};
> +
> +static int __init openrisc_timer_init(void)
> +{
> +        if (clocksource_register_hz(&openrisc_timer, cpuinfo.clock_frequency))
> +                panic("failed to register clocksource");
> +
> +	/* Enable the incrementer: 'continuous' mode with interrupt disabled */
> +        mtspr(SPR_TTMR, SPR_TTMR_CR);
> +
> +        return 0;
> +}

You have soem whitespace damage here. It would be good to run your patches
through scripts/checkpatch.pl and fix up everything reported there.

	Arnd