From: Francois Romieu <romieu@fr.zoreil.com>
To: Hayes Wang <hayeswang@realtek.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/6] r8169: add ERI functions
Date: Tue, 5 Jul 2011 20:55:45 +0200 [thread overview]
Message-ID: <20110705185545.GD5105@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1309859095-32031-4-git-send-email-hayeswang@realtek.com>
Hayes Wang <hayeswang@realtek.com> :
[...]
> @@ -1046,6 +1046,49 @@ static u32 rtl_csi_read(void __iomem *ioaddr, int addr)
> return value;
> }
>
> +static
> +void rtl_eri_write(void __iomem *ioaddr, int addr, u32 mask, u32 val, int type)
> +{
> + unsigned int i;
> +
> + BUG_ON((addr & 3) || (mask == 0));
> + RTL_W32(ERIDR, val);
> + RTL_W32(ERIAR, ERIAR_WRITE_CMD | type | mask | addr);
> +
> + for (i = 0; i < 100; i++) {
> + udelay(100);
> + if (!(RTL_R32(ERIAR) & ERIAR_FLAG))
> + break;
I'd rather reverse those if possible : implicit posted write flushing read,
then udelay.
--
Ueimor
next prev parent reply other threads:[~2011-07-05 19:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 9:44 [PATCH net-next 1/6] r8169: adjust some registers Hayes Wang
2011-07-05 9:44 ` [PATCH net-next 2/6] r8169: modify the flow hw reset Hayes Wang
2011-07-05 18:55 ` Francois Romieu
2011-07-06 7:48 ` hayeswang
2011-07-05 9:44 ` [PATCH net-next 3/6] r8169: adjust the settings about RxConfig Hayes Wang
2011-07-05 18:55 ` Francois Romieu
2011-07-05 9:44 ` [PATCH net-next 4/6] r8169: add ERI functions Hayes Wang
2011-07-05 18:55 ` Francois Romieu [this message]
2011-07-05 9:44 ` [PATCH net-next 5/6] r8169: fix wake on lan setting for 8111E Hayes Wang
2011-07-05 18:55 ` Francois Romieu
2011-07-05 9:44 ` [PATCH net-next 6/6] r8169: support RTL8111E-VL Hayes Wang
2011-07-05 18:56 ` Francois Romieu
2011-07-05 18:53 ` [PATCH net-next 1/6] r8169: adjust some registers Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705185545.GD5105@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.