From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Write MAC address whenever ethernet subsystem is initialized
Date: Fri, 26 Aug 2011 15:20:20 -0400 [thread overview]
Message-ID: <201108261520.26348.vapier@gentoo.org> (raw)
In-Reply-To: <1314362614-27958-1-git-send-email-inguin@gmx.de>
On Friday, August 26, 2011 08:43:34 Ingo van Lil wrote:
> @@ -261,11 +261,6 @@ int eth_initialize(bd_t *bis)
>
> memcpy(dev->enetaddr, env_enetaddr, 6);
> }
> - if (dev->write_hwaddr &&
> - !eth_mac_skip(eth_number) &&
> - is_valid_ether_addr(dev->enetaddr)) {
> - dev->write_hwaddr(dev);
> - }
removing this breaks the original reason write_hwaddr was added in the first
place: people want the MAC programmed into the hardware even if they dont use
the network.
we should probably add an explicit comment above this block so people dont try
and "fix it" in the future.
> @@ -347,8 +342,14 @@ int eth_init(bd_t *bis)
> do {
> uchar env_enetaddr[6];
>
> - if (eth_getenv_enetaddr_by_index(eth_number, env_enetaddr))
> + if (eth_getenv_enetaddr_by_index(eth_number, env_enetaddr)) {
> memcpy(dev->enetaddr, env_enetaddr, 6);
> + if (dev->write_hwaddr &&
> + !eth_mac_skip(eth_number) &&
> + is_valid_ether_addr(dev->enetaddr)) {
> + dev->write_hwaddr(dev);
> + }
> + }
this changes the current API between the common layer and the drivers. i'm
not saying that's a bad thing, just that we need to:
(1) update the documentation (see doc/README.{drivers.eth,enetaddr})
(2) update the drivers which manually call their write_hwaddr() in their
init() func to no longer do that
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110826/227c79ac/attachment.pgp
prev parent reply other threads:[~2011-08-26 19:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 9:24 [U-Boot] [PATCH] Write MAC address whenever ethernet subsystem is initialized Ingo van Lil
2011-08-26 12:37 ` Sergei Shtylyov
2011-08-26 12:43 ` Ingo van Lil
2011-08-26 19:20 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108261520.26348.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.