From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Flatten and solidify block_dev_desc layout
Date: Fri, 21 Oct 2011 21:09:14 +0200 [thread overview]
Message-ID: <20111021190914.8C7DB18AE81C@gemini.denx.de> (raw)
In-Reply-To: <1319178708-10881-2-git-send-email-clchiou@chromium.org>
Dear Che-Liang Chiou,
In message <1319178708-10881-2-git-send-email-clchiou@chromium.org> you wrote:
> The block_dev_desc struct has #ifdef on lba48 and variable-size on lba
> and so its layout varies from config to config. At least part_efi.c has
> partially complained about this.
>
> This patch makes lba48 be always defined and lba be fixed to largest
> size that an LBA would need so that the block_dev_desc layout would be
> an invariant with respect to configurations.
>
> Doing so would waste a few extra bytes per struct block_dev_desc, which
> I believe is not critical.
How much exactly is "a few bytes"?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As long as we're going to reinvent the wheel again, we might as well
try making it round this time. - Mike Dennison
next prev parent reply other threads:[~2011-10-21 19:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 6:31 [U-Boot] [PATCH 0/2] api: extend accessible set of block device attributes Che-Liang Chiou
2011-10-21 6:31 ` [U-Boot] [PATCH 1/2] Flatten and solidify block_dev_desc layout Che-Liang Chiou
2011-10-21 19:09 ` Wolfgang Denk [this message]
2011-10-24 3:36 ` Che-liang Chiou
2011-10-24 10:49 ` Detlev Zundel
2011-10-21 6:31 ` [U-Boot] [PATCH 2/2] api: storage: Share attributes with block_dev_desc Che-Liang Chiou
2012-01-08 7:26 ` Mike Frysinger
2011-10-21 7:03 ` [U-Boot] [PATCH 1/2] Flatten and solidify block_dev_desc layout Che-Liang Chiou
2011-10-21 16:06 ` [U-Boot] [PATCH 0/2] api: extend accessible set of block device attributes Detlev Zundel
2011-10-24 3:36 ` Che-liang Chiou
2011-10-24 9:32 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111021190914.8C7DB18AE81C@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.