From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965184Ab2CGSuo (ORCPT ); Wed, 7 Mar 2012 13:50:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13735 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965049Ab2CGSum (ORCPT ); Wed, 7 Mar 2012 13:50:42 -0500 Date: Wed, 7 Mar 2012 13:50:37 -0500 From: Jason Baron To: Roland McGrath Cc: akpm@linux-foundation.org, avi@redhat.com, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org Subject: Re: [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag Message-ID: <20120307185035.GA2409@redhat.com> References: <3290280b610108e3766e1f82b7d8c74cb688cba5.1331137504.git.jbaron@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 07, 2012 at 09:59:58AM -0800, Roland McGrath wrote: > On Wed, Mar 7, 2012 at 9:00 AM, Jason Baron wrote: > > +       if (vma_name) { > > +               if ((strcmp(vma_name, "[vdso]") == 0) || > > +                   (strcmp(vma_name, "[vectors]") == 0) || > > +                   (strcmp(vma_name, "[vsyscall]") == 0)) > > That's just disgusting. well, sure, we can provide an arch interface, for this check. I'm more concerned with the general idea. If it seems ok, I can re-do this bit with an arch interface. Thanks, -Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47075) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5Lwn-000511-CH for qemu-devel@nongnu.org; Wed, 07 Mar 2012 13:50:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5Lwg-0005sy-6w for qemu-devel@nongnu.org; Wed, 07 Mar 2012 13:50:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5Lwf-0005sY-Us for qemu-devel@nongnu.org; Wed, 07 Mar 2012 13:50:42 -0500 Date: Wed, 7 Mar 2012 13:50:37 -0500 From: Jason Baron Message-ID: <20120307185035.GA2409@redhat.com> References: <3290280b610108e3766e1f82b7d8c74cb688cba5.1331137504.git.jbaron@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roland McGrath Cc: qemu-devel@nongnu.org, akpm@linux-foundation.org, avi@redhat.com, linux-kernel@vger.kernel.org On Wed, Mar 07, 2012 at 09:59:58AM -0800, Roland McGrath wrote: > On Wed, Mar 7, 2012 at 9:00 AM, Jason Baron wrote: > > + =A0 =A0 =A0 if (vma_name) { > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 if ((strcmp(vma_name, "[vdso]") =3D=3D = 0) || > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (strcmp(vma_name, "[vectors]") = =3D=3D 0) || > > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (strcmp(vma_name, "[vsyscall]")= =3D=3D 0)) >=20 > That's just disgusting. well, sure, we can provide an arch interface, for this check. I'm more concerned with the general idea. If it seems ok, I can re-do this bit with an arch interface. Thanks, -Jason