From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030299Ab2CGVgz (ORCPT ); Wed, 7 Mar 2012 16:36:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:65074 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965079Ab2CGVgq (ORCPT ); Wed, 7 Mar 2012 16:36:46 -0500 Date: Wed, 7 Mar 2012 16:36:37 -0500 From: Jason Baron To: Chris Metcalf Cc: Roland McGrath , akpm@linux-foundation.org, avi@redhat.com, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org Subject: Re: [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag Message-ID: <20120307213637.GC2409@redhat.com> References: <3290280b610108e3766e1f82b7d8c74cb688cba5.1331137504.git.jbaron@redhat.com> <20120307185035.GA2409@redhat.com> <20120307194302.7BD142C0C3@topped-with-meat.com> <20120307211909.GB2409@redhat.com> <4F57D296.8090608@tilera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F57D296.8090608@tilera.com> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 07, 2012 at 04:26:46PM -0500, Chris Metcalf wrote: > On 3/7/2012 4:19 PM, Jason Baron wrote: > > On Wed, Mar 07, 2012 at 11:43:02AM -0800, Roland McGrath wrote: > >>> well, sure, we can provide an arch interface, for this check. I'm more > >>> concerned with the general idea. If it seems ok, I can re-do this bit > >>> with an arch interface. > >> Anything based on strcmp is dismal. VM_ALWAYSDUMP was nice and clean. > >> A hook along the lines of arch_vma_name would be clean enough I suppose. > >> In fact, there is only one instance today (tile) where arch_vma_name()!=NULL > >> wouldn't do just what you need. > >> > > Yeah, so I think something like the following would work (adding Tile > > maintainer to 'cc list). > > Thanks! > > My instinct would be not to special-case it in always_dump_vma(). Since > it's just a one-page region anyway, and it is at least potentially > interesting, I'm happy to always dump it. Alternately, we can just get rid > of the "[intrpt]" name, which I just put in to be cute (and since it was > easy to identify the mapping in question). Regardless, since that region > doesn't exist on our current 64-bit architecture, I'm not too concerned > with how it's handled going forward, since I expect the 32-bit platform to > become less popular over time. I'd vote for generic code cleanliness. > Ok, I'll just always dump it. Thanks! -Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5OXg-0006T5-DE for qemu-devel@nongnu.org; Wed, 07 Mar 2012 16:37:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5OXL-0005tL-AP for qemu-devel@nongnu.org; Wed, 07 Mar 2012 16:37:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60362) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5OXL-0005t0-1m for qemu-devel@nongnu.org; Wed, 07 Mar 2012 16:36:43 -0500 Date: Wed, 7 Mar 2012 16:36:37 -0500 From: Jason Baron Message-ID: <20120307213637.GC2409@redhat.com> References: <3290280b610108e3766e1f82b7d8c74cb688cba5.1331137504.git.jbaron@redhat.com> <20120307185035.GA2409@redhat.com> <20120307194302.7BD142C0C3@topped-with-meat.com> <20120307211909.GB2409@redhat.com> <4F57D296.8090608@tilera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F57D296.8090608@tilera.com> Subject: Re: [Qemu-devel] [PATCH 1/2] core dump: drop VM_ALWAYSDUMP flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Metcalf Cc: qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, avi@redhat.com, Roland McGrath On Wed, Mar 07, 2012 at 04:26:46PM -0500, Chris Metcalf wrote: > On 3/7/2012 4:19 PM, Jason Baron wrote: > > On Wed, Mar 07, 2012 at 11:43:02AM -0800, Roland McGrath wrote: > >>> well, sure, we can provide an arch interface, for this check. I'm more > >>> concerned with the general idea. If it seems ok, I can re-do this bit > >>> with an arch interface. > >> Anything based on strcmp is dismal. VM_ALWAYSDUMP was nice and clean. > >> A hook along the lines of arch_vma_name would be clean enough I suppose. > >> In fact, there is only one instance today (tile) where arch_vma_name()!=NULL > >> wouldn't do just what you need. > >> > > Yeah, so I think something like the following would work (adding Tile > > maintainer to 'cc list). > > Thanks! > > My instinct would be not to special-case it in always_dump_vma(). Since > it's just a one-page region anyway, and it is at least potentially > interesting, I'm happy to always dump it. Alternately, we can just get rid > of the "[intrpt]" name, which I just put in to be cute (and since it was > easy to identify the mapping in question). Regardless, since that region > doesn't exist on our current 64-bit architecture, I'm not too concerned > with how it's handled going forward, since I expect the 32-bit platform to > become less popular over time. I'd vote for generic code cleanliness. > Ok, I'll just always dump it. Thanks! -Jason