On Tue, Mar 13, 2012 at 01:33:40PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote: > update to use devm_kzalloc for private data Hmm, you need really to work on the commit messages, not everybody is familiar with DT and its implications: "To achieve DT support, we need to populate a custom platform_data in a private struct from DT information. To simplify code, the adapter and algorithm are also put into the private struct." Something like this? > --- > v4: > > fix timeout You need to work on the changelogs as well :) > use gpio_is_valid Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |