From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mike Frysinger <vapier@gentoo.org>
Cc: "Ted Ts'o" <tytso@mit.edu>,
Artem Bityutskiy <dedekind1@gmail.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ext2: Don't export ext2_mask_flags() to user space
Date: Sat, 24 Mar 2012 08:37:56 +0000 [thread overview]
Message-ID: <20120324083756.GJ6589@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAMjpGUdnisfawUNThOu_+kbH54SWXCf6PhZwyWrV=B8SNjMRNg@mail.gmail.com>
On Sat, Mar 24, 2012 at 02:50:38AM -0400, Mike Frysinger wrote:
> > and that's it. ??blackfin and do_mounts_rd are doing the same thing (blackfin -
> > buggy, AFAICS).
>
> buggy how ? they're not exactly the same as the Blackfin code is
> setting things up for the uClinux MTD map. it isn't parsing the
> filesystem itself (ignoring the size extraction from the superblock).
Compare and you'll see... Block size on ext2 may be bigger than 1Kb;
->s_log_block_size gives the shift (1Kb -> 0, 2Kb -> 1, etc.) Offset
0x18 in superblock, __le32...
Anyway, I've pushed that into vfs.git#master along with other minor stuff
right now; the last 5 commits in there are handling of ext2 and ext3 headers,
starting with "ext2: No longer export ext2_fs.h to user space" by
Thierry Reding, with the next 3 after it doing the move and trimming...
Should propagate to git.kernel.org in a few.
I've left the nfsd mess alone for now; it's too ugly to live, but I don't
want to trigger the bikeshedding from hell that happens every time somebody
brings pathconf() up. Not worth bothering with, just to move two macros to
fs/ext2/ext2.h where they really belong...
next prev parent reply other threads:[~2012-03-24 8:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 21:50 [PATCH] ext2: Don't export ext2_mask_flags() to user space Thierry Reding
2012-03-21 22:23 ` Jan Kara
2012-03-21 23:16 ` Ted Ts'o
2012-03-22 5:53 ` Thierry Reding
2012-03-22 6:00 ` Artem Bityutskiy
2012-03-22 16:28 ` Ted Ts'o
2012-03-22 16:47 ` Thierry Reding
2012-03-22 18:31 ` Ted Ts'o
2012-03-23 9:27 ` [PATCH] ext2: No longer export ext2_fs.h " Thierry Reding
2012-03-23 9:27 ` Thierry Reding
2012-03-23 13:13 ` Ted Ts'o
2012-03-23 17:55 ` Al Viro
2012-03-24 21:51 ` Ted Ts'o
2012-03-24 22:16 ` H. Peter Anvin
2012-03-25 1:16 ` Ted Ts'o
2012-03-22 17:31 ` [PATCH] ext2: Don't export ext2_mask_flags() " Al Viro
2012-03-23 0:25 ` Andreas Dilger
2012-03-24 6:51 ` Mike Frysinger
2012-03-24 6:50 ` Mike Frysinger
2012-03-24 6:50 ` Mike Frysinger
2012-03-24 8:37 ` Al Viro [this message]
2012-03-24 17:59 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120324083756.GJ6589@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dedekind1@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@avionic-design.de \
--cc=tytso@mit.edu \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.