From: Jonathan Nieder <jrnieder@gmail.com>
To: marcnarc@xiplink.com
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCHv2] fetch: Only call a new ref a "branch" if it's under refs/heads/.
Date: Fri, 13 Apr 2012 15:07:21 -0500 [thread overview]
Message-ID: <20120413200721.GA3549@burratino> (raw)
In-Reply-To: <1334336904-18649-1-git-send-email-marcnarc@xiplink.com>
marcnarc@xiplink.com wrote:
> --- a/builtin/fetch.c
> +++ b/builtin/fetch.c
> @@ -293,14 +293,18 @@ static int update_local_ref(struct ref *ref,
> const char *msg;
> const char *what;
> int r;
> - if (!strncmp(ref->name, "refs/tags/", 10)) {
> + if (!prefixcmp(ref->name, "refs/tags/")) {
This part is just a clean-up, right?
> msg = "storing tag";
> what = _("[new tag]");
> }
> - else {
> + else if (!prefixcmp(ref->name, "refs/heads/")) {
> msg = "storing head";
> what = _("[new branch]");
> }
> + else {
> + msg = "storing ref";
> + what = _("[new ref]");
> + }
Neat. I like it, for what it's worth.
Sincerely,
Jonathan
next prev parent reply other threads:[~2012-04-13 20:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 17:08 [PATCHv2] fetch: Only call a new ref a "branch" if it's under refs/heads/ marcnarc
2012-04-13 20:07 ` Jonathan Nieder [this message]
2012-04-16 14:26 ` Marc Branchaud
2012-04-13 21:13 ` Jeff King
2012-04-13 21:53 ` Jonathan Nieder
2012-04-13 22:39 ` Junio C Hamano
2012-04-16 14:58 ` Marc Branchaud
2012-04-16 15:00 ` Jeff King
2012-04-16 15:52 ` [PATCHv3] fetch: Use the remote's ref name to decide how to describe new refs marcnarc
2012-04-16 16:10 ` Jonathan Nieder
2012-04-16 17:59 ` Junio C Hamano
2012-04-16 20:21 ` Marc Branchaud
2012-04-16 22:08 ` [PATCHv4 0/3] fetch: Only call a new ref a "branch" if it's under refs/heads/ marcnarc
2012-04-16 22:08 ` [PATCH 1/3] submodules: recursive fetch also checks new tags for submodule commits marcnarc
2012-04-16 22:08 ` [PATCH 2/3] fetch: Pass both the full remote ref and its short name to update_local_ref() marcnarc
2012-04-16 22:08 ` [PATCH 3/3] fetch: Use the remote's ref name to decide how to describe new refs marcnarc
2012-04-16 22:34 ` Jonathan Nieder
2012-04-17 7:53 ` Zbigniew Jędrzejewski-Szmek
2012-04-17 7:57 ` Jonathan Nieder
2012-04-17 8:39 ` Zbigniew Jędrzejewski-Szmek
2012-04-17 14:23 ` Marc Branchaud
2012-04-17 15:18 ` Jonathan Nieder
2012-04-17 15:26 ` [PATCHv4 0/3] fetch: Only call a new ref a "branch" if it's under refs/heads/ Junio C Hamano
2012-04-17 15:28 ` Junio C Hamano
2012-04-17 19:30 ` Marc Branchaud
2012-04-17 22:29 ` Jeff King
2012-04-16 16:08 ` [PATCHv2] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413200721.GA3549@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marcnarc@xiplink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.