From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/3] acpi_video: Intel video is not always i915
Date: Wed, 25 Apr 2012 11:27:11 +0100 [thread overview]
Message-ID: <20120425112711.613a3cf9@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <20120424223022.GA27765@srcf.ucam.org>
On Tue, 24 Apr 2012 23:30:22 +0100
Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Tue, Apr 24, 2012 at 11:31:17PM +0100, Alan Cox wrote:
> > On Tue, 24 Apr 2012 22:02:18 +0100
> > Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> > > The PowerVR Intels I'd seen had the opregion address in the 0xfc
> > > register as well. Is this no longer true on the latest?
> >
> > PowerVR does - i740 never did.
> >
> > The PowerVR 0xfc poking also doesn't currently work once the driver takes
> > over because it isn't yet implementing the driver end of the weird ACPI
> > messaging/event stuff.
> >
> > Once it does the GMA500 will be able to do an ACPI video register, but we
> > will still need the check to get the ifdeffery right for what drivers are
> > compiled for the kernel.
>
> Right now you seem to set opregion unconditionally on PVR, which seems
> to be equivalent to the 0xfc check that was there before - I can
> understand excluding i740, but the PVR check could be left with the gen
> hardware one?
Not really - they are two drivers. If you build with i915 and not GMA500
you need the opregion for one and the acpi fallback for the other, and
vice versa. So we have to check both CONFIG_xxx macro sets.
Right now GMA500 needs the ACPI video stuff never to be enabled on some
machines. Until we've got full opregion support in the driver that won't
change.
Alan
next prev parent reply other threads:[~2012-04-25 10:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 15:44 [PATCH 1/3] acpi_video: fix leaking PCI references Alan Cox
2012-04-24 15:45 ` [PATCH 2/3] acpi_video: Intel video is not always i915 Alan Cox
2012-04-24 21:02 ` Matthew Garrett
2012-04-24 22:31 ` Alan Cox
2012-04-24 22:30 ` Matthew Garrett
2012-04-25 10:27 ` Alan Cox [this message]
2012-04-25 11:31 ` Matthew Garrett
2012-04-25 12:24 ` Alan Cox
2012-04-25 12:40 ` Matthew Garrett
2012-04-25 12:49 ` Alan Cox
2012-04-25 12:48 ` Matthew Garrett
2012-04-24 15:45 ` [PATCH 3/3] gma500: don't register the ACPI video bus Alan Cox
2012-04-25 13:33 [PATCH 1/3] acpi_video: fix leaking PCI references Alan Cox
2012-04-25 13:33 ` [PATCH 2/3] acpi_video: Intel video is not always i915 Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120425112711.613a3cf9@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.