From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760443Ab2D0PMj (ORCPT ); Fri, 27 Apr 2012 11:12:39 -0400 Received: from s15943758.onlinehome-server.info ([217.160.130.188]:59664 "EHLO mail.x86-64.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760370Ab2D0PMi (ORCPT ); Fri, 27 Apr 2012 11:12:38 -0400 Date: Fri, 27 Apr 2012 17:12:30 +0200 From: Borislav Petkov To: Joe Perches Cc: Borislav Petkov , Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List , Aristeu Rozanski , Doug Thompson , Mark Gross , Jason Uhlenkott , Tim Small , Ranganathan Desikan , "Arvind R." , Olof Johansson , Egor Martovetsky , Chris Metcalf , Michal Marek , Jiri Kosina , Dmitry Eremin-Solenikov , Benjamin Herrenschmidt , Hitoshi Mitake , Andrew Morton , Niklas =?iso-8859-1?Q?S=F6derlund?= , Shaohui Xie , Josh Boyer , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers Message-ID: <20120427151230.GB18798@aftab.osrc.amd.com> References: <1335289087-11337-1-git-send-email-mchehab@redhat.com> <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> <1335535895.25521.7.camel@joe2Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1335535895.25521.7.camel@joe2Laptop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 27, 2012 at 10:11:35AM -0400, Joe Perches wrote: > > > -extern struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > > - unsigned nr_chans, int edac_index); > > > +struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > > + unsigned nr_chans, int edac_index); > > > > Why not "extern"? > > Using extern function prototypes in .h files > isn't generally necessary nor is extern the > more common kernel style. Searching for it, there's this discussion, for example: http://gcc.gnu.org/ml/gcc/2009-04/msg00812.html Maybe we should put a small note in Documentation/CodingStyle what the kernel preference is and hold people to it. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.x86-64.org (s15943758.onlinehome-server.info [217.160.130.188]) by ozlabs.org (Postfix) with ESMTP id BE7FCB6F6E for ; Sat, 28 Apr 2012 01:12:41 +1000 (EST) Date: Fri, 27 Apr 2012 17:12:30 +0200 From: Borislav Petkov To: Joe Perches Subject: Re: [PATCH EDACv16 1/2] edac: Change internal representation to work with layers Message-ID: <20120427151230.GB18798@aftab.osrc.amd.com> References: <1335289087-11337-1-git-send-email-mchehab@redhat.com> <1335291342-14922-1-git-send-email-mchehab@redhat.com> <20120427133304.GE9626@aftab.osrc.amd.com> <1335535895.25521.7.camel@joe2Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1335535895.25521.7.camel@joe2Laptop> Cc: Mauro Carvalho Chehab , Jason Uhlenkott , Aristeu Rozanski , Hitoshi Mitake , Shaohui Xie , Mark Gross , Dmitry Eremin-Solenikov , Ranganathan Desikan , Borislav Petkov , Egor Martovetsky , Niklas =?iso-8859-1?Q?S=F6derlund?= , Tim Small , "Arvind R." , Chris Metcalf , Doug Thompson , Linux Edac Mailing List , Michal Marek , Jiri Kosina , Linux Kernel Mailing List , Olof Johansson , Andrew Morton , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Apr 27, 2012 at 10:11:35AM -0400, Joe Perches wrote: > > > -extern struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > > - unsigned nr_chans, int edac_index); > > > +struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > > + unsigned nr_chans, int edac_index); > > > > Why not "extern"? > > Using extern function prototypes in .h files > isn't generally necessary nor is extern the > more common kernel style. Searching for it, there's this discussion, for example: http://gcc.gnu.org/ml/gcc/2009-04/msg00812.html Maybe we should put a small note in Documentation/CodingStyle what the kernel preference is and hold people to it. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551